From: Mark Brown <broonie@kernel.org>
To: Kees Cook <keescook@chromium.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Szabolcs Nagy <szabolcs.nagy@arm.com>,
Jeremy Linton <jeremy.linton@arm.com>,
"H . J . Lu" <hjl.tools@gmail.com>,
Yu-cheng Yu <yu-cheng.yu@intel.com>,
Eric Biederman <ebiederm@xmission.com>,
linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
libc-alpha@sourceware.org, Dave Martin <Dave.Martin@arm.com>
Subject: Re: [PATCH v10 1/2] elf: Allow architectures to parse properties on the main executable
Date: Tue, 8 Mar 2022 12:21:04 +0000 [thread overview]
Message-ID: <YidKMHDSifdDcnPL@sirena.org.uk> (raw)
In-Reply-To: <202203071551.DBABE01@keescook>
[-- Attachment #1.1: Type: text/plain, Size: 742 bytes --]
On Mon, Mar 07, 2022 at 04:00:15PM -0800, Kees Cook wrote:
> On Mon, Feb 28, 2022 at 01:06:05PM +0000, Mark Brown wrote:
> > static inline int arch_parse_elf_property(u32 type, const void *data,
> > size_t datasz, bool compat,
> > + bool has_interp, bool is_interp,
> > struct arch_elf_state *arch)
> Adding more and more args to a functions like this gives me the sense
> that some kind of argument structure is needed.
> Once I get enough unit testing written in here, I'm hoping to refactor
> a bunch of this. To the future! :)
Yes, this code is not lovely. I'll leave cleanups to future work
though, it seems out of scope here and I'm not sure how good an idea it
is to do too much without more solid testing.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-03-08 12:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-28 13:06 [PATCH v10 0/2] arm64: Enable BTI for the executable as well as the interpreter Mark Brown
2022-02-28 13:06 ` [PATCH v10 1/2] elf: Allow architectures to parse properties on the main executable Mark Brown
2022-03-08 0:00 ` Kees Cook
2022-03-08 9:45 ` Will Deacon
2022-03-08 12:21 ` Mark Brown [this message]
2022-02-28 13:06 ` [PATCH v10 2/2] arm64: Enable BTI for main executable as well as the interpreter Mark Brown
2022-02-28 18:24 ` Catalin Marinas
2022-03-07 22:03 ` [PATCH v10 0/2] arm64: Enable BTI for the " Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YidKMHDSifdDcnPL@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Dave.Martin@arm.com \
--cc=catalin.marinas@arm.com \
--cc=ebiederm@xmission.com \
--cc=hjl.tools@gmail.com \
--cc=jeremy.linton@arm.com \
--cc=keescook@chromium.org \
--cc=libc-alpha@sourceware.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=szabolcs.nagy@arm.com \
--cc=will@kernel.org \
--cc=yu-cheng.yu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).