* [PATCH] KVM: arm64: Enable Cortex-A510 erratum 2077057 by default
@ 2022-02-25 18:46 Mark Brown
2022-03-02 14:09 ` Catalin Marinas
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Mark Brown @ 2022-02-25 18:46 UTC (permalink / raw)
To: Catalin Marinas, Will Deacon, Marc Zyngier
Cc: linux-arm-kernel, James Morse, kvmarm, Mark Brown
The recently added configuration option for Cortex A510 erratum 2077057 does
not have a "default y" unlike other errata fixes. This appears to simply be
an oversight since the help text suggests enabling the option if unsure and
there's nothing in the commit log to suggest it is intentional.
Fixes: 1dd498e5e26ad ("KVM: arm64: Workaround Cortex-A510's single-step and PAC trap errata")
Signed-off-by: Mark Brown <broonie@kernel.org>
---
arch/arm64/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
index f8e5f64fc40b..fd5f44bfa3e3 100644
--- a/arch/arm64/Kconfig
+++ b/arch/arm64/Kconfig
@@ -685,6 +685,7 @@ config ARM64_ERRATUM_2051678
config ARM64_ERRATUM_2077057
bool "Cortex-A510: 2077057: workaround software-step corrupting SPSR_EL2"
+ default y
help
This option adds the workaround for ARM Cortex-A510 erratum 2077057.
Affected Cortex-A510 may corrupt SPSR_EL2 when the a step exception is
--
2.30.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] KVM: arm64: Enable Cortex-A510 erratum 2077057 by default
2022-02-25 18:46 [PATCH] KVM: arm64: Enable Cortex-A510 erratum 2077057 by default Mark Brown
@ 2022-03-02 14:09 ` Catalin Marinas
2022-03-02 15:01 ` Marc Zyngier
2022-03-02 15:05 ` Marc Zyngier
2022-03-08 18:42 ` Catalin Marinas
2 siblings, 1 reply; 6+ messages in thread
From: Catalin Marinas @ 2022-03-02 14:09 UTC (permalink / raw)
To: Mark Brown
Cc: Will Deacon, Marc Zyngier, linux-arm-kernel, James Morse, kvmarm
On Fri, Feb 25, 2022 at 06:46:58PM +0000, Mark Brown wrote:
> The recently added configuration option for Cortex A510 erratum 2077057 does
> not have a "default y" unlike other errata fixes. This appears to simply be
> an oversight since the help text suggests enabling the option if unsure and
> there's nothing in the commit log to suggest it is intentional.
>
> Fixes: 1dd498e5e26ad ("KVM: arm64: Workaround Cortex-A510's single-step and PAC trap errata")
> Signed-off-by: Mark Brown <broonie@kernel.org>
The fixed commit went in through Marc's KVM tree, so this patch can go
in via the same route. I don't think it's critical for 5.17 (unless
there are pending fixes from Marc already; I don't have any for arm64).
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] KVM: arm64: Enable Cortex-A510 erratum 2077057 by default
2022-03-02 14:09 ` Catalin Marinas
@ 2022-03-02 15:01 ` Marc Zyngier
0 siblings, 0 replies; 6+ messages in thread
From: Marc Zyngier @ 2022-03-02 15:01 UTC (permalink / raw)
To: Catalin Marinas
Cc: Mark Brown, Will Deacon, linux-arm-kernel, James Morse, kvmarm
On Wed, 02 Mar 2022 14:09:06 +0000,
Catalin Marinas <catalin.marinas@arm.com> wrote:
>
> On Fri, Feb 25, 2022 at 06:46:58PM +0000, Mark Brown wrote:
> > The recently added configuration option for Cortex A510 erratum 2077057 does
> > not have a "default y" unlike other errata fixes. This appears to simply be
> > an oversight since the help text suggests enabling the option if unsure and
> > there's nothing in the commit log to suggest it is intentional.
> >
> > Fixes: 1dd498e5e26ad ("KVM: arm64: Workaround Cortex-A510's single-step and PAC trap errata")
> > Signed-off-by: Mark Brown <broonie@kernel.org>
>
> The fixed commit went in through Marc's KVM tree, so this patch can go
> in via the same route. I don't think it's critical for 5.17 (unless
> there are pending fixes from Marc already; I don't have any for arm64).
I don't have anything at the moment, so unless something really urgent
crops up next week, I'll punt that to 5.18.
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] KVM: arm64: Enable Cortex-A510 erratum 2077057 by default
2022-02-25 18:46 [PATCH] KVM: arm64: Enable Cortex-A510 erratum 2077057 by default Mark Brown
2022-03-02 14:09 ` Catalin Marinas
@ 2022-03-02 15:05 ` Marc Zyngier
2022-03-08 18:42 ` Catalin Marinas
2 siblings, 0 replies; 6+ messages in thread
From: Marc Zyngier @ 2022-03-02 15:05 UTC (permalink / raw)
To: Will Deacon, Mark Brown, Catalin Marinas; +Cc: linux-arm-kernel, kvmarm
On Fri, 25 Feb 2022 18:46:58 +0000, Mark Brown wrote:
> The recently added configuration option for Cortex A510 erratum 2077057 does
> not have a "default y" unlike other errata fixes. This appears to simply be
> an oversight since the help text suggests enabling the option if unsure and
> there's nothing in the commit log to suggest it is intentional.
Applied to next, thanks!
[1/1] KVM: arm64: Enable Cortex-A510 erratum 2077057 by default
commit: 4c11113c1a3d10f5b617e5d2b9acd8d1d715450f
Cheers,
M.
--
Without deviation from the norm, progress is not possible.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] KVM: arm64: Enable Cortex-A510 erratum 2077057 by default
2022-02-25 18:46 [PATCH] KVM: arm64: Enable Cortex-A510 erratum 2077057 by default Mark Brown
2022-03-02 14:09 ` Catalin Marinas
2022-03-02 15:05 ` Marc Zyngier
@ 2022-03-08 18:42 ` Catalin Marinas
2022-03-08 18:44 ` Catalin Marinas
2 siblings, 1 reply; 6+ messages in thread
From: Catalin Marinas @ 2022-03-08 18:42 UTC (permalink / raw)
To: Mark Brown
Cc: Will Deacon, Marc Zyngier, linux-arm-kernel, James Morse, kvmarm
On Fri, Feb 25, 2022 at 06:46:58PM +0000, Mark Brown wrote:
> The recently added configuration option for Cortex A510 erratum 2077057 does
> not have a "default y" unlike other errata fixes. This appears to simply be
> an oversight since the help text suggests enabling the option if unsure and
> there's nothing in the commit log to suggest it is intentional.
>
> Fixes: 1dd498e5e26ad ("KVM: arm64: Workaround Cortex-A510's single-step and PAC trap errata")
> Signed-off-by: Mark Brown <broonie@kernel.org>
I don't think Will picked this up, so:
Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] KVM: arm64: Enable Cortex-A510 erratum 2077057 by default
2022-03-08 18:42 ` Catalin Marinas
@ 2022-03-08 18:44 ` Catalin Marinas
0 siblings, 0 replies; 6+ messages in thread
From: Catalin Marinas @ 2022-03-08 18:44 UTC (permalink / raw)
To: Mark Brown
Cc: Will Deacon, Marc Zyngier, linux-arm-kernel, James Morse, kvmarm
On Tue, Mar 08, 2022 at 06:42:45PM +0000, Catalin Marinas wrote:
> On Fri, Feb 25, 2022 at 06:46:58PM +0000, Mark Brown wrote:
> > The recently added configuration option for Cortex A510 erratum 2077057 does
> > not have a "default y" unlike other errata fixes. This appears to simply be
> > an oversight since the help text suggests enabling the option if unsure and
> > there's nothing in the commit log to suggest it is intentional.
> >
> > Fixes: 1dd498e5e26ad ("KVM: arm64: Workaround Cortex-A510's single-step and PAC trap errata")
> > Signed-off-by: Mark Brown <broonie@kernel.org>
>
> I don't think Will picked this up, so:
>
> Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
Ah, I should call it a day. I already acked this patch and Marc queued
it.
--
Catalin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-03-08 18:45 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-25 18:46 [PATCH] KVM: arm64: Enable Cortex-A510 erratum 2077057 by default Mark Brown
2022-03-02 14:09 ` Catalin Marinas
2022-03-02 15:01 ` Marc Zyngier
2022-03-02 15:05 ` Marc Zyngier
2022-03-08 18:42 ` Catalin Marinas
2022-03-08 18:44 ` Catalin Marinas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).