From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 597D5C433EF for ; Tue, 8 Mar 2022 19:08:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IiAwVBQX/6e2bauUOWbMqP2hwc8YDcuI+qZphZcvVLs=; b=rzdbYN8Vjs/dSm dZGad2K0/hRg+K+UdQEqGRocdqj2XfHbcNyqok4kk5F+vYl9PWgTfE3c9mBKHx2JnIlc5g6eIOJPz KARYodotS1I/ctIt3+ijSjDCa53oPbPSM+e0xLW33QpHhx2C3IbdWCibE6RUCbcsfvvoia8tkFcDH SE5keajt7chRJasIiJfO0RHcgQGM4XLWnFaSIhdrUcghllDA8C6/Og+SQaDZAw3xvz2Zj7r26Jl+a rfBuoZmvhA+pCNoubm9udB+R2iaYWZE2ts7KTBfrFY5b3CArQoz8eDEMne7pLfLV4uk2Q4Imo3XAM GRiK51WRMYy1tlNvb5wQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nRfAg-005rZf-92; Tue, 08 Mar 2022 19:06:58 +0000 Received: from mail-pl1-x62a.google.com ([2607:f8b0:4864:20::62a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nRfAc-005rYc-22 for linux-arm-kernel@lists.infradead.org; Tue, 08 Mar 2022 19:06:55 +0000 Received: by mail-pl1-x62a.google.com with SMTP id e2so17932115pls.10 for ; Tue, 08 Mar 2022 11:06:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=fKKD+3hXAeIEEWs0Yh0fwesV2YwX9bcSV9zNUsAN1go=; b=TiAz7VQN6cqOR+YCGQONQ1puu9/mIbyi+3VaF2Y+0BaZGeb5d0zwRpgV+wE8vfCZR2 Pgq+thE1e9/4lXjLiLuSG2aKfs9V+qPTceSPGx1VZpZ/g/nRHQ1xsr06c/+SZh0uL6ZD l59TPYzzVMS9JLJRtFAh9Cax5j2QTPG0/KiPc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=fKKD+3hXAeIEEWs0Yh0fwesV2YwX9bcSV9zNUsAN1go=; b=P8DuaxcavDt0FB3JN4saUaHSwd2TIkASJmdahdH1QZDlqjRKNx8m3wrRz9iSW9WGCg OF26pP5xEIwajJZI89ry8gx310PWsjtyTe3Z1/t40ZFRl7e+zFunk2UfTwV5P9PBB1W9 T/OQLKDRyDnUntqQbqEHEm0N3fWRKRHCcdXm0P/+qX+lxmiNGxbDdXoBShcj7uqRNmVd hVhEUM/gkUNIZcHMRCoZ4LUK4iSjzEHM1jq49wPJTOR7vzN4TUx6vrMIvqh+Ma11jKAL Pv+TU9/3azrqEUwvzPAp8QuimejgRfR8vXhQutwppAezk3wWImay/9UTVgar/uDaSfvK Z6UQ== X-Gm-Message-State: AOAM532cwufMtBVzQW3Y/9FW0m+/hs7zhPNseQr5moPYCirplR/4NpgO jwXUUXP6y1Y8enBFRgJ4/NvGzg== X-Google-Smtp-Source: ABdhPJwSOD+gGbHatfnouDV590+C0yrq8QOnBDEG0WOdkHpfzRz+TxjH6jpl1Ho2oEWdFX5xJuG7yw== X-Received: by 2002:a17:90a:aa8c:b0:1bf:5273:ba28 with SMTP id l12-20020a17090aaa8c00b001bf5273ba28mr6261331pjq.226.1646766412904; Tue, 08 Mar 2022 11:06:52 -0800 (PST) Received: from google.com ([2620:15c:202:201:b3e3:a188:cbfc:3a0e]) by smtp.gmail.com with ESMTPSA id x29-20020aa79a5d000000b004f0ef1822d3sm19910654pfj.128.2022.03.08.11.06.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Mar 2022 11:06:52 -0800 (PST) Date: Tue, 8 Mar 2022 11:06:49 -0800 From: Brian Norris To: Krzysztof Kozlowski , Heiko Stuebner Cc: MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Rob Herring , Lin Huang , Heiko Stuebner , Derek Basehore , linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 01/15] dt-bindings: devfreq: rk3399_dmc: Convert to YAML Message-ID: References: <20220308000945.706701-1-briannorris@chromium.org> <20220307160918.v3.1.I875ab8f28c5155a7d2f103316191954d4b07ac13@changeid> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220308_110654_110659_A78A9609 X-CRM114-Status: GOOD ( 21.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 08, 2022 at 07:03:15PM +0100, Krzysztof Kozlowski wrote: > On 08/03/2022 01:09, Brian Norris wrote: > Apologies for jumping in late in discussion, but how about moving it to > memory-controllers or interconnect directory? devfreq is Linux specific > and DMC sounds a lot like dynamic memory controller. Sure! Will do in v4. > > > > .../bindings/devfreq/rk3399_dmc.txt | 212 ------------- > > .../bindings/devfreq/rk3399_dmc.yaml | 294 ++++++++++++++++++ > > file name: > rockchip,rk3399-dmc.yaml Ack. > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/devfreq/rk3399_dmc.yaml > > + devfreq-events: > > + $ref: /schemas/types.yaml#/definitions/phandle-array > > + minItems: 1 > > + maxItems: 1 > > Rob previously asked about max, but it seems it is only one phandle, > right? Then the type - 'phandle'. Sure! Don't know why I didn't notice that. > > + rockchip,ddr3_odt: > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + description: > > + When the DRAM type is DDR3, this parameter defines the DRAM side ODT > > + strength in ohms. Default value is 120. > > Here and in all other places - instead of describing default value in > description, just add "default: 120". Yep. Most of these properties are actually deprecated in the end, but doesn't hurt to use the facilities available. > Best regards, > Krzysztof Thanks for the reviews! I'll roll them all into v4 shortly. While I'm at it: I think I have Reviewed-by's for all the DT patches (except this one). Given it also touches Rockchip device trees, maybe this all needs to go through Heiko / linux-rockchip? Or if not, it'd be nice if Heiko spoke up to tell the devfreq maintainers instead. Regards, Brian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel