From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B5743C433F5 for ; Wed, 9 Mar 2022 18:46:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=loH0nXhwOrQPOAbMiGtqEkeXhlwlT1NW/5ES2j7On88=; b=xXI+RV4rMH3uAl MB21LwVbG0JW8RXYXdBSHRedjjSqOjnqTfQKWx6IbLZBvXHmfod8Rol36ISMWYiDizOHuFnqfxhHR ywqGojQETX2x/GBMO8m8eT6h1qeBWRIGarINw6Z7LZb6ZwbMPI9sWQPmHvOlZcaraYDBj/mgkf7ov YvLyFWewiEfMQbrW0zEhhSTQ9kfz6Nl5S+OhS4ngcHi3qWyigoTkVQXstOW5OvgIUj3syt4CSnhdG ZDc7RVPwJ83wEHwjjEX/Twj7wZ7qHJ78WoueQjbs2HEn2YI16Nb4+lxyop1OZiUf1rcTcH5hueBTy Ap89o7xatMzZjGPuoRkQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nS1JO-00A8QR-FI; Wed, 09 Mar 2022 18:45:26 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nS1JK-00A8Pt-Vp for linux-arm-kernel@lists.infradead.org; Wed, 09 Mar 2022 18:45:24 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id CBF8BB81C15; Wed, 9 Mar 2022 18:45:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B9305C340E8; Wed, 9 Mar 2022 18:45:17 +0000 (UTC) Date: Wed, 9 Mar 2022 18:45:13 +0000 From: Catalin Marinas To: Nathan Chancellor Cc: Marc Zyngier , linux-arm-kernel@lists.infradead.org, kernel-team@android.com, James Morse , Nick Desaulniers , Will Deacon , llvm@lists.linux.dev Subject: Re: [PATCH] arm64: Paper over ARM_SMCCC_ARCH_WORKAROUND_3 Clang issue Message-ID: References: <20220309155716.3988480-1-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220309_104523_210444_B4AABA21 X-CRM114-Status: GOOD ( 13.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 09, 2022 at 10:50:36AM -0700, Nathan Chancellor wrote: > This diff seems like a somewhat proper solution, as __READ_ONCE() cannot > be used in assembly, but I am open to other suggestions. > > diff --git a/arch/arm64/include/asm/rwonce.h b/arch/arm64/include/asm/rwonce.h > index 1bce62fa908a..56f7b1d4d54b 100644 > --- a/arch/arm64/include/asm/rwonce.h > +++ b/arch/arm64/include/asm/rwonce.h > @@ -5,7 +5,7 @@ > #ifndef __ASM_RWONCE_H > #define __ASM_RWONCE_H > > -#ifdef CONFIG_LTO > +#if defined(CONFIG_LTO) && !defined(__ASSEMBLY__) > > #include > #include > @@ -66,7 +66,7 @@ > }) > > #endif /* !BUILD_VDSO */ > -#endif /* CONFIG_LTO */ > +#endif /* CONFIG_LTO && !__ASSEMBLY__ */ Thanks Nathan. Would you please send a proper patch for this? I'd go with your proposal as it seems more related to LTO than Marc's patch ;). -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel