From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 07FC6C433F5 for ; Wed, 9 Mar 2022 19:21:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IxasdPCRDKhtr/PAay46JdZf1qeJwQgFjKWD43wd2yY=; b=pCq7m4kK0gRpDo iqL4mR5XlIwvspNjb2S3oVYItbUEc0eUWv3JNoLcr8FpAfpQOVQOFdktUc6DW1cy464GzanT+oN0f XOcVHGG1roJdoE5umDrwh0w6Ug/02op9VjqQXSY/+Tj1NoSQ8Itm749t3dNMYllzkPMMhiMLzHg5z xkCZUczuOVK4SWLuGBY+1nsVM85zI+RYFj9WCcRe9WhMHNtH/Z4l4kjRKxnJsEtOeeYCFrhJPiBkZ BG2ljm0by17pI1cIoVTBgWVimknEQplCoImRbfKeLz7D/9jf/G3mrS/m1A/8yFxlD+NwPt1Znz88M LKTljfopM2D6t/mD0SVg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nS1r3-00ADxS-4w; Wed, 09 Mar 2022 19:20:13 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nS1qz-00ADwR-6m for linux-arm-kernel@lists.infradead.org; Wed, 09 Mar 2022 19:20:10 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B6D5B618A8; Wed, 9 Mar 2022 19:20:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A2929C340E8; Wed, 9 Mar 2022 19:20:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646853608; bh=8GG5k+aRyvEM7ZRAADPAKqbxwXD95Kna8A+kMz3JX40=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KTmS/5MYRMuZXRKc24SHA1hdwWMOWx76Sf+Sp3OGW0NRtnl95dw+FjSDYYSwsfmai /3xCmDGqEzJ+retkKCKiBq0CrkPBVwAidp/JS/EezOFm9YBkHdguzMXNwX0jhDWV8g KHgGSGNtBGvZ9QPjQXzpPq9waUS8h5bqqlg+T8ZnzenvS51Tx0MvDoKk6UeFba60q8 Z5gSkVYI3thKlBGQsHj6Pi05blb3taZjzNlqbnWZjMG2Oeedq4Tgs695YsZku6GU0F 6jSYZ4ueF7V1lHHjDhBjUGJdwqB+21Pj4qCXrTXyc60mr/yEsZ4RMEJoIwTYXgobSt ztEzR6A3AhuDg== Date: Wed, 9 Mar 2022 12:20:01 -0700 From: Nathan Chancellor To: Catalin Marinas Cc: Marc Zyngier , linux-arm-kernel@lists.infradead.org, kernel-team@android.com, James Morse , Nick Desaulniers , Will Deacon , llvm@lists.linux.dev Subject: Re: [PATCH] arm64: Paper over ARM_SMCCC_ARCH_WORKAROUND_3 Clang issue Message-ID: References: <20220309155716.3988480-1-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220309_112009_310623_ABDC8FB7 X-CRM114-Status: GOOD ( 15.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 09, 2022 at 06:45:13PM +0000, Catalin Marinas wrote: > On Wed, Mar 09, 2022 at 10:50:36AM -0700, Nathan Chancellor wrote: > > This diff seems like a somewhat proper solution, as __READ_ONCE() cannot > > be used in assembly, but I am open to other suggestions. > > > > diff --git a/arch/arm64/include/asm/rwonce.h b/arch/arm64/include/asm/rwonce.h > > index 1bce62fa908a..56f7b1d4d54b 100644 > > --- a/arch/arm64/include/asm/rwonce.h > > +++ b/arch/arm64/include/asm/rwonce.h > > @@ -5,7 +5,7 @@ > > #ifndef __ASM_RWONCE_H > > #define __ASM_RWONCE_H > > > > -#ifdef CONFIG_LTO > > +#if defined(CONFIG_LTO) && !defined(__ASSEMBLY__) > > > > #include > > #include > > @@ -66,7 +66,7 @@ > > }) > > > > #endif /* !BUILD_VDSO */ > > -#endif /* CONFIG_LTO */ > > +#endif /* CONFIG_LTO && !__ASSEMBLY__ */ > > Thanks Nathan. Would you please send a proper patch for this? I'd go > with your proposal as it seems more related to LTO than Marc's patch ;). Done, thanks Catalin and James for your input! https://lore.kernel.org/r/20220309191633.2307110-1-nathan@kernel.org/ Cheers, Nathan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel