From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C6780C433EF for ; Thu, 10 Mar 2022 22:07:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yZFr0FGc3VuzufFXUbBLDUU6zmXZMrDJ449KJ3zLfnU=; b=2Cx9u1iwWg33SE tmiiH4Tpg3Kd5X5GANpepFls7Z6L9e0/GTMwaUllaOjtOvhLLb30VDvdKLIzDx/uTFd335Y9EM9CD KZ4wgC1x5a9K09GMz/ySB59pN0fST5/+nluqvYCXF1xvgy1r2tfPsBd/IA3iZhY4mc+5PKHrwrrmJ i5s0uoXYZ4X1nnomdu9k7CEVbS4RHw7aVNPqoFKuyICdCGtveR7BdUxBPaJM4r5ds6Bgi0lkGemMm 2PJ8/XnsOK3JNm5D24X4iOXlQ99GMFPM5qZ7EEy1+xrlSKiUkTnPIqa2FKMY3UMFyaZSJ7bt9aB86 CFvtqPc4Hf8FJFIMtX+g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nSQul-00E91X-P9; Thu, 10 Mar 2022 22:05:43 +0000 Received: from mail-oi1-f178.google.com ([209.85.167.178]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nSQui-00E90z-10 for linux-arm-kernel@lists.infradead.org; Thu, 10 Mar 2022 22:05:41 +0000 Received: by mail-oi1-f178.google.com with SMTP id w127so7405531oig.10 for ; Thu, 10 Mar 2022 14:05:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=sToXRItp1gfUeCrvpJh3Xp5twxaBxUIQVRbpXfSXTCo=; b=XBTzOdBZ3xYHuYTx4e1vhNBtnq7Benmq4zX+9/mv+17BSd0I3IiswEIusZZkbin5lI EIdLT2q+CYRSJHU2Vvkglz4oP/dV2MMSgSyuyLqWZAR9pgKLJKYFyqRJetzS94ZoM3nq aMfSFkL/FMSMJT3gaCueC3lcmyx5m/LjQfOAR6qZs8HCcO/hHXEAOki3SFkxOr2KNxW+ QOv6Ubpe9WCLXeIv7slmyOgqXT8YaiP2F8ZuPRCHX0QZRJ+aY0DD6cUCCiQir+YsCrN0 ohQ9CjAiuBkuDrVD2q1vjtk1BIHLrXJ/ldNyUAGbP64lUxNQSvDRnQoQ2KGQxP8epXyc C+Iw== X-Gm-Message-State: AOAM531BskabTzNMTS/2VNYZs9pULd//Qg3D1j6vsLRW7aZdBcC0H+4y azSwjGYjEaV1sQAbWAr/iA== X-Google-Smtp-Source: ABdhPJzxKpsaVdseUDe2Zmx+JlU/UKJ1bLqFJEKAXwy6UIVuFw5j0kc92yXwJCL1IzigNVQ3DVfePw== X-Received: by 2002:a05:6808:f8a:b0:2da:1e9b:e85d with SMTP id o10-20020a0568080f8a00b002da1e9be85dmr4695831oiw.111.1646949938690; Thu, 10 Mar 2022 14:05:38 -0800 (PST) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id 60-20020a9d0f42000000b005ad59a0fe01sm2853401ott.35.2022.03.10.14.05.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Mar 2022 14:05:38 -0800 (PST) Received: (nullmailer pid 2164514 invoked by uid 1000); Thu, 10 Mar 2022 22:05:37 -0000 Date: Thu, 10 Mar 2022 16:05:37 -0600 From: Rob Herring To: Kuldeep Singh Cc: Mark Brown , linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, Robin Murphy , Linus Walleij , Krzysztof Kozlowski Subject: Re: [PATCH v2 1/2] dt-bindings: spi: Update clocks property for ARM pl022 Message-ID: References: <20220308072125.38381-1-singh.kuldeep87k@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220308072125.38381-1-singh.kuldeep87k@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220310_140540_116142_E6DEF1D0 X-CRM114-Status: GOOD ( 14.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 08, 2022 at 12:51:24PM +0530, Kuldeep Singh wrote: > Add missing minItems property to clocks in ARM pl022 bindings. > > This helps in resolving below warnings: > clocks: [[4]] is too short > clock-names: ['apb_pclk'] is too short Again, the error is in the dts files, not the schema. There's 2 possible answers. First, both clock inputs use the same source clock. That's an easy fix. List the clock twice. Second, one clock is not described in DT or visible to s/w. It still has to be in the h/w and could be described as a 'fixed-clock'. A DT should either be all in with clocks or not use the clock binding IMO. Describing some clocks and not others is not a good solution. For example, let's look at bcm-cygnus as one of the single clock examples. The first thing I notice is there is a apb_pclk already defined. The pl330 uses it. The watchdog (also Primecell) lists the source clock twice. So what should pl022 be? IDK, ask the Broadcom folks. If they don't know, then list the source clock twice. That's effectively no change from what we have now. The other issue with allowing a single clock is then any new user can just repeat this mistake. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel