From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ED23DC433EF for ; Fri, 11 Mar 2022 12:08:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/4fjy8/NSJ8YB1zk1JP1wofJieBBa5vkUkDbPnaqCU4=; b=0w7MUcvV2OVK0I IBOosPqLN87+Avus5vBT6UqUxc3cFcpyEJrFbypkhddsDuibc6Kywcsn9LkVvKcO6IToyAdZu3ZkL Yl/qud4SAbhpVEfxNuIZoj/u9+al4FOLLfxJvOLMhz7EIku2xu2asKkLvG71D0RPW60Pa6N7Tlcbh uW9WbC4dEcYfR0MDzhIcWY0yE+CLCXmBL/aCzVr9VQo9o+ShUXhEsG4FZvjNfBSmiOP4fqvhjG5gh HL6gUkhkDBCYcZDOWV30xMnk04FjeIFeGNdyxp5EzKm7Z3W/7VOyO2sV+adz3NQJ0mHgMhwAt90jB 0s4lw5zZ8e1AbyyOKSBw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nSe35-00GKLU-BA; Fri, 11 Mar 2022 12:07:11 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nSe32-00GKKr-7U for linux-arm-kernel@lists.infradead.org; Fri, 11 Mar 2022 12:07:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=P9CckRWFX9nuVoHNgZ4r3Zf8OiO94SzMZDbZRwU+9Fg=; b=lpu61ZeCEFFnDww2NqtykEn/Qt Wlqcrw3bu18X0kcFiCk8xEahxdq7msRrxaUDBmO2iGLsf9eBDnwmv4JHKEFU0EDPUuCWO20DsWJD2 /j548vMfOJCqKCq00ErBazDfx1ay8SnWnNoyICEgSsAncMki7RJFlwkgl2Cegfm5loRI9uz8hkzug DRPzeyacMzWsMjHYdA2DHUupFbPp+gbd4KVZqtWTp/SE6YLvoHmk9gZ6AUdwgZ8UT/3YT+fkBsfvm vmmQv21M6icZRGzARyVcJTYPS3tOaZYPuHPLPc8QQ06gTOAVh18haU0nRglmVIr9LaAj/df0WqrXI 7ZONLQ2g==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:57792) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nSe2x-0002XR-Vu; Fri, 11 Mar 2022 12:07:05 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1nSe2x-0001a9-Mf; Fri, 11 Mar 2022 12:07:03 +0000 Date: Fri, 11 Mar 2022 12:07:03 +0000 From: "Russell King (Oracle)" To: Masahiro Yamada Cc: patches@arm.linux.org.uk, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: decompressor: do not copy source files while building Message-ID: References: <20211030175258.1716178-1-masahiroy@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211030175258.1716178-1-masahiroy@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220311_040708_299765_57BCF9E4 X-CRM114-Status: GOOD ( 12.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Oct 31, 2021 at 02:52:58AM +0900, Masahiro Yamada wrote: > As commit 7ae4a78daacf ("ARM: 8969/1: decompressor: simplify libfdt > builds") stated, copying source files during the build time may not > end up with as clean code as expected. > > Do similar for the other library files for further cleanups of the > Makefile and .gitignore. > > Signed-off-by: Masahiro Yamada Hi, I am now seeing the following every time I run a build: GEN Makefile CALL .../linux-rmk/scripts/atomic/check-atomics.sh CALL .../linux-rmk/scripts/checksyscalls.sh CHK include/generated/compile.h Kernel: arch/arm/boot/Image is ready AS arch/arm/boot/compressed/lib1funcs.o AS arch/arm/boot/compressed/ashldi3.o AS arch/arm/boot/compressed/bswapsdi2.o LD arch/arm/boot/compressed/vmlinux OBJCOPY arch/arm/boot/zImage Kernel: arch/arm/boot/zImage is ready In other words, those three objects are always rebuilt even though they haven't changed. I've tried removing the arch/arm/boot/compressed directory in the build tree, but that doesn't make any difference. Running with V=2 shows: AS arch/arm/boot/compressed/lib1funcs.o - due to lib1funcs.o not in $(tar gets) AS arch/arm/boot/compressed/ashldi3.o - due to ashldi3.o not in $(targets) AS arch/arm/boot/compressed/bswapsdi2.o - due to bswapsdi2.o not in $(targets) It looks to me like: OBJS += lib1funcs.o ashldi3.o bswapsdi2.o in your patch should have been added before: targets := vmlinux vmlinux.lds piggy_data piggy.o \ head.o $(OBJS) Please confirm. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel