From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: stable@kernel.org, Catalin Marinas <catalin.marinas@arm.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2] ARM: fix Thumb2 regression with Spectre BHB
Date: Fri, 11 Mar 2022 19:59:06 +0000 [thread overview]
Message-ID: <YiuqCpRKMCJmKbar@shell.armlinux.org.uk> (raw)
In-Reply-To: <CAHk-=wgFD6drKOADXXWORAUs1U6=OXxVeskczefBx=XqxrKfEg@mail.gmail.com>
On Fri, Mar 11, 2022 at 11:39:35AM -0800, Linus Torvalds wrote:
> On Fri, Mar 11, 2022 at 9:13 AM Russell King (Oracle)
> <rmk+kernel@armlinux.org.uk> wrote:
> >
> > When building for Thumb2, the vectors make use of a local label. Sadly,
> > the Spectre BHB code also uses a local label with the same number which
> > results in the Thumb2 reference pointing at the wrong place. Fix this
> > by changing the number used for the Spectre BHB local label.
>
> Ugh. Those local names are nasty.
>
> And even with this patch - which I'm about to apply right now - I
> think the numbering is horrendous. It seems entirely random with "2"
> being used first in that vector_stub macro, and now 1 and 3 in the
> middle.
I don't like them, but in a macro, I don't think there's much choice.
I don't think choosing some other starting number works either, because
then one ends up always starting at some other number and it's just the
same problem, just with a different starting number.
I guess one way around this would be to use a random local label
number each time, but I suspect there isn't enough range to ensure
they are unique using that method.
I've already mentioned to Nathan that I really wish gas etc would
allow local labels which are not purely numerical (so we can make
them more descriptive.) However, I can see why it isn't permitted,
because of the 'b' and 'f' suffix.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-03-11 20:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-11 17:13 [PATCH v2] ARM: fix Thumb2 regression with Spectre BHB Russell King (Oracle)
2022-03-11 19:39 ` Linus Torvalds
2022-03-11 19:43 ` Linus Torvalds
2022-03-11 19:59 ` Russell King (Oracle) [this message]
2022-03-11 20:41 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YiuqCpRKMCJmKbar@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=stable@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).