From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7C754C433EF for ; Fri, 25 Mar 2022 00:11:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YSwQws2n10IUVVI3a4lv9KntcIfii+1003xt5UbGgd0=; b=1PEZ3YVw7bBAud yG5rIG7Z2c6GtZ4Tr0IuJGbvy6i5M71bGsEdmywOI8CiEcuGBPy7qxdiUsrHj0bMpAnUQXNok0LZS wP0RcY0PUHKpSBax9NYJ4PTXkNymPZwh096RzWxefSi0iocq+zompWhriz525ja6nt5VE8K85BtDI tvIB4VJQ+/TwL33y3BSMN8CAD/Zn+A3CM3yKpF+99tWt9oqL4CgGu1AK8he+Dwp/pDa/FYxyURNe5 wO57gsF24NIdIHlTdID/HWd66rmmuw086hw4WwaNkAwUpF41AQS6SKTAKFWDnxRQk7Nn80nrQ19Ux pjtclzBgQNSf8LVWDX7w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nXXXN-000gfP-TO; Fri, 25 Mar 2022 00:10:42 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nXXXK-000ge8-77 for linux-arm-kernel@lists.infradead.org; Fri, 25 Mar 2022 00:10:39 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=z2w+Bxs2/VRoeScopCDbR6v7XAjkBNcqZU6yJFnJG2k=; b=wCdbhYa/qaFCBRTDPAGP2abac+ 1OhvNWePi54RuNmgcvfI+jdx6l3Dx7vvfrzSfuO771vJf/+dDJ77Qtomvyp3AMrnpY9mDO+l4bT+v 7ZztxNXlAcawyKH68figgoQ0vv0JMtDLf19zixWHwj/CwG2U8EuHhTOmKVxMfqKkvAg8=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1nXXX2-00CWt7-2O; Fri, 25 Mar 2022 01:10:20 +0100 Date: Fri, 25 Mar 2022 01:10:20 +0100 From: Andrew Lunn To: Jae Hyun Yoo Cc: Rob Herring , Joel Stanley , Andrew Jeffery , Jamie Iles , Graeme Gregory , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org Subject: Re: [PATCH] ARM: dts: aspeed: add Nuvia DC-SCM BMC Message-ID: References: <20220324164551.359570-1-quic_jaehyoo@quicinc.com> <88849423-c4a5-0a68-1900-72196395704e@quicinc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220324_171038_277205_3E339B9B X-CRM114-Status: GOOD ( 10.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > The clock delay I mentioned is added into u-boot bootloader in a > patch I'm currently trying to submit. > https://lore.kernel.org/all/20220324165530.359668-1-quic_jaehyoo@quicinc.com/ Do you mean this: +&scu { + mac0-clk-delay = <0x1d 0x1c + 0x10 0x17 + 0x10 0x17>; + mac1-clk-delay = <0x1d 0x10 + 0x10 0x10 + 0x10 0x10>; + mac2-clk-delay = <0x0a 0x04 + 0x08 0x04 + 0x08 0x04>; + mac3-clk-delay = <0x0a 0x04 + 0x08 0x04 + 0x08 0x04>; So the MAC is adding the delay. In that case, setting phy-mode to rgmii is O.K, but it would be nice to add a comment in DT that the bootloader is setting up the MAC to insert the delay. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel