From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EA33FC433EF for ; Sat, 26 Mar 2022 14:01:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4sJAl2ZI2cb4O/qPm8KOZ36QlKkNgE6e+XBiMcs8M8o=; b=anpR91IBrYVo9b bFbSQC5ngvzdHSGVE4AcfeHkkudqQ6Y5yYrVpTQJXe9UB0YPX3+A77t9wDCc+VICj0WF/1CWxj63/ /Jw5xYuZOk6WkafrCLz8UACXXVh2DlWM0v3XcSIgUfMUfIFpDxTVMFRBY30iZgwB0Zwx1o1gK7Zy2 UXb6KCN+aoDU9N522K25W6ID72zX/XZhnu63XIAIvFZbVWQwANPbNPgfWs/hMGobJ0ckeqoR74Krf 07+fLluZi7sI+iyLFtm56h3Sd/h0QSBSS71206t0zirdMBrBtpCPtknF5vMcqDHzdvzIjHRWu1ATF vZ0GXFkN7KzURqlW/CZA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nY6xY-004LcN-JR; Sat, 26 Mar 2022 14:00:04 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nY6xV-004Lb8-Md for linux-arm-kernel@bombadil.infradead.org; Sat, 26 Mar 2022 14:00:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Uzuf8bEc1rNNTK6fgoqjis50bfeCzqYjFGPf8fLGNEY=; b=a30F7pCNpBgwMdAfwg6vkKRhIp kcUN2f6HqrSZgZf50eqOIVLrSxGZxoYEfvQ472yA6EXokKfIGhvqX0NrAAzVk46X/kYDzKCyPeRCU jJkvGEFlar7oAjeg6ABBNCaeYItEFb0BLHhK5VD4qQxGzINVHAYUIWusYPlOYxKs5JwJ9o0ZIQmB2 bpjoWBguapeCkDRwun+iZEr4MLHuN09wtOlkS93jWfNBhx6ellE1qw5WfwXTQdadDqFVCHpUG+PPZ cpcegpw6ZdpySKUAFdhev9MQgYWJF/WMb/E8InXWMMigSpOAAjQs6Tt/VuZSwxaAIJkaQDjBNVlDf PQFb/u4Q==; Received: from [187.19.238.43] (helo=quaco.ghostprotocols.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nY6xU-004l8x-1o; Sat, 26 Mar 2022 14:00:00 +0000 Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 4206640407; Sat, 26 Mar 2022 10:59:57 -0300 (-03) Date: Sat, 26 Mar 2022 10:59:57 -0300 From: Arnaldo Carvalho de Melo To: Leo Yan Cc: Ali Saidi , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org, german.gomez@arm.com, benh@kernel.crashing.org, Nick.Forrington@arm.com, alexander.shishkin@linux.intel.com, andrew.kilroy@arm.com, james.clark@arm.com, john.garry@huawei.com, jolsa@kernel.org, kjain@linux.ibm.com, lihuafei1@huawei.com, mark.rutland@arm.com, mathieu.poirier@linaro.org, mingo@redhat.com, namhyung@kernel.org, peterz@infradead.org, will@kernel.org Subject: Re: [PATCH v4 1/4] tools: arm64: Import cputype.h Message-ID: References: <20220324183323.31414-1-alisaidi@amazon.com> <20220324183323.31414-2-alisaidi@amazon.com> <20220326054956.GB20556@leoy-ThinkPad-X240s> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220326054956.GB20556@leoy-ThinkPad-X240s> X-Url: http://acmel.wordpress.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Em Sat, Mar 26, 2022 at 01:49:56PM +0800, Leo Yan escreveu: > Hi Arnaldo, Ali, > > On Fri, Mar 25, 2022 at 04:42:32PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Fri, Mar 25, 2022 at 03:39:44PM -0300, Arnaldo Carvalho de Melo escreveu: > > > Em Thu, Mar 24, 2022 at 06:33:20PM +0000, Ali Saidi escreveu: > > > > Bring-in the kernel's arch/arm64/include/asm/cputype.h into tools/ > > > > for arm64 to make use of all the core-type definitions in perf. > > > > > > Replace sysreg.h with the version already imported into tools/. > > > > > You forgot to add it to tools/perf/check-headers.sh so that we get > > > notificed when the original file in the kernel sources gets updated, so > > > that we can check if this needs any tooling adjustments. > > > > > I'll add the entry together with the waiver for this specific > > > difference. > > > > This: > > > > diff --git a/tools/perf/check-headers.sh b/tools/perf/check-headers.sh > > index 30ecf3a0f68b6830..6ee44b18c6b57cf1 100755 > > --- a/tools/perf/check-headers.sh > > +++ b/tools/perf/check-headers.sh > > @@ -146,6 +146,7 @@ done > > check arch/x86/lib/memcpy_64.S '-I "^EXPORT_SYMBOL" -I "^#include " -I"^SYM_FUNC_START\(_LOCAL\)*(memcpy_\(erms\|orig\))"' > > check arch/x86/lib/memset_64.S '-I "^EXPORT_SYMBOL" -I "^#include " -I"^SYM_FUNC_START\(_LOCAL\)*(memset_\(erms\|orig\))"' > > check arch/x86/include/asm/amd-ibs.h '-I "^#include [<\"]\(asm/\)*msr-index.h"' > > +check arch/arm64/include/asm/cputype.h '-I "^#include [<\"]\(asm/\)*sysreg.h"' > > check include/uapi/asm-generic/mman.h '-I "^#include <\(uapi/\)*asm-generic/mman-common\(-tools\)*.h>"' > > check include/uapi/linux/mman.h '-I "^#include <\(uapi/\)*asm/mman.h>"' > > check include/linux/build_bug.h '-I "^#\(ifndef\|endif\)\( \/\/\)* static_assert$"' > > LGTM. I did the testing on both my x86 and Arm64 platforms, thanks for > the fixing up. Thanks, adding a: Tested-by: Leo Yan - Arnaldo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel