From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1CA2EC433EF for ; Tue, 15 Mar 2022 14:23:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Va4vqDYLnfE3qgoN66oYcwd3yZqYSxpGEONKeblPMwE=; b=cBYRfFJfayURTy vPqpRLSW7vIb2V/NKqvoGKIOioqxVbV9BPIMbX3QtNZLeIY5iJ9gzcXHtVZBqkkmG0a8a4ojSacN9 DqZJbU6EpOqSQvH6UD3r6TO6Otuo+LnFRKq96Tsb4K0CiWF7Rji4/tz/3uo0SLKQCUIRR7fQ5SK4g E26JBJrHJ0GoaYgvQFE3xOiatuy4UqTLy8ZWgRbYUnmn7J9vT1aFp7paMNd2ryLl5QGc9oaZ5VoOo lSXA2oJA8x7gFl4GE0bHvTesAPaN8yPZZAyVnnUfcSD2iz1h3MR/NBPVPJ2GBpPbM6zFI/O4J7fOu Ws7YSCQIrdjWsuWeyitQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nU83f-009PPP-AT; Tue, 15 Mar 2022 14:21:55 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nU83P-009PKE-6N; Tue, 15 Mar 2022 14:21:41 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0C82C60B60; Tue, 15 Mar 2022 14:21:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5884EC340ED; Tue, 15 Mar 2022 14:21:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1647354097; bh=npWjB+bqC/Nu3wEdgF/Jo34oYz1o2X5lA+B8iC7SLiw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LKuSpamlCYrChmMa54G2EM5uPOi16qMzHDLb1+odUyAq6U9rkNFEDwhOM+pmhxhqM 1o5r2evCGn8RijzBOvK2TE2LWMiztrfJp4WXpyQgkge0URFpCM52zjSnHtgQThykQk 0OHEa0WP8Bytj8/snToyT/wT/ZfoTHi16W7cAX1w= Date: Tue, 15 Mar 2022 15:21:30 +0100 From: Greg KH To: xkernel.wang@foxmail.com Cc: nsaenz@kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: mmal-vchiq: add a check for the return of vmalloc() Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220315_072139_329888_18DD7EAE X-CRM114-Status: GOOD ( 19.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 04, 2022 at 04:17:41PM +0800, xkernel.wang@foxmail.com wrote: > From: Xiaoke Wang > > vmalloc() is a memory allocation API which can return NULL when some > internal memory errors happen. So it is better to check the return > value of it to catch the error in time. > > Signed-off-by: Xiaoke Wang > --- > drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c > index 76d3f03..1bbd301 100644 > --- a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c > +++ b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c > @@ -1909,6 +1909,11 @@ int vchiq_mmal_init(struct vchiq_mmal_instance **out_instance) > mutex_init(&instance->vchiq_mutex); > > instance->bulk_scratch = vmalloc(PAGE_SIZE); > + if (!instance->bulk_scratch) { > + err = -ENOMEM; > + kfree(instance); This is called in the error section, please just jump to the proper location and then this line will not be needed. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel