From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 27248C433F5 for ; Tue, 15 Mar 2022 23:17:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4F+ivdiF2DoVDdBjLkVIdoi/ayWQlR85QAKjYLUjrO0=; b=rO5N+2Lc3UZmP2 QpiKJT5QlrwusUq00iIp6ktXo+UnplpnsgcE9BReWdD59mdMygS8uLH5GL+idvGfukU/Ht/30oq0T 6OwjWvQcdW+OKLR794asFAO8XDOkJG6cz7c83koNf6Jev0EjLdotH//FBjUlEasduVGZoVE1vYkUc vQQgo26SWLsbp0hiHRCEbY+/6kBocIeDgnJXYCWMXiLAumZ6ZGkwpmtoZYC6RcIyyLTODdrXW9kh/ 0P7OC+ATX4WkrpUq58Ddek6oTX0LLDJGU+PU0k36t391U1btD63AWNr47IWcwfxArt2tXGOoBBGVH Za4CbXKmUE4xDJ/XLZkA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nUGOk-00AsuK-7z; Tue, 15 Mar 2022 23:16:14 +0000 Received: from mail-io1-xd32.google.com ([2607:f8b0:4864:20::d32]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nUGOg-00Astq-6r for linux-arm-kernel@lists.infradead.org; Tue, 15 Mar 2022 23:16:11 +0000 Received: by mail-io1-xd32.google.com with SMTP id q11so561362iod.6 for ; Tue, 15 Mar 2022 16:16:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=OWQCIDU5jEufwl7Eenakcb0vQxFa1/UoqORJLjuuNhE=; b=QPne9aKrq0jSJxwKAvN2RfdcxxPofCtmfVt75fA8YVrNJPDiYxQXuHO4+3AfxM2Vwe Aucldu1FnNvysmOxcFjg7PvgDeuRU3+UgHKeLlu8bX2elW3Jo/2EnIdEtAZyKA7/rULi Lwqe9KvnjIqsZq28oCcivnx/lr9CAGyJS+bwxPlWEdTH1o3iA0HbdkiEUlxvg97t+qQj mXL6h7WNhIkr2vR8PybLX/e2W74SwkklhEipaLRGwNZ2jP4UOnH04rYpv68jqAKRG90W 4/pxYM7C55nfMmVmWZRxsmA2Ib5aRJmjHdkWtPuX20QeFWJlutQkHrBBH2rzQTWsR8Nr vCEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=OWQCIDU5jEufwl7Eenakcb0vQxFa1/UoqORJLjuuNhE=; b=7Cvsm3vl8UrADuEKM2BgdjFzVnU7vF0zFRuxwH4B2M18T8l3+y/X8SlgggHszV4Mw9 J6VZK2XlaNuUuNcQrxxpvlg2OHr1yB6SL3nF1VpYcn3Qc9Y2vmSlouZLNQgQhhTXE9oa 7b7UuqDEIG6SBaFQ5YrmfaV3m/4v3Ios+SClfCUwvjrB8xzA2qrZlJPFgG8QmNPlw0FE Q5Sves1kYo/x/GgMu2Rbb/jGKpzWWFVN2CkWt+4I5PwGGA2Mu5xW8fIIcEiw7fTyHHBi LloKybob6YCZXIfVfIuumnHw7SWFQnIbb4+F1b4yDkekMGj9QTZ55mHffeasjsbgoA8A aj8A== X-Gm-Message-State: AOAM532vY0otn5LFECik4QkkmiwMotMG6vUUDtEhoVDTKFvlrBCqJ6c/ g8Y94QPO5PFDOcQbDltwH6knTg== X-Google-Smtp-Source: ABdhPJz9YtpbRtn+pOoVIMY+c8V/BrQ1H9IrGkr7iACumNBQrKchs6uMxcvVd/awNz9d3c+1qeU+fQ== X-Received: by 2002:a05:6638:388e:b0:317:7979:f5bf with SMTP id b14-20020a056638388e00b003177979f5bfmr23978652jav.53.1647386169148; Tue, 15 Mar 2022 16:16:09 -0700 (PDT) Received: from google.com (194.225.68.34.bc.googleusercontent.com. [34.68.225.194]) by smtp.gmail.com with ESMTPSA id s185-20020a6b2cc2000000b00648d69f367asm157422ios.16.2022.03.15.16.16.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Mar 2022 16:16:08 -0700 (PDT) Date: Tue, 15 Mar 2022 23:16:05 +0000 From: Oliver Upton To: Marc Zyngier Cc: linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, kernel-team@android.com, Andre Przywara Subject: Re: [PATCH 1/4] irqchip/gic-v3: Exposes bit values for GICR_CTLR.{IR, CES} Message-ID: References: <20220314164044.772709-1-maz@kernel.org> <20220314164044.772709-2-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220314164044.772709-2-maz@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220315_161610_273087_17D3EC79 X-CRM114-Status: GOOD ( 17.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Marc, On Mon, Mar 14, 2022 at 04:40:41PM +0000, Marc Zyngier wrote: > As we're about to expose GICR_CTLR.{IR,CES} to guests, populate > the include file with the architectural values. > > Signed-off-by: Marc Zyngier > --- > include/linux/irqchip/arm-gic-v3.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/linux/irqchip/arm-gic-v3.h b/include/linux/irqchip/arm-gic-v3.h > index 12d91f0dedf9..aeb8ced53880 100644 > --- a/include/linux/irqchip/arm-gic-v3.h > +++ b/include/linux/irqchip/arm-gic-v3.h > @@ -127,6 +127,8 @@ > #define GICR_PIDR2 GICD_PIDR2 > > #define GICR_CTLR_ENABLE_LPIS (1UL << 0) > +#define GICR_CTLR_IR (1UL << 1) > +#define GICR_CTLR_CES (1UL << 2) I think these are backwards (IR is bit 2) https://developer.arm.com/documentation/ddi0595/2021-12/External-Registers/GICR-CTLR--Redistributor-Control-Register?lang=en -- Thanks, Oliver > #define GICR_CTLR_RWP (1UL << 3) > > #define GICR_TYPER_CPU_NUMBER(r) (((r) >> 8) & 0xffff) > -- > 2.34.1 > > _______________________________________________ > kvmarm mailing list > kvmarm@lists.cs.columbia.edu > https://lists.cs.columbia.edu/mailman/listinfo/kvmarm _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel