From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B856DC433EF for ; Wed, 16 Mar 2022 13:05:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=y7pAMlPQ1o16GH9pLt7G4SpnoFWAtIXdIAopqDENo9I=; b=dbHxX65hJQxDUb sr7ql9Fj/0fcX6pIVAft2wG8/MfPov8g/N/Vq6sT8qvjh0H0mMZYp/kvhn+JxRlHtO8VVfRyCCZpl Rff+quzoYCGO7vq0b4Y2WQbReOElxrUbv3i1SK6QORThSht99bfRuSGv04IwZX4iR59jNcO6HOcaX zcmob3mzHvgiHx5F0YvlDxojaqDRnG1N/yZn2yYdf3e5ZnZ2q+WYfJ1G7GgqK0SMXGDLBlYJiZzq6 J7arhy8UwxHu3Iast8PdkqRdiqShLBm1okU6LEcQVUiCf9HhfXwjg4bt4V606sMz1rZ5Qoct/Ugzi 5rAYoHhyvUix+xpl8/Qg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nUTJw-00CsMF-Vn; Wed, 16 Mar 2022 13:04:09 +0000 Received: from mail-ej1-x635.google.com ([2a00:1450:4864:20::635]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nUTJt-00CsLg-Bp for linux-arm-kernel@lists.infradead.org; Wed, 16 Mar 2022 13:04:06 +0000 Received: by mail-ej1-x635.google.com with SMTP id gb39so4065277ejc.1 for ; Wed, 16 Mar 2022 06:04:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Igm3Qwel8tMuPS4Qie+hgP2R/3m5lU6oQFNMlTshPzI=; b=VmRIEoL1u2CzsIffZmsYWdYamQVtw0VGobVhlXXEqMreCeTGMwuzUVUbc4Iwxci5Bw Rj4+a02sAl1satBR2lEg/a4cZiuE/vmO5q51oCB4l/K1vxfOpJFsOmr4AXQ9hMzYfx4K 24lmNUqbLDkTHN//8mGfv/oKaFtoCdlRV73vHhz5W92i4oTw4BNKr2Nw1LtbTckitbZG bgbdSMQz3kp2F11AMldV8DJQvXVRtlLZ4O0izVl7Ip2Ec2X9SzfENkxKeThqSeJUausq sBfS0PwxyxfgQggfxUmsUv7dVvrk2o8BVn/QTO/E4DyUAbWZCNbDd3OmeKzfWB5U4RQn 1JeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=Igm3Qwel8tMuPS4Qie+hgP2R/3m5lU6oQFNMlTshPzI=; b=sYs58kKBwePbCuPKP1385UpynDeUwl4hmAxU7eBh5dNnalbqf567r3dTZ1g0NLTV0z wm5++e5s2YscNfJJK9YzrQcv/Oz5fC3jDXXrTVhv8wLC/qfRXMqbRfg6Vp0ET01QqsTx v+EDdIpQIK97nSWhTkT0MVOL7S9cxxrZt17FvoICcLp8X7nFC65WvSfYJjMgcnvDnpNR 5r9NAQ5wTBhwhN6nobGXZqASGhqDL+d0jG8+PEhT/wX0Ne6N1FNgxQSRRGBqd0QkzLeN JwgCA6w87HBq3y8Ig7ISke+4eUIeV0q974Le3+myZ2sFxqfO+lFfJOyKTBJsWGksyFp9 lNQw== X-Gm-Message-State: AOAM531AVN37yQfI1U1bESenfeiIi18pnlX4IG5XMaoRQNqcxtevK3Fe r9X1MRsDpx6xshu0hAOBQrE= X-Google-Smtp-Source: ABdhPJwTWJmyN0TMKtYD2knKD+kHqLckditYp6p1eCfiV4na7UInc6lE3Z5PRFArRd83dPSMU3NSbQ== X-Received: by 2002:a17:907:3f22:b0:6d7:8257:b27d with SMTP id hq34-20020a1709073f2200b006d78257b27dmr25799015ejc.190.1647435843288; Wed, 16 Mar 2022 06:04:03 -0700 (PDT) Received: from m4.home ([2a0b:f4c2:3::89]) by smtp.gmail.com with ESMTPSA id w10-20020aa7da4a000000b004161eea5ae7sm932674eds.40.2022.03.16.06.04.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Mar 2022 06:04:02 -0700 (PDT) Received: from cavok by m4.home with local (Exim 4.94.2) (envelope-from ) id 1nUTJo-000H3S-Ed; Wed, 16 Mar 2022 14:04:00 +0100 Date: Wed, 16 Mar 2022 14:04:00 +0100 From: Domenico Andreoli To: Marc Zyngier Cc: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Thomas Gleixner , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] PCI/MSI: mvebu: Re-enable arch fallbacks Message-ID: References: <51ec54c21ba7649046362169987c2ff0@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <51ec54c21ba7649046362169987c2ff0@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220316_060405_433120_3367BFBC X-CRM114-Status: GOOD ( 22.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 16, 2022 at 11:37:14AM +0000, Marc Zyngier wrote: > On 2022-03-16 09:33, Domenico Andreoli wrote: > > From: Domenico Andreoli > > > > Since v5.10, my QNAP happily barks at boot as follows (5.17.0-rc8): > > > > [ 0.923811] ------------[ cut here ]------------ > > [ 0.928458] WARNING: CPU: 0 PID: 1 at drivers/pci/msi/msi.h:17 > > pci_msi_setup_msi_irqs+0x54/0x6c > > [ 0.937219] Modules linked in: > > [ 0.940290] CPU: 0 PID: 1 Comm: swapper Not tainted > > 5.17.0-rc8-marvell #6 > > [ 0.947117] Hardware name: Marvell Kirkwood (Flattened Device Tree) > > [ 0.953428] unwind_backtrace from show_stack+0x10/0x14 > > [ 0.958698] show_stack from __warn+0xac/0xe4 > > [ 0.963093] __warn from warn_slowpath_fmt+0x68/0x80 > > [ 0.968098] warn_slowpath_fmt from pci_msi_setup_msi_irqs+0x54/0x6c > > [ 0.974499] pci_msi_setup_msi_irqs from > > __pci_enable_msi_range+0x260/0x340 > > [ 0.981509] __pci_enable_msi_range from > > pci_alloc_irq_vectors_affinity+0xb8/0xf8 > > [ 0.989043] pci_alloc_irq_vectors_affinity from xhci_run+0x164/0x474 > > [ 0.995532] xhci_run from usb_add_hcd+0x444/0x6e0 > > [ 1.000362] usb_add_hcd from usb_hcd_pci_probe+0x30c/0x37c > > [ 1.005979] usb_hcd_pci_probe from xhci_pci_probe+0x10/0xec > > [ 1.011689] xhci_pci_probe from pci_device_probe+0x74/0xe8 > > [ 1.017305] pci_device_probe from really_probe+0x1c0/0x3f8 > > [ 1.022921] really_probe from driver_probe_device+0x30/0xb0 > > [ 1.028623] driver_probe_device from __driver_attach+0x11c/0x148 > > [ 1.034762] __driver_attach from bus_for_each_dev+0x54/0x78 > > [ 1.040466] bus_for_each_dev from bus_add_driver+0x170/0x1d8 > > [ 1.046256] bus_add_driver from driver_register+0xac/0xf0 > > [ 1.051783] driver_register from do_one_initcall+0x74/0x1b8 > > [ 1.057495] do_one_initcall from kernel_init_freeable+0x1a8/0x1ec > > [ 1.063723] kernel_init_freeable from kernel_init+0x10/0x108 > > [ 1.069514] kernel_init from ret_from_fork+0x14/0x3c > > [ 1.074604] Exception stack(0xc1835fb0 to 0xc1835ff8) > > [ 1.079691] 5fa0: 00000000 > > 00000000 00000000 00000000 > > [ 1.087915] 5fc0: 00000000 00000000 00000000 00000000 00000000 > > 00000000 00000000 00000000 > > [ 1.096136] 5fe0: 00000000 00000000 00000000 00000000 00000013 > > 00000000 > > [ 1.102787] ---[ end trace 0000000000000000 ]--- > > [ 1.107435] ------------[ cut here ]------------ > > > > > > I bisected it down to commit 077ee78e392869e46ae (PCI/MSI: Make > > arch_.*_msi_irq[s] fallbacks selectable). > > > > Re-enabling PCI/MSI arch fallbacks restores a clean bootlog. > > > > Cc: Thomas Gleixner > > Cc: linux-arm-kernel@lists.infradead.org > > Signed-off-by: Domenico Andreoli > > > > --- > > arch/arm/mach-mvebu/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > Index: b/arch/arm/mach-mvebu/Kconfig > > =================================================================== > > --- a/arch/arm/mach-mvebu/Kconfig > > +++ b/arch/arm/mach-mvebu/Kconfig > > @@ -123,6 +123,7 @@ config MACH_KIRKWOOD > > select ORION_IRQCHIP > > select ORION_TIMER > > select FORCE_PCI > > + select PCI_MSI_ARCH_FALLBACKS if PCI_MSI > > select PCI_QUIRKS > > select PINCTRL_KIRKWOOD > > help > > This really is papering over the real issue, which probably is > that the platform *doesn't* support MSIs, and yet the PCI > controller driver doesn't advertises that. I'll investigate this. > > See 645e9c38383d ("PCI: mediatek: Advertise lack of built-in MSI > handling") for an example of how to fix your PCI controller driver. Thanks for the pointer! Dom > > Thanks, > > M. > -- > Jazz is not dead. It just smells funny... -- rsa4096: 3B10 0CA1 8674 ACBA B4FE FCD2 CE5B CF17 9960 DE13 ed25519: FFB4 0CC3 7F2E 091D F7DA 356E CC79 2832 ED38 CB05 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel