From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 58F9AC433F5 for ; Thu, 17 Mar 2022 16:24:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DS29rl1LxArhR4FtIt1943P1W5NDdhb4awXTjnJiwws=; b=SVHsP8jRy0iUaiM9R8nTpgUf6q AMPdYat2Mac2+dUSw0ABNnDjng8ML2Lw+A9S3eaYyvSJ6MFUM7r3v/7EL0bf6pJOv/7PNb70C9Nv+ KoF3y8plVp4bOOCqKm7/CE6Nu6na92ggtzX2zFxOjltDgPQNojo/6X2mzjWJ+H5je+BhsrrvUMlvk fQb6DTd0elVGBqirX7PfOY8QaFqTyvKh6wGE7iigmoz5o0wanPEJKsyw2c5HAP0sOMwP0UNFan5D9 3e8rf/CGzdhrQLP41H3aSBugf+lDgi8oHlWMz/Brqx/5rDnDzGtVTR1AY1ycT8NsWIWhRPfCnBzLe NUnIPMLg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nUssM-00GjtA-V9; Thu, 17 Mar 2022 16:21:23 +0000 Received: from relay4-d.mail.gandi.net ([2001:4b98:dc4:8::224]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nUssH-00Gjro-UL; Thu, 17 Mar 2022 16:21:20 +0000 Received: (Authenticated sender: paul.kocialkowski@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 01AC0E000E; Thu, 17 Mar 2022 16:21:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1647534070; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=p+cYBkfFFvELqWc9QhQrIx+yztmy6I4JHGArTu/5pHI=; b=DTjpkPO+Rd8PPKRBmDgIFf8CocPlPj+9wu7TQwKkH/W0cTGtcxwD+qkLdZ4vVrrK5894tJ qjWmm6zNPvtp7WuOoZYPoAABdrfPmfdjfZP5alH9VGaORL5zNcW1tO/qyUMSX6N9AfWvHb 9FtpA38vZpWNVGuIAL8VAY/jdqsLRy9GRiOiezU+eavHdCHz2CqFaHFQfKAU0Qa3D5f8Xl ef2mEmAUL09Sfh6bPrDXj7UogiwjaJWP1CmTH1wXKu32D4wRi1/kLzHE7rWzx9Dm32lTYK W0DPmtj0k73bDzoXYiEafY2Qh/JG7P24sh+DGhwDqUxrQlAK6mlG4BGScugF8A== Date: Thu, 17 Mar 2022 17:21:07 +0100 From: Paul Kocialkowski To: Sakari Ailus Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, Yong Deng , Mauro Carvalho Chehab , Rob Herring , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Hans Verkuil , Laurent Pinchart , Kishon Vijay Abraham I , Vinod Koul , Maxime Ripard , Thomas Petazzoni , Rob Herring Subject: Re: [PATCH v3 7/9] dt-bindings: media: Add Allwinner A83T MIPI CSI-2 bindings documentation Message-ID: References: <20220302220739.144303-1-paul.kocialkowski@bootlin.com> <20220302220739.144303-8-paul.kocialkowski@bootlin.com> MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220317_092118_637007_BA9303AE X-CRM114-Status: GOOD ( 25.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============0624663140452163499==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============0624663140452163499== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="iiX+RlDO9qayM+ej" Content-Disposition: inline --iiX+RlDO9qayM+ej Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Sakari, On Wed 16 Mar 22, 15:26, Sakari Ailus wrote: > Hi Paul, >=20 > Thanks for the patch. And thanks for the review! > On Wed, Mar 02, 2022 at 11:07:37PM +0100, Paul Kocialkowski wrote: > > This introduces YAML bindings documentation for the Allwinner A83T > > MIPI CSI-2 controller. > >=20 > > Signed-off-by: Paul Kocialkowski > > Reviewed-by: Rob Herring > > --- > > .../media/allwinner,sun8i-a83t-mipi-csi2.yaml | 138 ++++++++++++++++++ > > 1 file changed, 138 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/media/allwinner,s= un8i-a83t-mipi-csi2.yaml > >=20 > > diff --git a/Documentation/devicetree/bindings/media/allwinner,sun8i-a8= 3t-mipi-csi2.yaml b/Documentation/devicetree/bindings/media/allwinner,sun8i= -a83t-mipi-csi2.yaml > > new file mode 100644 > > index 000000000000..75121b402435 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/media/allwinner,sun8i-a83t-mipi= -csi2.yaml > > @@ -0,0 +1,138 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/media/allwinner,sun8i-a83t-mipi-csi= 2.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Allwinner A83T MIPI CSI-2 Device Tree Bindings > > + > > +maintainers: > > + - Paul Kocialkowski > > + > > +properties: > > + compatible: > > + const: allwinner,sun8i-a83t-mipi-csi2 > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > + > > + clocks: > > + items: > > + - description: Bus Clock > > + - description: Module Clock > > + - description: MIPI-specific Clock > > + - description: Misc CSI Clock > > + > > + clock-names: > > + items: > > + - const: bus > > + - const: mod > > + - const: mipi > > + - const: misc > > + > > + resets: > > + maxItems: 1 > > + > > + ports: > > + $ref: /schemas/graph.yaml#/properties/ports > > + > > + properties: > > + port@0: > > + $ref: /schemas/graph.yaml#/$defs/port-base > > + description: Input port, connect to a MIPI CSI-2 sensor > > + > > + properties: > > + reg: > > + const: 0 > > + > > + endpoint: > > + $ref: video-interfaces.yaml# > > + unevaluatedProperties: false > > + > > + properties: > > + clock-lanes: > > + maxItems: 1 >=20 > Does the hardware support lane reordering? If not, the property should be > omitted here. I'm not sure what this relates to. Is it about inverting the clock lane with a data lane? I'm a bit confused about logical vs physical lane in the conte= xt of MIPI CSI-2. The controller has dedicated pins for the clock and data lanes and supports filtering packets based on virtual channel or data type. Are the clock-lanes and data-lanes only relevant for reordering? IIRC they are also necessary to get the lanes count in the driver. > I can also remove the three lines here while applying the patches. I think this series will need another iteration anyway, so let's wait. Paul > > + > > + data-lanes: > > + minItems: 1 > > + maxItems: 4 > > + > > + required: > > + - data-lanes > > + > > + additionalProperties: false > > + > > + port@1: > > + $ref: /schemas/graph.yaml#/$defs/port-base > > + description: Output port, connect to a CSI controller > > + > > + properties: > > + reg: > > + const: 1 > > + > > + endpoint: > > + $ref: video-interfaces.yaml# > > + unevaluatedProperties: false > > + > > + additionalProperties: false > > + > > + required: > > + - port@0 > > + - port@1 > > + > > +required: > > + - compatible > > + - reg > > + - interrupts > > + - clocks > > + - clock-names > > + - resets > > + - ports > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + #include > > + #include > > + #include > > + > > + mipi_csi2: csi@1cb1000 { > > + compatible =3D "allwinner,sun8i-a83t-mipi-csi2"; > > + reg =3D <0x01cb1000 0x1000>; > > + interrupts =3D ; > > + clocks =3D <&ccu CLK_BUS_CSI>, > > + <&ccu CLK_CSI_SCLK>, > > + <&ccu CLK_MIPI_CSI>, > > + <&ccu CLK_CSI_MISC>; > > + clock-names =3D "bus", "mod", "mipi", "misc"; > > + resets =3D <&ccu RST_BUS_CSI>; > > + > > + ports { > > + #address-cells =3D <1>; > > + #size-cells =3D <0>; > > + > > + mipi_csi2_in: port@0 { > > + reg =3D <0>; > > + > > + mipi_csi2_in_ov8865: endpoint { > > + data-lanes =3D <1 2 3 4>; > > + > > + remote-endpoint =3D <&ov8865_out_mipi_csi2>; > > + }; > > + }; > > + > > + mipi_csi2_out: port@1 { > > + reg =3D <1>; > > + > > + mipi_csi2_out_csi: endpoint { > > + remote-endpoint =3D <&csi_in_mipi_csi2>; > > + }; > > + }; > > + }; > > + }; > > + > > +... >=20 > --=20 > Kind regards, >=20 > Sakari Ailus --=20 Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com --iiX+RlDO9qayM+ej Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEJZpWjZeIetVBefti3cLmz3+fv9EFAmIzX/MACgkQ3cLmz3+f v9E+pQf+IeGzh1lXPZrMZDTECUlOPK5l/zgJtpRtE5Gd7qzKbZm59v2L4YYnaBzC uT+MIgMHxJtyX90UobiXOilMW/yxilQFh/i00T4HMXEZ+VFxY6wVVUZt0/yZM33n U3EqJqMWT/cb14jgNFBi9jEX7Y08cRih1u8JZxnDBDnq/1KZL/csvquJ2Ljwczw0 cMOQ+1L8liSsQiq7AlorcZLuFSLttMlbIZg+E2u9FNSBKcoF1iUpsDhSggXEVvs9 rVxpT+YhxM6hNls7XR3LyeE7KdAfdcub5JFhUiq7oTJxQK+K6/0IWv8qBrq35k3u qcCt2yH9UO9dmAyhBky+qbS06yaJjA== =IJLv -----END PGP SIGNATURE----- --iiX+RlDO9qayM+ej-- --===============0624663140452163499== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============0624663140452163499==--