From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 94A19C433F5 for ; Fri, 18 Mar 2022 03:28:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MBCSfvce4vzpxIsXR8S0LWVW8Ewau7cU98IRGdHPgpA=; b=3R9b7iDwG46UqT Yr0hzEC9IJVqGgnZvKrghVFfHwMKm4XliFRpjQ4ib+QQkrIPUZKku/dzPhfign5WRkKlW3DyU0v1M jpWcZnv3+Lb3w0Ja9cFWLRiOMkg8f2aglZVGO1hbgJmPLkg4F5Mm/PaUJu4IpS5IwNthcRGzj63ff Ho1xtLLa98UpPn3jf4+rfkGbkg85IopsqbO/Y0pSVKWLzVtxJFn2kA+5vlpXSPLwod9xDQkw1GKde E05Cl8duBnT1MBKiPi3KUsjQnRUtjIiZ+gspKG7ReEmdkNzGLJWUZNPEB1ecXTxUN4tkXQRkSGPNm jrMVcUnMeINv7f0HvEJg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nV3Gs-000GVm-Ja; Fri, 18 Mar 2022 03:27:22 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nV3Gp-000GV9-4t for linux-arm-kernel@lists.infradead.org; Fri, 18 Mar 2022 03:27:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647574037; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HmvQLm+Be/rIvjje/jXJTnXxzbeQvzrK0wyifBBzLlg=; b=EJHFULYTLwIxS7ry96juwMWlcXWuXFepU9jtsQnK5oQR2/SeXWL5T2aauI9Fz4M5K7W2aT vAYro/KjvvVodC9bOdp/NoS2dozuKcvLcAKllz+cYxi3btzKgCSwRSDIX1Z2jUOHDVupta y0HtBDcSmsys0Y6JlcsGFZG+NBfU7Rw= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-381-0ETb-ET9Mz61aZfT6VgBvg-1; Thu, 17 Mar 2022 23:27:14 -0400 X-MC-Unique: 0ETb-ET9Mz61aZfT6VgBvg-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C95D6811E76; Fri, 18 Mar 2022 03:27:13 +0000 (UTC) Received: from localhost (ovpn-13-174.pek2.redhat.com [10.72.13.174]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F1672565DA2; Fri, 18 Mar 2022 03:27:12 +0000 (UTC) Date: Fri, 18 Mar 2022 11:27:09 +0800 From: Baoquan He To: Coiby Xu Cc: Coiby Xu , kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Dave Young , Will Deacon , "Eric W . Biederman" , open list Subject: Re: [RESEND PATCH v3 1/3] kexec: clean up arch_kexec_kernel_verify_sig Message-ID: References: <20220304020341.85583-1-coiby.xu@gmail.com> <20220304020341.85583-2-coiby.xu@gmail.com> <20220318024803.pkkwgknwur2y75mt@Rk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220318024803.pkkwgknwur2y75mt@Rk> X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220317_202719_448411_E4679AF7 X-CRM114-Status: GOOD ( 23.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 03/18/22 at 10:48am, Coiby Xu wrote: > On Thu, Mar 17, 2022 at 08:45:35PM +0800, Baoquan He wrote: > > On 03/04/22 at 10:03am, Coiby Xu wrote: > > > From: Coiby Xu > > > > > > commit 9ec4ecef0af7790551109283ca039a7c52de343c ("kexec_file,x86, > > > powerpc: factor out kexec_file_ops functions" allows implementing > > > the arch-specific implementation of kernel image verification > > > in kexec_file_ops->verify_sig. Currently, there is no arch-specific > > > implementation of arch_kexec_kernel_verify_sig. So clean it up. > > > > This is a nice cleanup, while the log may need to be improved. You > > should run ./scripts/checkpatch.pl on your patch before sending out. > > When we refer to a commit in log, please refer to > > Documentation/process/submitting-patches.rst. > > Thanks for the reminder! I've used git pre-commit hook to run > scripts/checkpatch.pl automatically but obviously this hook doesn't > apply to "git rebase --continue" and currently this no git hook that > for this situation. I'll use the following trick [1] to avoid this > mistake in the future, > $ git rebase -i HEAD~3 --reschedule-failed-exec --exec "git show | perl ./scripts/checkpatch.pl" Sorry, Coiby. It could be late yesterday so I was dizzy when writing down the comment, I didn't make my concern clear. What I meant is the referenced commit in log should be taken in a standard format. Abstracted one paragraph of Documentation/process/submitting-patches.rst here. We usually take the first 12 characters of the commit SHA-1 ID in log, but not the whole of them. ===== If you want to refer to a specific commit, don't just refer to the SHA-1 ID of the commit. Please also include the oneline summary of the commit, to make it easier for reviewers to know what it is about. Example:: Commit e21d2170f36602ae2708 ("video: remove unnecessary platform_set_drvdata()") removed the unnecessary platform_set_drvdata(), but left the variable "dev" unused, delete it. ===== And the right parenthesis enclousing the commit subject is missing. > > [1] https://stackoverflow.com/a/70568833/1203522 > > > -- > Best regards, > Coiby > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel