From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ADACDC433F5 for ; Mon, 21 Mar 2022 16:09:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QNcDWFGb2TfZ+CF4EiOxlnYM1Ng6vDONEWfkzCMUOnE=; b=oZsdcAzFS6+uAQ lyDGvuKC/eFk/IQpZwx1AGVLtRDV2BQTforaF+3F3GKQmYtQyyna1PW7Psuo8be1P+aX/HOiQyppR ejBa0t1zeOf6SdmU3v3nUklmDXVVRMMOs20sFzke8d8xDUTAnOLyOr25PSK8X+3uPfcF2z651KFaX pZ16kTBh1WT0mhPP8szCNKvKcGuzHZJQ2Ws+kuYu42n95AcC9PEm5RBg36GSD1AmN8QPkptdYirPg qXrBiNfvZMlAm+nwI55hURFKo/r3bs04xP1Yda1fx41MmLn6MzZbtoScmMKUF3S7yyFz+B0/lFwCN 1JmqA1nc3uh+/i9CtObg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nWKa4-008L07-V8; Mon, 21 Mar 2022 16:08:29 +0000 Received: from mail-oi1-f175.google.com ([209.85.167.175]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nWKa1-008KyM-6C for linux-arm-kernel@lists.infradead.org; Mon, 21 Mar 2022 16:08:26 +0000 Received: by mail-oi1-f175.google.com with SMTP id w127so16661390oig.10 for ; Mon, 21 Mar 2022 09:08:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=tCOTznouFD+iWjgYbDVoQOww7ryqponRKYWNROGxryg=; b=5zKblcp+1v+txAU26XpUate0vVbEAw6Sx7oMh2UZcl9QExfR7uQTbR5e5demBZQh8x osAv/sNvEUU8QtjGRWagXk2EBgSOeO3Z+9ra9x5Qh7JlTB6WmSXbv4MGcOEOrVvOVh2Z oipqykx15xVTifXFAm15Joz0D9UlEmQ2ti5YHk/at8Ru/mMDmlnPIDhWh+8FYGi6ibIN 2qheGxd00oAxn3jNfHIWqcRSAhgiCqwvQnHo9jbzxx5VrGykVhGzmKGklrw15wtqPDt6 Fu7j2orYEdap4cdi3brcty1zX7eSHPC4ri4WtsDquuC4wFVa0y8r7+tCNcMoLVk/s0YD 8tRg== X-Gm-Message-State: AOAM530sI+WuW9drR8ak4lnaPIK+Oj58kw3gFA1AmwZ0Ft0kqwPmM3s7 zMPYNtlD3CHGBkYJfWScQA== X-Google-Smtp-Source: ABdhPJzCmplBnS1Fq/DfzqLFnp+aV9kDSRQR0Nhlx5kiGHG7agyTuRCc95XbpeqzGNkB/w+tdoAibA== X-Received: by 2002:aca:3643:0:b0:2ec:cb84:c5ba with SMTP id d64-20020aca3643000000b002eccb84c5bamr14905569oia.183.1647878904067; Mon, 21 Mar 2022 09:08:24 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id bc36-20020a05682016a400b003240a532a1csm6859115oob.29.2022.03.21.09.08.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Mar 2022 09:08:22 -0700 (PDT) Received: (nullmailer pid 139178 invoked by uid 1000); Mon, 21 Mar 2022 16:08:20 -0000 Date: Mon, 21 Mar 2022 11:08:20 -0500 From: Rob Herring To: dann frazier Cc: Marc Zyngier , "linux-kernel@vger.kernel.org" , linux-arm-kernel , PCI , Toan Le , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , =?iso-8859-1?Q?St=E9phane?= Graber , Android Kernel Team Subject: Re: [PATCH v2 0/2] PCI: xgene: Restore working PCIe functionnality Message-ID: References: <20220321104843.949645-1-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220321_090825_254388_CC0408BC X-CRM114-Status: GOOD ( 30.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Mar 21, 2022 at 09:50:24AM -0600, dann frazier wrote: > On Mon, Mar 21, 2022 at 10:17:34AM -0500, Rob Herring wrote: > > On Mon, Mar 21, 2022 at 5:49 AM Marc Zyngier wrote: > > > > > > Since 6dce5aa59e0b ("PCI: xgene: Use inbound resources for setup") was > > > merged in the 5.5 time frame, PCIe on the venerable XGene platform has > > > been unusable: 6dce5aa59e0b broke both XGene-1 (Mustang and m400) and > > > XGene-2 (Merlin), while the addition of c7a75d07827a ("PCI: xgene: Fix > > > IB window setup") fixed XGene-2, but left the rest of the zoo > > > unusable. > > > > > > It is understood that this systems come with "creative" DTs that don't > > > match the expectations of modern kernels. However, there is little to > > > be gained by forcing these changes on users -- the firmware is not > > > upgradable, and the current owner of the IP will deny that these > > > machines have ever existed. > > > > The gain for fixing this properly is not having drivers do their own > > dma-ranges parsing. We've seen what happens when drivers do their own > > parsing of standard properties (e.g. interrupt-map). Currently, we > > don't have any drivers doing their own parsing: > > > > $ git grep of_pci_dma_range_parser_init > > drivers/of/address.c:int of_pci_dma_range_parser_init(struct > > of_pci_range_parser *parser, > > drivers/of/address.c:EXPORT_SYMBOL_GPL(of_pci_dma_range_parser_init); > > drivers/of/address.c:#define of_dma_range_parser_init > > of_pci_dma_range_parser_init > > drivers/of/unittest.c: if (of_pci_dma_range_parser_init(&parser, np)) { > > drivers/pci/of.c: err = of_pci_dma_range_parser_init(&parser, dev_node); > > include/linux/of_address.h:extern int > > of_pci_dma_range_parser_init(struct of_pci_range_parser *parser, > > include/linux/of_address.h:static inline int > > of_pci_dma_range_parser_init(struct of_pci_range_parser *parser, > > > > And we can probably further refactor this to be private to drivers/pci/of.c. > > > > For XGene-2 the issue is simply that the driver depends on the order > > of dma-ranges entries. > > > > For XGene-1, I'd still like to understand what the issue is. Reverting > > the first fix and fixing 'dma-ranges' should have fixed it. I need a > > dump of how the IB registers are initialized in both cases. > > Happy to provide that for the m400 if told how :) Something like the below patch. This should be with the 'dma-ranges' DT change and only c7a75d07827a reverted. 8<------------------------------------------------------------------- diff --git a/drivers/pci/controller/pci-xgene.c b/drivers/pci/controller/pci-xgene.c index 0d5acbfc7143..6a435c31f45e 100644 --- a/drivers/pci/controller/pci-xgene.c +++ b/drivers/pci/controller/pci-xgene.c @@ -78,6 +78,7 @@ static u32 xgene_pcie_readl(struct xgene_pcie *port, u32 reg) static void xgene_pcie_writel(struct xgene_pcie *port, u32 reg, u32 val) { + dev_info(port->dev, "0x%04x <- 0x%08x\n", reg, val); writel(val, port->csr_base + reg); } @@ -508,7 +509,9 @@ static void xgene_pcie_setup_ib_reg(struct xgene_pcie *port, case 0: xgene_pcie_set_ib_mask(port, BRIDGE_CFG_4, flags, size); bar_addr = cfg_base + PCI_BASE_ADDRESS_0; + dev_info(port->dev, "BAR0L <- 0x%08x\n", bar_low); writel(bar_low, bar_addr); + dev_info(port->dev, "BAR0H <- 0x%08x\n", upper_32_bits(cpu_addr)); writel(upper_32_bits(cpu_addr), bar_addr + 0x4); pim_reg = PIM1_1L; break; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel