Re: [PATCH 00/22] drm: Review of mode copies

From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Alex Deucher <alexdeucher@gmail.com>
Cc: "Maling list - DRI developers" <dri-devel@lists.freedesktop.org>,
	"Heiko Stübner" <heiko@sntech.de>,
	"Emma Anholt" <emma@anholt.net>,
	"Neil Armstrong" <narmstrong@baylibre.com>,
	"Xinliang Liu" <xinliang.liu@linaro.org>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"Jernej Skrabec" <jernej.skrabec@gmail.com>,
	"Andrzej Hajda" <andrzej.hajda@intel.com>,
	"Sam Ravnborg" <sam@ravnborg.org>,
	"Rodrigo Siqueira" <Rodrigo.Siqueira@amd.com>,
	"amd-gfx list" <amd-gfx@lists.freedesktop.org>,
	linux-rockchip@lists.infradead.org,
	"Xinwei Kong" <kong.kongxinwei@hisilicon.com>,
	"Aurabindo Pillai" <aurabindo.pillai@amd.com>,
	"Chen Feng" <puck.chen@hisilicon.com>,
	"Alain Volmat" <alain.volmat@foss.st.com>,
	"Harry Wentland" <harry.wentland@amd.com>,
	"Chun-Kuang Hu" <chunkuang.hu@kernel.org>,
	"Jonas Karlman" <jonas@kwiboo.se>, "Leo Li" <sunpeng.li@amd.com>,
	linux-arm-msm <linux-arm-msm@vger.kernel.org>,
	"Intel Graphics Development" <intel-gfx@lists.freedesktop.org>,
	"Abhinav Kumar" <quic_abhinavk@quicinc.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Nikola Cornij" <nikola.cornij@amd.com>,
	"John Stultz" <john.stultz@linaro.org>,
	"Sean Paul" <sean@poorly.run>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	"Tomi Valkeinen" <tomba@kernel.org>,
	"Jyri Sarha" <jyri.sarha@iki.fi>,
	"Sandy Huang" <hjc@rock-chips.com>,
	"Robert Foss" <robert.foss@linaro.org>,
	"Patrik Jakobsson" <patrik.r.jakobsson@gmail.com>,
	"Rob Clark" <robdclark@gmail.com>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Tian Tao" <tiantao6@hisilicon.com>,
	freedreno <freedreno@lists.freedesktop.org>,
	"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH 00/22] drm: Review of mode copies
Date: Tue, 22 Mar 2022 00:37:57 +0200	[thread overview]
Message-ID: <Yjj+RSVBWk6UO2C7@intel.com> (raw)
In-Reply-To: <CADnq5_NS07TPBWSnETRhjzqtX_oUuCu86ewurFT3MJO=PcLAuQ@mail.gmail.com>

On Tue, Mar 15, 2022 at 02:52:38PM -0400, Alex Deucher wrote:
> On Mon, Mar 14, 2022 at 6:12 PM Ville Syrjälä
> <ville.syrjala@linux.intel.com> wrote:
> >
> > On Fri, Feb 18, 2022 at 12:03:41PM +0200, Ville Syrjala wrote:
> > >   drm: Add drm_mode_init()
> > >   drm/bridge: Use drm_mode_copy()
> > >   drm/imx: Use drm_mode_duplicate()
> > >   drm/panel: Use drm_mode_duplicate()
> > >   drm/vc4: Use drm_mode_copy()
> > These have been pushed to drm-misc-next.
> >
> > >   drm/amdgpu: Remove pointless on stack mode copies
> > >   drm/amdgpu: Use drm_mode_init() for on-stack modes
> > >   drm/amdgpu: Use drm_mode_copy()
> > amdgpu ones are reviewed, but I'll leave them for the
> > AMD folks to push to whichever tree they prefer.
> 
> I pulled patches 2, 4, 5 into my tree.

Thanks.

> For 3, I'm happy to have it
> land via drm-misc with the rest of the mode_init changes if you'd
> prefer.

Either way works for me. I don't yet have reviews yet for
the other drivers, so I'll proably hold off for a bit more
at least. And the i915 patch I'll be merging via drm-intel.

> > >   drm/radeon: Use drm_mode_copy()
> > >   drm/gma500: Use drm_mode_copy()
> > >   drm/tilcdc: Use drm_mode_copy()
> > >   drm/i915: Use drm_mode_copy()

Those are now all in.

Which leaves us with these stragglers:
> > >   drm/hisilicon: Use drm_mode_init() for on-stack modes
> > >   drm/msm: Nuke weird on stack mode copy
> > >   drm/msm: Use drm_mode_init() for on-stack modes
> > >   drm/msm: Use drm_mode_copy()
> > >   drm/mtk: Use drm_mode_init() for on-stack modes
> > >   drm/rockchip: Use drm_mode_copy()
> > >   drm/sti: Use drm_mode_copy()
> > >   drm: Use drm_mode_init() for on-stack modes
> > >   drm: Use drm_mode_copy()

-- 
Ville Syrjälä
Intel

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel