From: Rob Herring <robh@kernel.org>
To: Axe Yang <axe.yang@mediatek.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Chaotian Jing <chaotian.jing@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
Satya Tangirala <satyat@google.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Lucas Stach <dev@lynxeye.de>, Eric Biggers <ebiggers@google.com>,
Andrew Jeffery <andrew@aj.id.au>,
Stephen Boyd <swboyd@chromium.org>,
Kiwoong Kim <kwmad.kim@samsung.com>, Yue Hu <huyue2@yulong.com>,
Tian Tao <tiantao6@hisilicon.com>,
angelogioacchino.delregno@collabora.com,
linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v8 1/3] dt-bindings: mmc: mtk-sd: extend interrupts and pinctrls properties
Date: Mon, 21 Mar 2022 18:29:21 -0500 [thread overview]
Message-ID: <YjkKURNzg8JPbXcg@robh.at.kernel.org> (raw)
In-Reply-To: <20220321115133.32121-2-axe.yang@mediatek.com>
On Mon, Mar 21, 2022 at 07:51:32PM +0800, Axe Yang wrote:
> Extend interrupts and pinctrls for SDIO wakeup interrupt feature.
> This feature allow SDIO devices alarm asynchronous interrupt to host
> even when host stop providing clock to SDIO card. An extra wakeup
> interrupt and pinctrl states for SDIO DAT1 pin state switching are
> required in this scenario.
>
> Signed-off-by: Axe Yang <axe.yang@mediatek.com>
> ---
> .../devicetree/bindings/mmc/mtk-sd.yaml | 23 ++++++++++++++++++-
> 1 file changed, 22 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> index 297ada03e3de..f57774535a1d 100644
> --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> @@ -69,12 +69,23 @@ properties:
> - const: ahb_cg
>
> interrupts:
> - maxItems: 1
> + description:
> + Should at least contain MSDC GIC interrupt. To support SDIO in-band wakeup, an extended
> + interrupt is required and be configured as wakeup source irq.
> + minItems: 1
> + maxItems: 2
>
> pinctrl-names:
> + description:
> + Should at least contain default and state_uhs. To support SDIO in-band wakeup, dat1 pin
> + will be switched between GPIO mode and SDIO DAT1 mode, state_eint and state_dat1 are
> + mandatory in this scenarios.
> + minItems: 2
> items:
> - const: default
> - const: state_uhs
> + - const: state_eint
> + - const: state_dat1
>
> pinctrl-0:
> description:
> @@ -86,6 +97,16 @@ properties:
> should contain uhs mode pin ctrl.
> maxItems: 1
>
> + pinctrl-2:
> + description:
> + should switch dat1 pin to GPIO mode.
> + maxItems: 1
> +
> + pinctrl-3:
> + description:
> + should switch SDIO dat1 pin from GPIO mode back to SDIO mode.
How is this different than pinctrl-0?
> + maxItems: 1
> +
> assigned-clocks:
> description:
> PLL of the source clock.
> --
> 2.25.1
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-03-21 23:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-21 11:51 [PATCH v8 0/3] mmc: mediatek: add support for SDIO async IRQ Axe Yang
2022-03-21 11:51 ` [PATCH v8 1/3] dt-bindings: mmc: mtk-sd: extend interrupts and pinctrls properties Axe Yang
2022-03-21 23:29 ` Rob Herring [this message]
2022-03-22 1:35 ` Axe Yang
2022-03-22 8:42 ` AngeloGioacchino Del Regno
2022-03-22 9:33 ` Axe Yang
2022-03-22 16:42 ` Rob Herring
2022-03-23 3:38 ` Axe Yang
2022-03-21 11:51 ` [PATCH v8 2/3] mmc: core: Add support for SDIO wakeup interrupt Axe Yang
2022-03-21 11:51 ` [PATCH v8 3/3] mmc: mediatek: add support for SDIO eint wakup IRQ Axe Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YjkKURNzg8JPbXcg@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=andrew@aj.id.au \
--cc=andriy.shevchenko@linux.intel.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=axe.yang@mediatek.com \
--cc=chaotian.jing@mediatek.com \
--cc=dev@lynxeye.de \
--cc=devicetree@vger.kernel.org \
--cc=ebiggers@google.com \
--cc=huyue2@yulong.com \
--cc=kwmad.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=satyat@google.com \
--cc=swboyd@chromium.org \
--cc=tiantao6@hisilicon.com \
--cc=ulf.hansson@linaro.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).