From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C6515C433EF for ; Wed, 23 Mar 2022 22:24:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=G+vsq+7vpV1UG9Lr2Kkcz6x7GRNCu29JRwhSvz/goYY=; b=zhZBt/ufEO40Gj 62BKHLieBuBa3APG9IOlqjsSfGuS7ZymhTwnowZgv3TwfoRH49Rlf0FXuiw3SHDb5L8ry/YSNXIgV mx4K6LmNswHjudz+saw0UdSgPQgq1TzO6el8U2thjeS2XKST4QsTS0c1BYwzoOmjawMyj2GNiYtMg bawD8/AHapWVYccyS4ugPJ4yasxXIIYZBvJRLgt7Aj2HWotOPLTlSIhyzC6lwRiZUtnpkoLg7GDbx lWutR79/3eSVBdUL/LL490nq0522PYtITjiJcn7bxKLFnR7uoWkOul4CXBm+PxxDH384aR/BlpcIB wQnw7IzCT41v7PSGr+Sg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nX9Nd-00Ewej-UO; Wed, 23 Mar 2022 22:23:02 +0000 Received: from mail-pf1-x42b.google.com ([2607:f8b0:4864:20::42b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nX9NS-00Ewe1-79 for linux-arm-kernel@lists.infradead.org; Wed, 23 Mar 2022 22:22:51 +0000 Received: by mail-pf1-x42b.google.com with SMTP id u22so2500676pfg.6 for ; Wed, 23 Mar 2022 15:22:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=yuhCT1XYYGgw1dNBRxPY3XRz8+9xX+vJlVURnfEK72s=; b=a6UMluZevPKT+3Dg9RSgS2V8HA5VIKtIYAYHNtZAilzCYPLEkP61tf7mwIeq9BnxHV X0SgovhpKa/+gqiVJN6lWUp1uqPIgn+vMHpzy4VXM3c5yJiRCCC7UOKbGbnjbjkhLAE7 RHoBAkQ9xUgD9dL1xMdBPTjxKpnSLtsHOUrHXa/tPYiz85ecbU2IYJE4lBhgWY8zKwGF vqpuZjlGklfvuQhQrNXTf+r2eBpbhmqcZmGyDOFQNN46b1i50uXvRmRLSPk2NVi2GwpT 8vFYEZYuHVzaBo1/gI+EK2Y8aj0KQFDtW7xPe3JsxzKdlPYgnKKD2PAnzmnuMs1FyqJE PHDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=yuhCT1XYYGgw1dNBRxPY3XRz8+9xX+vJlVURnfEK72s=; b=jxZ1VnID+WFm6BqsDmPiooRy7xresaYDbzmpsOMDadmkPhPtR82zd6HRCqYqeK/cx1 W3KTFV+TT4o1ht4pVax3qaGmJXY+cIURYsbgKS7wMqcXKtbd5/hXhLnTWj3IkfDyiTzM fzzx6QrOJOfOjKo1DPMVyxGFu/5g9AFbc2iPrSxaLEVCEM0qQWar2ZBc63jVov9x1c93 NwMiNYJstuEZTAdZLR4MpMS/Hn04CvLkyvD58UyKpIJ7HhAgL9vFawqYJ4LLqK8se5dq VE8a8Bnyn2hQrSuW032KkjRNtyVJpWVSpS2c21x5/mafXMZ8D6R/OaR31ZRna2eaJLPr QGMA== X-Gm-Message-State: AOAM533H6ZNtPiDlPBGUSZyCgpDQtv3ZsHPNMM3Ny+28AwByDt6pHHrv NyAfcvphWmVHwTELMlMIp61/Xg== X-Google-Smtp-Source: ABdhPJzfVU2lcXkwbXmRJ0QbmK41CUoL1lq9MqK1Ux1D5KLG5O0S8v51famIcyUnsJNrUX/Wy/YeJQ== X-Received: by 2002:a63:7f0e:0:b0:381:54ca:6fd0 with SMTP id a14-20020a637f0e000000b0038154ca6fd0mr1631352pgd.524.1648074167926; Wed, 23 Mar 2022 15:22:47 -0700 (PDT) Received: from google.com (150.12.83.34.bc.googleusercontent.com. [34.83.12.150]) by smtp.gmail.com with ESMTPSA id fy9-20020a17090b020900b001c690bc05c4sm675504pjb.0.2022.03.23.15.22.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Mar 2022 15:22:47 -0700 (PDT) Date: Wed, 23 Mar 2022 15:22:43 -0700 From: Ricardo Koller To: Oliver Upton Cc: Reiji Watanabe , Marc Zyngier , kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, James Morse , Alexandru Elisei , Suzuki K Poulose , Paolo Bonzini , Will Deacon , Andrew Jones , Fuad Tabba , Peng Liang , Peter Shier , Jing Zhang , Raghavendra Rao Anata Subject: Re: [PATCH v6 11/25] KVM: arm64: Add remaining ID registers to id_reg_desc_table Message-ID: References: <20220311044811.1980336-1-reijiw@google.com> <20220311044811.1980336-12-reijiw@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220323_152250_312916_B0D1E92A X-CRM114-Status: GOOD ( 27.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 23, 2022 at 08:44:26PM +0000, Oliver Upton wrote: > On Wed, Mar 23, 2022 at 01:13:32PM -0700, Ricardo Koller wrote: > > On Wed, Mar 23, 2022 at 07:53:14PM +0000, Oliver Upton wrote: > > > Hi Reiji, > > > > > > On Thu, Mar 10, 2022 at 08:47:57PM -0800, Reiji Watanabe wrote: > > > > Add hidden or reserved ID registers, and remaining ID registers, > > > > which don't require special handling, to id_reg_desc_table. > > > > Add 'flags' field to id_reg_desc, which is used to indicates hiddden > > > > or reserved registers. Since now id_reg_desc_init() is called even > > > > for hidden/reserved registers, change it to not do anything for them. > > > > > > > > Signed-off-by: Reiji Watanabe > > > > > > I think there is a very important detail of the series that probably > > > should be highlighted. We are only allowing AArch64 feature registers to > > > be configurable, right? AArch32 feature registers remain visible with > > > their default values passed through to the guest. If you've already > > > stated this as a precondition elsewhere then my apologies for the noise. > > > > Aren't AArch64 ID regs architecturally mapped to their AArch32 > > counterparts? They should show the same values. I'm not sure if it's a > > problem (and if KVM is faithful to that rule), > > I believe it's a bit more subtle than that. The AArch32 feature registers > are architecturally mapped to certain encodings accessible from AArch64. > For example, ID_PFR0_EL1 is actually a 64 bit register where bits [31:0] > map to the ID_PFR0 AArch32 register. ID_PFR0_EL1 is only accessible from > AArch64 with the MRS instruction, and ID_PFR0 is only accessible from > AArch32 with the MRC instruction. KVM just so happens to handle both of > these reads from the same sys_reg_desc. > > AFAIK, there does not exist a direct bit mapping between the > ID_*_EL1 <-> ID_AA64*_EL1 registers. But hey, could be wrong :) I think you are right. ID_PFR0_EL1[31:0] doesn't even have the same field as ID_AA64PFR0_EL1[31:0]. The only exception would be RAS which is at [31:28] on both, but it doesn't say anywhere that ID_PFR0_EL1.RAS maps architecturally to ID_AA64PFR0_EL1.RAS. So, I think we can assume it doesn't (?). Thanks, Ricardo > > -- > Thanks, > Oliver _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel