From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 52082C433F5 for ; Wed, 23 Mar 2022 22:27:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DXI89YI4gd+kYknrzLWCZWCNN4Qawty432+XYw3N8eQ=; b=oyjTz0/jHctmfT v99TUxMCsIdaJDGTmIcgmnwGevVLQxpmrLK8YnK+5eL5nxxAp5TjX+q85mJ3hM16iH0Wcx5wTgEOb T5DubSPhm/rISUoWTI43PuEVQtzRLs6mJ6dQMc/Hh8KoYBPBtigupkOPdah1mWSyqJG9ajOsYf3SK kE920egcN/xCTGrnT0ZpOunnKMJm5pu6FTMKp5UibK0FhMzy3YIWVG5e/HREs6+R/atLEb9vm7jPP eVAVbA4y32LnWONKzcBrqwXYQ4lQR4yWtOamOYJilCAPfYI2st7SasANtmE/PZpf/yHnZOES0QtMk 3Spj9/fh2mrfQmG3dvQA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nX9QM-00EwtS-1r; Wed, 23 Mar 2022 22:25:50 +0000 Received: from mail-io1-xd2d.google.com ([2607:f8b0:4864:20::d2d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nX9QH-00Ews9-TP for linux-arm-kernel@lists.infradead.org; Wed, 23 Mar 2022 22:25:47 +0000 Received: by mail-io1-xd2d.google.com with SMTP id 9so316058iou.5 for ; Wed, 23 Mar 2022 15:25:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Iw4wMyP5Sf7W5X1SZGLIFvrZ1vroraSXt5QoxGjdF1M=; b=FHQvXDNOL/p4c7tAShXmGLu/popVPfW38AKAwxh2ANgtNcIWhJWfHCPZYfyhM/AAk/ +j/n8a7BB6UW7PmitudVKaPQJvhDziWaAK0FhG6LmrQ4J8w4khhOAS2d1L9F34Sg8Yvx YnXF/2SGLHH07V7QbBmUvY6h1RCMa3NZxgeCKFr4J/C+P+7NYug8FXhn1irgLBdQUO2a s6XZ54F2Ks+HAzaMbVV/x+vRkNPsEUrgTQW4QE994IEE8Vh8dmhPLCPgL5BUjGl6/3lO LVDogmh0MHe0CYiCysBKnsGgQc5hXtrgUCJJepWyv36g6zTjTjlEzZetrl7KipXF/GbW ogHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Iw4wMyP5Sf7W5X1SZGLIFvrZ1vroraSXt5QoxGjdF1M=; b=kQq5mrhoWzKeSMLf+VgUBdKOETq7pFixKJQ8qPzyN/vlSUzR1IE+Xc0h9ZAxTkkzn/ 5g/ZF2UGSV6HPEBzmUz1aN+ynRSH/H78pBmpQAziI89imz0p/pQ3UeNRrrhYt4xvHCgy oxKsZxiAWWL/Mj0FFGZNs0MfxQFCf4n6PvKPqb8DCsMmiUfKRoHD0OAZGDfl+6PZvA4s tAfaFNO9nw9Y2N7izfWSnOctGqQJj2JSxaRAICQkiGVdToqYhtudeqDkxwc/uMrY7Bxg /fA8UQtG2PoObEEiY/LDsx/qDuJLAstt8Eg0BzpUjpxPfQ1VJYbrGik2Mj+FecifbiW0 U+Cw== X-Gm-Message-State: AOAM531NNJyNPi3zAYGsgupehVArlEJuBO6OOOrK25T6vljjrJUnNwhh dlguj9QTkrNft3jjKWgYt+gPOQ== X-Google-Smtp-Source: ABdhPJxFIaPDyYYMcQ0NO8UayiA1llXj46Qabe9a/Yfed4n4kjHRHD6mY3KZ7CChW/I8o13Kyd7LSQ== X-Received: by 2002:a5d:83c8:0:b0:604:c09b:259c with SMTP id u8-20020a5d83c8000000b00604c09b259cmr1182670ior.106.1648074339082; Wed, 23 Mar 2022 15:25:39 -0700 (PDT) Received: from google.com (194.225.68.34.bc.googleusercontent.com. [34.68.225.194]) by smtp.gmail.com with ESMTPSA id t7-20020a5e9907000000b00649d6bd1ec5sm575577ioj.31.2022.03.23.15.25.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Mar 2022 15:25:38 -0700 (PDT) Date: Wed, 23 Mar 2022 22:25:35 +0000 From: Oliver Upton To: Ricardo Koller Cc: Reiji Watanabe , Marc Zyngier , kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, James Morse , Alexandru Elisei , Suzuki K Poulose , Paolo Bonzini , Will Deacon , Andrew Jones , Fuad Tabba , Peng Liang , Peter Shier , Jing Zhang , Raghavendra Rao Anata Subject: Re: [PATCH v6 11/25] KVM: arm64: Add remaining ID registers to id_reg_desc_table Message-ID: References: <20220311044811.1980336-1-reijiw@google.com> <20220311044811.1980336-12-reijiw@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220323_152545_959296_7F5DFE1D X-CRM114-Status: GOOD ( 31.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 23, 2022 at 03:22:43PM -0700, Ricardo Koller wrote: > On Wed, Mar 23, 2022 at 08:44:26PM +0000, Oliver Upton wrote: > > On Wed, Mar 23, 2022 at 01:13:32PM -0700, Ricardo Koller wrote: > > > On Wed, Mar 23, 2022 at 07:53:14PM +0000, Oliver Upton wrote: > > > > Hi Reiji, > > > > > > > > On Thu, Mar 10, 2022 at 08:47:57PM -0800, Reiji Watanabe wrote: > > > > > Add hidden or reserved ID registers, and remaining ID registers, > > > > > which don't require special handling, to id_reg_desc_table. > > > > > Add 'flags' field to id_reg_desc, which is used to indicates hiddden > > > > > or reserved registers. Since now id_reg_desc_init() is called even > > > > > for hidden/reserved registers, change it to not do anything for them. > > > > > > > > > > Signed-off-by: Reiji Watanabe > > > > > > > > I think there is a very important detail of the series that probably > > > > should be highlighted. We are only allowing AArch64 feature registers to > > > > be configurable, right? AArch32 feature registers remain visible with > > > > their default values passed through to the guest. If you've already > > > > stated this as a precondition elsewhere then my apologies for the noise. > > > > > > Aren't AArch64 ID regs architecturally mapped to their AArch32 > > > counterparts? They should show the same values. I'm not sure if it's a > > > problem (and if KVM is faithful to that rule), > > > > I believe it's a bit more subtle than that. The AArch32 feature registers > > are architecturally mapped to certain encodings accessible from AArch64. > > For example, ID_PFR0_EL1 is actually a 64 bit register where bits [31:0] > > map to the ID_PFR0 AArch32 register. ID_PFR0_EL1 is only accessible from > > AArch64 with the MRS instruction, and ID_PFR0 is only accessible from > > AArch32 with the MRC instruction. KVM just so happens to handle both of > > these reads from the same sys_reg_desc. > > > > AFAIK, there does not exist a direct bit mapping between the > > ID_*_EL1 <-> ID_AA64*_EL1 registers. But hey, could be wrong :) > > I think you are right. ID_PFR0_EL1[31:0] doesn't even have the same > field as ID_AA64PFR0_EL1[31:0]. The only exception would be RAS which is > at [31:28] on both, but it doesn't say anywhere that ID_PFR0_EL1.RAS > maps architecturally to ID_AA64PFR0_EL1.RAS. So, I think we can assume > it doesn't (?). Right, the feature registers are generally related (you will find fields of similar meaning), but figuring out that tangle and making it work is going to be a massive waste of time IMO. If we can say that our new feature configuration is AArch64-only, all potential bugs relating to AArch32 collapse :-) -- Thanks, Oliver _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel