From: Andrew Lunn <andrew@lunn.ch>
To: Jae Hyun Yoo <quic_jaehyoo@quicinc.com>
Cc: Rob Herring <robh+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
Andrew Jeffery <andrew@aj.id.au>,
Jamie Iles <quic_jiles@quicinc.com>,
Graeme Gregory <quic_ggregory@quicinc.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org
Subject: Re: [PATCH] ARM: dts: aspeed: add Nuvia DC-SCM BMC
Date: Thu, 24 Mar 2022 23:19:27 +0100 [thread overview]
Message-ID: <Yjzub26okJosPkXC@lunn.ch> (raw)
In-Reply-To: <88849423-c4a5-0a68-1900-72196395704e@quicinc.com>
On Thu, Mar 24, 2022 at 02:27:34PM -0700, Jae Hyun Yoo wrote:
> Hi Andrew,
>
> On 3/24/2022 2:23 PM, Andrew Lunn wrote:
> > On Thu, Mar 24, 2022 at 09:45:51AM -0700, Jae Hyun Yoo wrote:
> > > From: Graeme Gregory <quic_ggregory@quicinc.com>
> > >
> > > +&mac2 {
> > > + status = "okay";
> > > +
> > > + phy-mode = "rgmii";
> >
> > Are you sure about this? That PHY are you using? It is more normal to
> > use rgmii-id.
>
> Yes, I'm sure. PHY works with rgmii on my board. I picked a different
> clock delay setting too.
Do you know who is inserting the delay? It looks like rgmii will be
passed to the PHY. So there are few possibilities here:
The MAC is adding the delay. Not recommended, but does work. In that
case, your DT is correct.
The bootloader or strapping configures the PHY to insert the
delay. The PHY driver then ignores 'rgmii' and leaves the
configuration alone. This will break sometime in the future when
somebody fixes the PHY driver to actually set the PHY to rgmii as
requested. In this case, both the PHY driver and your DT is broken.
The board itself inserts the delays by having long tracks. In this
case, your DT is correct.
It would be good to understand this, just in case it is the second
condition.
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-03-24 22:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-24 16:45 [PATCH] ARM: dts: aspeed: add Nuvia DC-SCM BMC Jae Hyun Yoo
2022-03-24 21:23 ` Andrew Lunn
2022-03-24 21:27 ` Jae Hyun Yoo
2022-03-24 22:19 ` Andrew Lunn [this message]
2022-03-24 22:40 ` Jae Hyun Yoo
2022-03-25 0:10 ` Andrew Lunn
2022-03-25 0:15 ` Jae Hyun Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yjzub26okJosPkXC@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew@aj.id.au \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=quic_ggregory@quicinc.com \
--cc=quic_jaehyoo@quicinc.com \
--cc=quic_jiles@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).