From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 55E8BC433EF for ; Wed, 6 Apr 2022 18:15:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aACyW63uSpQxNWpHVdbzFyZaNXHey7IKY9aohe6he2E=; b=5CpGAyIAnjW/Zx G+zLMF7acTQ3/Rd9oG6uYncDYAIw38sBGKIglZvasuSHwWMHBTEAWIMhtDO4KXD4PypNgiMh42H3o 8mV2JiLmnSDVLnnS1X8PntmOEnteA2iTNSepImq18/7tAOtF0djG7Ga/s7E8NsV3d8dxf4qxprDYi g3pXQ2oxmEAWbrbJQjAnH5BXq0Z9oc2e3znCyfHgU8g8FMLBLpkwChO6I2Gp8j/KyM8Qk/w53+EuH U+T3AvJDss9dI+eaQQpIsgb3mA9Wb/ZoVZct1IOjFEIs8kvL84Bb5BEK1AQa4N1n1g119TL29jTFn oUoB+7dllmBAPhDqNVwA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ncAAP-007UEk-Ms; Wed, 06 Apr 2022 18:14:05 +0000 Received: from mail-oi1-f170.google.com ([209.85.167.170]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ncAAN-007UDU-1J for linux-arm-kernel@lists.infradead.org; Wed, 06 Apr 2022 18:14:04 +0000 Received: by mail-oi1-f170.google.com with SMTP id z8so3260154oix.3 for ; Wed, 06 Apr 2022 11:14:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=H0QnhyvMcyeV2GoiwbyXURkXVFnwPb25uAf5GGlcDj8=; b=phiujXzALjkmSF23ve01mPnnICNWI8BQMrBncF47FquceQN3w1Aouz0pa4hYGvQ73R kW3vU0YEELzpqcwfIhjuzYHrffW1BrTDPMbsyEqJFVH64mL4xWh7yechP56DcEemn2M6 xZs3pmN0/Rpot0q5vKZlasg3IlN+s7Jkw82zSwZQAbW0ozNEhk8JvhSZgMNOqSQOr23d 6pPnP7W0oOVtlKPYbT6otkJlCWI7xOz9TdUhX2w7yhF9Fpl6icPl1hSQ0OjG6wy/fEYD uvhI4WQBRlnGPf2IpM6Oeb155JlilSEfuwa9VgBbzedvZZ1sKpvcpZHv5YYGbTvAvTtX 2DYA== X-Gm-Message-State: AOAM532Uam6GR6wyjSy+IOwBizb2UENk2wV58D35Ewoiq5t8jgTAwYm8 ktXWCtpgrkjXpA5Z/6XMrg== X-Google-Smtp-Source: ABdhPJwOM1hhMXjwmrAos/oBCbAVRzpkNRe0dBmU8uisDOIEhohB6rSgPnkpQvD3BadEROZk3cMEuw== X-Received: by 2002:a05:6808:202:b0:2ef:8867:bffb with SMTP id l2-20020a056808020200b002ef8867bffbmr4315072oie.28.1649268841208; Wed, 06 Apr 2022 11:14:01 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id o18-20020a9d7652000000b005cbf6f5d7c5sm7110203otl.21.2022.04.06.11.14.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Apr 2022 11:14:00 -0700 (PDT) Received: (nullmailer pid 2523072 invoked by uid 1000); Wed, 06 Apr 2022 18:14:00 -0000 Date: Wed, 6 Apr 2022 13:14:00 -0500 From: Rob Herring To: Kunihiko Hayashi Cc: Jingoo Han , Gustavo Pimentel , Bjorn Helgaas , Krzysztof Kozlowski , Masami Hiramatsu , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] dt-bindings: PCI: designware-ep: Increase maxItems of reg and reg-names Message-ID: References: <1649145062-29833-1-git-send-email-hayashi.kunihiko@socionext.com> <1649145062-29833-2-git-send-email-hayashi.kunihiko@socionext.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1649145062-29833-2-git-send-email-hayashi.kunihiko@socionext.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220406_111403_118267_33FF1007 X-CRM114-Status: GOOD ( 15.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 05, 2022 at 04:51:00PM +0900, Kunihiko Hayashi wrote: > UniPhier PCIe EP controller has 5 register mappings (dbi, dbi2, link, > config and atu), so maxItems of "reg" and "reg-names" should allow 5. Shouldn't that be 'addr_space' rather than 'config'? IIRC, 'config' is only for the host. > > Signed-off-by: Kunihiko Hayashi > --- > Documentation/devicetree/bindings/pci/snps,dw-pcie-ep.yaml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pci/snps,dw-pcie-ep.yaml b/Documentation/devicetree/bindings/pci/snps,dw-pcie-ep.yaml > index e59059ab5be0..03f97e7c4089 100644 > --- a/Documentation/devicetree/bindings/pci/snps,dw-pcie-ep.yaml > +++ b/Documentation/devicetree/bindings/pci/snps,dw-pcie-ep.yaml > @@ -28,11 +28,11 @@ properties: > versions. > For designware core version >= 4.80, it may contain ATU address space. > minItems: 2 > - maxItems: 4 > + maxItems: 5 > > reg-names: > minItems: 2 > - maxItems: 4 > + maxItems: 5 > items: > enum: [dbi, dbi2, config, atu, addr_space, link, atu_dma, appl] > > -- > 2.25.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel