From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0F7D1C433EF for ; Thu, 7 Apr 2022 10:27:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uEOk9j6Tn2K2KOjDzLdVpXkuhF/1oZvdpmb1u826jv4=; b=xkXZpBZ3qCVnCE HIoXjlN7PX9reUEJc6Vgu/0itXy476dNmomk4cGXk4eJlJ4AM5lwocWR6nLQOLfBOWbAvC0KTm1XM EvH3xogmjb15C+v5aOKrvFlDAQ5udT9y1BiCsceYIEGW7+lKztFPQheWx6p/9CbbOvq4ZvBlJ2Zv5 3Y28npDX3vGIGmJZ17/39S65G8jPYWv2RdC7iy2i1hJtv6g4EB6A9F8rZc4VNkm9IagPA6ld2Z/et F14nP3Gzy4XDpcX3p0K5VTMC0yv59u5gZeU5Trmvv3851ZaDCViiBg9qlr9SdrThbJAoWFObDOqs0 +Zu03OuVGotzZuRn5EdQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ncPLX-00BDDi-S1; Thu, 07 Apr 2022 10:26:35 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ncPLU-00BDCg-Mu for linux-arm-kernel@lists.infradead.org; Thu, 07 Apr 2022 10:26:34 +0000 Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 110738125; Thu, 7 Apr 2022 10:24:06 +0000 (UTC) Date: Thu, 7 Apr 2022 13:26:27 +0300 From: Tony Lindgren To: Daniel Lezcano Cc: Thomas Gleixner , linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Keerthy , Nishanth Menon , Vignesh Raghavendra , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org Subject: Re: [PATCH 2/4] clocksource/drivers/timer-ti-dm: Update defines for am6 for inline functions Message-ID: References: <20220407071006.37031-1-tony@atomide.com> <20220407071006.37031-2-tony@atomide.com> <9671f0a5-6860-8a75-d65e-345ce890cd88@linaro.org> <7f3cbdf3-401c-6c30-20fa-b5121bd3f63d@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220407_032632_820791_0F241C5E X-CRM114-Status: GOOD ( 20.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Tony Lindgren [220407 08:50]: > * Daniel Lezcano [220407 08:23]: > > On 07/04/2022 10:15, Tony Lindgren wrote: > > > * Daniel Lezcano [220407 08:01]: > > > > On 07/04/2022 09:10, Tony Lindgren wrote: > > > > > @@ -251,7 +251,8 @@ int omap_dm_timers_active(void); > > > > > * The below are inlined to optimize code size for system timers. Other code > > > > > * should not need these at all. > > > > > */ > > > > > -#if defined(CONFIG_ARCH_OMAP1) || defined(CONFIG_ARCH_OMAP2PLUS) > > > > > +#if defined(CONFIG_ARCH_OMAP1) || defined(CONFIG_ARCH_OMAP2PLUS) || \ > > > > > + defined(CONFIG_ARCH_K3) > > > > > > > > Why not replace the above by CONFIG_OMAP_DM_TIMER ? > > > > > > Hmm that's a good question for why it was not that way earlier. > > > > > > This series changes things for tristate "OMAP dual-mode timer driver" if > > > ARCH_K3 || COMPILE_TEST though. So the inline stubs are still needed for > > > COMPILE_TEST it seems. > > > > But if ARCH_K3 or COMPILE_TEST is set, CONFIG_DM_TIMER is also set, no? > > Right but I suspect that COMPILE_TEST will produce a build error on other > architectures. I need to check that though, maybe that is no longer the > case. We could use IS_ENABLED(CONFIG_OMAP_DM_TIMER), but looks like we can now just move the __omap_dm_timer_* inline functions to timer-ti-dm.c instead. I'll do that and repost after some testing. Regards, Tony _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel