From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 016E8C433EF for ; Thu, 7 Apr 2022 19:00:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ly4hnol6CfQTcVKaxVpv+myuTZC3qwrmc/WPo83o0rc=; b=iZsTcWYeDpPgKw Z4OKnoaqdZcW22WpruKBzYCbF46NBN7cNO7gVrhWV9fb2Z2+xNwollvIB7ET86XPFNTjix5nOlA5f nMqXDC6B1aHPYVeo7X/baRhwayjPMS9oM7Qs1frM0e9E4SYNE/uxFf4bftYfFmjvnmftuHvSyveq8 XrVnFwXC1JKn1tVciNOkE2WEfyW7ov/AM9ZyIypFoztXsCeleKH/6WGtK7XsYzvlQskjMhJ/Ny0Qn JT4xxdGvIX2s6t1FftR4yYPwZItjitiDSqLi1k9wgQ+CWTZ82e7/fBVap1wQzvqJsIk8kZs+G1ACV RwdmYKbfovOpai1G4GjA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ncXLb-00Dd1u-0X; Thu, 07 Apr 2022 18:59:11 +0000 Received: from mail-oa1-f46.google.com ([209.85.160.46]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ncXLW-00Dd0K-Sm for linux-arm-kernel@lists.infradead.org; Thu, 07 Apr 2022 18:59:08 +0000 Received: by mail-oa1-f46.google.com with SMTP id 586e51a60fabf-de48295467so7393406fac.2 for ; Thu, 07 Apr 2022 11:59:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=afrFLzt1gRoFoVRMojGGVgBPp/vAdD+p5A9V+fiaSKw=; b=uAEeMAiBJfVDi8l7vGviA6CRyN+qpZN7SPGunEDJCmF+J+Oku8JSwP2aPkQ3uYsORB ljXv+QLgSZTfn3TPWCWTm8CZ5/GpCTLVm3wTcuA6QVwKYI75W6P2HG/YECGsX8W56zGD P57eODyCs3g8Dohl6R2jMeo5kgqc94iAAaFQI5mzP0/XzeK6l4hQmWws6+vXbSLqQmJW a34DMqbpOTGpsLNE72VJpha1sqsAjDRTHSmbNGYjPqFygzxCe9zgM3yaL0mpU19BHG// uTo7qokYaYDNA2DHlT5MhmD5/JgZ9Tp9HMZTmnsMfo+vHFM0+IijedvHZqrQvwclWdpb EiBg== X-Gm-Message-State: AOAM531io31IvaMz2nwGm+jfCPVfdtZ13pFy2P9F9hOzS3LXkrW3IxZJ UcAOwChdjKrObY8X+Jchb7JzCzsPDw== X-Google-Smtp-Source: ABdhPJxNUG2HZcl4skpjdoCUqh+tz6W3QDAPX323irG1n56LqoDXcyZehrhf7pPhSiaz6mtTAfvVUw== X-Received: by 2002:a05:6870:5584:b0:e1:e254:141d with SMTP id n4-20020a056870558400b000e1e254141dmr7201344oao.95.1649357945276; Thu, 07 Apr 2022 11:59:05 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id q12-20020a4ad54c000000b003245ac0a745sm7568561oos.22.2022.04.07.11.59.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Apr 2022 11:59:04 -0700 (PDT) Received: (nullmailer pid 1783762 invoked by uid 1000); Thu, 07 Apr 2022 18:59:04 -0000 Date: Thu, 7 Apr 2022 13:59:04 -0500 From: Rob Herring To: Kunihiko Hayashi Cc: Vinod Koul , Krzysztof Kozlowski , Masami Hiramatsu , dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dt-bindings: dma: uniphier: Use unevaluatedProperties Message-ID: References: <1649317447-20996-1-git-send-email-hayashi.kunihiko@socionext.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1649317447-20996-1-git-send-email-hayashi.kunihiko@socionext.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220407_115906_953168_A9E25D83 X-CRM114-Status: GOOD ( 17.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 07, 2022 at 04:44:07PM +0900, Kunihiko Hayashi wrote: > This refers common bindings, so this is preferred for > unevaluatedProperties instead of additionalProperties. Yes and no. If you want to define specific common properties are used (and not used), then listing them in the specific schema with 'additionalProperties' is the right way to do that. If all properties in the referenced schema are valid, then unevaluatedProperties is correct. If we wanted using unevaluatedProperties to be a hard rule, we could make the meta-schema enforce that. > > Signed-off-by: Kunihiko Hayashi > --- > .../devicetree/bindings/dma/socionext,uniphier-mio-dmac.yaml | 2 +- > .../devicetree/bindings/dma/socionext,uniphier-xdmac.yaml | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/dma/socionext,uniphier-mio-dmac.yaml b/Documentation/devicetree/bindings/dma/socionext,uniphier-mio-dmac.yaml > index e7bf6dd7da29..b40f247e07be 100644 > --- a/Documentation/devicetree/bindings/dma/socionext,uniphier-mio-dmac.yaml > +++ b/Documentation/devicetree/bindings/dma/socionext,uniphier-mio-dmac.yaml > @@ -45,7 +45,7 @@ required: > - clocks > - '#dma-cells' > > -additionalProperties: false > +unevaluatedProperties: false > > examples: > - | > diff --git a/Documentation/devicetree/bindings/dma/socionext,uniphier-xdmac.yaml b/Documentation/devicetree/bindings/dma/socionext,uniphier-xdmac.yaml > index 371f18773198..b2bd21cbeb7f 100644 > --- a/Documentation/devicetree/bindings/dma/socionext,uniphier-xdmac.yaml > +++ b/Documentation/devicetree/bindings/dma/socionext,uniphier-xdmac.yaml > @@ -40,7 +40,7 @@ properties: > minimum: 1 > maximum: 16 > > -additionalProperties: false > +unevaluatedProperties: false > > required: > - compatible > -- > 2.25.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel