From: Rob Herring <robh@kernel.org>
To: Richard Zhu <hongxing.zhu@nxp.com>
Cc: l.stach@pengutronix.de, bhelgaas@google.com, broonie@kernel.org,
lorenzo.pieralisi@arm.com, jingoohan1@gmail.com,
festevam@gmail.com, francesco.dolcini@toradex.com,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel@pengutronix.de,
linux-imx@nxp.com
Subject: Re: [PATCH v8 8/8] PCI: imx6: Add compliance tests mode support
Date: Fri, 1 Apr 2022 15:26:33 -0500 [thread overview]
Message-ID: <Ykdf+dQE10fkK3K6@robh.at.kernel.org> (raw)
In-Reply-To: <1645760667-10510-9-git-send-email-hongxing.zhu@nxp.com>
On Fri, Feb 25, 2022 at 11:44:27AM +0800, Richard Zhu wrote:
> Refer to the Chapter 3.2 System Board Signal Quality of PCI Express
> Architecture PHY Test Specification Revision 2.0.
>
> Signal quality tests (for example: jitter, differential eye opening and
> so on) can be executed with devices in the polling.compliance state.
>
> To let the device support polling.compliance state, the clocks and powers
> shouldn't be turned off when the probe of device driver fails.
>
> Based on CLB (Compliance Load Board) Test Fixture and so on test
> equipments, the PHY link would be down during the compliance tests.
> Refer to this scenario, add the i.MX PCIe compliance tests mode enable
> support, and keep the clocks and powers on, and finish the driver probe
> without error return.
How is this specific to i.MX? If there's a need for compliance test
mode, then shouldn't it be common? However, while your usecase is
compliance testing, there doesn't seem to be any need for the kernel to
know what the usecase is.
In the same series you've argued both ways. You need the driver to probe
successfully with no link and you need it to shutdown on no link.
>
> Use the "pci_imx6.compliance=1" in kernel command line to enable the
> compliance tests mode.
>
> Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
> ---
> drivers/pci/controller/dwc/pci-imx6.c | 47 ++++++++++++++++++---------
> 1 file changed, 31 insertions(+), 16 deletions(-)
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-04-01 20:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-25 3:44 [PATCH v8 0/8] PCI: imx6: refine codes and add compliance tests mode support Richard Zhu
2022-02-25 3:44 ` [PATCH v8 1/8] PCI: imx6: Encapsulate the clock enable into one standalone function Richard Zhu
2022-02-25 3:44 ` [PATCH v8 2/8] PCI: imx6: Add the error propagation from host_init Richard Zhu
2022-02-25 3:44 ` [PATCH v8 3/8] PCI: imx6: Move imx6_pcie_clk_disable() earlier Richard Zhu
2022-02-25 3:44 ` [PATCH v8 4/8] PCI: imx6: Disable iMX6QDL PCIe REF clock when disable PCIe clocks Richard Zhu
2022-02-25 3:44 ` [PATCH v8 5/8] PCI: imx6: Refine the regulator usage Richard Zhu
2022-02-25 9:43 ` Francesco Dolcini
2022-02-28 3:43 ` Hongxing Zhu
2022-03-04 7:45 ` Francesco Dolcini
2022-03-04 8:44 ` Hongxing Zhu
2022-02-25 3:44 ` [PATCH v8 6/8] PCI: dwc: Add dw_pcie_host_ops.host_exit() callback Richard Zhu
2022-04-01 20:43 ` Rob Herring
2022-04-02 3:03 ` Hongxing Zhu
2022-04-04 14:39 ` Rob Herring
2022-04-05 3:15 ` Hongxing Zhu
2022-02-25 3:44 ` [PATCH v8 7/8] PCI: imx6: Disable clocks and regulators after link is down Richard Zhu
2022-02-25 3:44 ` [PATCH v8 8/8] PCI: imx6: Add compliance tests mode support Richard Zhu
2022-04-01 20:26 ` Rob Herring [this message]
2022-04-02 3:03 ` Hongxing Zhu
2022-03-14 5:26 ` [PATCH v8 0/8] PCI: imx6: refine codes and add " Hongxing Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ykdf+dQE10fkK3K6@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=bhelgaas@google.com \
--cc=broonie@kernel.org \
--cc=festevam@gmail.com \
--cc=francesco.dolcini@toradex.com \
--cc=hongxing.zhu@nxp.com \
--cc=jingoohan1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).