From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 06E6AC433F5 for ; Fri, 1 Apr 2022 20:50:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vuug8qPY/yHLXsrtn4KoFMxdK4q/DcEqCdsNrf8lP6c=; b=wMecmA8kUUaURK xXlITNu55IzkZcsWzG4+l06eoPESmBtMzljFKNFDUsZc+AB0ktKpmbnNwRj9yzjM9vqVqilzmH+4Q ErPdsvsYxEyE4A++2dpbGvWO482mbSnuOkUR82Va5ogxCSJ3zjoCDnZ4eZM0OCSC7CI3MH5ocubXM gb+X737sz80r2BmS64xWxyY7nphEZZbk3/0kcZkbeIBrIXn0tUogTUct6QVLLCWRsh8hubFQk5NtB FVEgf9Fc9V2XfvmtOIyz+v/QKRr7pSQP0APSdBKopNmjVwgIRCOqpPK4lJi2EAcbCC6xkb5PxUWWF 7xyrrE+tXC0V1Y+8RGHg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1naOCr-007JAm-R4; Fri, 01 Apr 2022 20:49:17 +0000 Received: from mga04.intel.com ([192.55.52.120]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1naOCn-007J8D-AC; Fri, 01 Apr 2022 20:49:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1648846153; x=1680382153; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=KV+pFZKLWh422cNJSg0ZSjERIplw9IBD5K8wbfwKPgc=; b=eUx/CTbfuUiOcfvE4Eo9lHPi/B6Bx1hOOv3Qno7KOpqRA6nGeLpYpuMj KWy5Ksv/pQVa7AUrOGUqSR/W01QEiShNAPWPrSVnAwDigXWnH3Zbw3Dw7 D5GRdAVu1JVrt39zZIXOIz5gdIi0pTrqZze1RGQJKcM215crJm+oi87jt nj18nqh6fVygw3m5c4fCyzoxdYrVAxqQQGQ0xzukh4G4/jGqsmeNXIx+c VpnTHO9q/EvJ1gUs7qBUUAAkZc7LuZuxfmmkAXUdL39z6jPaJzg89hpPv Q4bQoB7vTouy4YkiRwkwr0pABwNCdKDi/ASq67K4ZV83a9FXvi+FZJXJt g==; X-IronPort-AV: E=McAfee;i="6200,9189,10304"; a="259057413" X-IronPort-AV: E=Sophos;i="5.90,228,1643702400"; d="scan'208";a="259057413" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2022 13:49:11 -0700 X-IronPort-AV: E=Sophos;i="5.90,228,1643702400"; d="scan'208";a="650850877" Received: from kmislam-mobl1.amr.corp.intel.com (HELO localhost) ([10.212.112.89]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2022 13:49:11 -0700 Date: Fri, 1 Apr 2022 13:49:11 -0700 From: Ira Weiny To: "Fabio M. De Francesco" Cc: Nicolas Saenz Julienne , Greg Kroah-Hartman , bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev Subject: Re: [PATCH] staging: vc04_services: Convert kmap() to kmap_local_page() Message-ID: References: <20220330191414.23141-1-fmdefrancesco@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220330191414.23141-1-fmdefrancesco@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220401_134913_429304_1BDF309F X-CRM114-Status: GOOD ( 18.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 30, 2022 at 09:14:14PM +0200, Fabio M. De Francesco wrote: > The use of kmap() is being deprecated in favor of kmap_local_page() > where it is feasible. In file interface/vchiq_arm/vchiq_arm.c, > function free_pagelist() calls kmap() / kunmap() from two places. > > With kmap_local_page(), the mapping is per thread, CPU local and not > globally visible. Therefore, free_pagelist() is a function where the > use of kmap_local_page() in place of kmap() is correctly suited. > > Convert to kmap_local_page() but, instead of open coding it, use the > memcpy_to_page() helper. > > Signed-off-by: Fabio M. De Francesco LGTM: Reviewed-by: Ira Weiny > --- > .../vc04_services/interface/vchiq_arm/vchiq_arm.c | 13 +++++-------- > 1 file changed, 5 insertions(+), 8 deletions(-) > > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > index f0bfacfdea80..efb1383b5218 100644 > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > @@ -431,21 +431,18 @@ free_pagelist(struct vchiq_pagelist_info *pagelistinfo, > if (head_bytes > actual) > head_bytes = actual; > > - memcpy((char *)kmap(pages[0]) + > + memcpy_to_page(pages[0], > pagelist->offset, > fragments, > head_bytes); > - kunmap(pages[0]); > } > if ((actual >= 0) && (head_bytes < actual) && > - (tail_bytes != 0)) { > - memcpy((char *)kmap(pages[num_pages - 1]) + > - ((pagelist->offset + actual) & > - (PAGE_SIZE - 1) & ~(g_cache_line_size - 1)), > + (tail_bytes != 0)) > + memcpy_to_page(pages[num_pages - 1], > + (pagelist->offset + actual) & > + (PAGE_SIZE - 1) & ~(g_cache_line_size - 1), > fragments + g_cache_line_size, > tail_bytes); > - kunmap(pages[num_pages - 1]); > - } > > down(&g_free_fragments_mutex); > *(char **)fragments = g_free_fragments; > -- > 2.34.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel