From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BDF76C433F5 for ; Sun, 3 Apr 2022 15:12:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kMH2seiyTlVD3X3UI2NewC7k1Cj+xxyHdQ/qmEAzYEU=; b=tlxTnGTDwejLW9 5KnUyGRbxyDGdgFRQxzpA/R8tajesAlvGEfx/W5QAq6AzGiOqWjrKTSsdifUhNyEg/jib1KgPTe+G nZKvXS5UtpFt2Qe0Tx4T7Vbg0ZKWtyWrcm1XMHdlcBdDns8gPaTVu8MTn6I0XS2PaEw/aFHToYkLA I5AUOrSS3Z9AD3Jf07e7WAL48KXZoaAH1WsYvxn724wJ+FhXqqSe4W2eMg27NnU8v3Cd93RoqswzX 1ZX4+tcGE+vEhtYJAGDKvVRDTi5tA/QadUlnyqEzxEw6mWX2luFRs7YaHvxiwdvwnORhv0YxPat2/ UqG2F1qISQ/YXjfoHE5w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nb1t8-00BfnP-Su; Sun, 03 Apr 2022 15:11:35 +0000 Received: from mail-oa1-f46.google.com ([209.85.160.46]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nb1t5-00Bfma-OW for linux-arm-kernel@lists.infradead.org; Sun, 03 Apr 2022 15:11:33 +0000 Received: by mail-oa1-f46.google.com with SMTP id 586e51a60fabf-e1e5e8d9faso2639294fac.4 for ; Sun, 03 Apr 2022 08:11:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=m1h55tSJf82mTXNy49E7xrgITJy4PuS1a1RbU7Daru8=; b=mXbthbV362mmJj8EpL7ShfSTRIwZeld0BgdK3iypNaUCYAaN67/0mog8u8yftplgTo 42tzAEld++LJCnPiWFfNNvXND6ZRtBUWm6YWGFxu4zgATpD9+W1J1PgK4hUHfm7sOFOz uG+FeqTLo3XY9ZpXEA+ogbsXb1VWOpvZKOOLYACAg2AhfxYWn1lr+5wG9ob/SaPw06Xw QRMIkrvq4UldK+KwiDILdsjdi5xNid0TSWFidOV2nNp8en+8KrIQDxYXapfzTmXZC8ky gmz78NDT2G+a6c7GO7qNF6MMrXjeNGAY7SLMnyLaI855htJjPCbazAZuyjWqKSE3muR5 7Y/A== X-Gm-Message-State: AOAM532uboJjEmtaGOU3bA40vJ3Rs2JFjr+3hRaBVuJZmj/vL7IxvU6V HSJGKhTqMo9gE5rAulO9Mw== X-Google-Smtp-Source: ABdhPJwy/B5nwR3a6fzxCQA31lcGBi42z4c18Q1IvNY5UEMaWJqDMwLoOib6qOHIsTAqaouBM1AkDw== X-Received: by 2002:a05:6870:c208:b0:dd:994e:3b98 with SMTP id z8-20020a056870c20800b000dd994e3b98mr8331704oae.259.1648998689749; Sun, 03 Apr 2022 08:11:29 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id r129-20020acac187000000b002ef358c6e0esm3239158oif.49.2022.04.03.08.11.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Apr 2022 08:11:29 -0700 (PDT) Received: (nullmailer pid 3096945 invoked by uid 1000); Sun, 03 Apr 2022 15:11:28 -0000 Date: Sun, 3 Apr 2022 10:11:28 -0500 From: Rob Herring To: Krzysztof Kozlowski Cc: Liam Girdwood , Mark Brown , Krzysztof Kozlowski , Alim Akhtar , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, Geert Uytterhoeven Subject: Re: [PATCH 1/2] regulator: dt-bindings: maxim, max8997: correct array of voltages Message-ID: References: <20220331211653.175200-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220331211653.175200-1-krzysztof.kozlowski@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220403_081131_837119_D2D69D23 X-CRM114-Status: GOOD ( 16.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 31, 2022 at 11:16:52PM +0200, Krzysztof Kozlowski wrote: > uint32-array with voltages should be within one bracket pair <>, not > each number in its own <>. Also the number of elements in the array > should be defined within "items:". Which encoding an array uses has been a source of pain. > > This fixes DT schema warnings like: > > maxim,max8997.example.dtb: pmic@66: max8997,pmic-buck1-dvs-voltage: > [[1350000, 1300000, 1250000, 1200000, 1150000, 1100000, 1000000, 950000]] is too short These exist due to the move from validating yaml files to DTBs and I haven't come up with how to fix the warning. The schema was correct as it was. The change leaks the encoding (everything is a matrix) into the schema which we don't want to do. The issue is in the if/then schema, the tools don't know if the type is an array or matrix. It gets it wrong (or different from the top-level) and thus the warning. I think the fix will be using the extracted type information to do the right transformation. The code for all this is pretty horrible and I've lost count of how many times I've re-written it. I think a lot of it can be removed when/if support for yaml encoded DT is removed which I think can happen in a kernel cycle or 2. Perhaps in the short term the example can just be removed or commented out though that doesn't help on dts files. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel