From: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
To: Jernej Skrabec <jernej.skrabec@gmail.com>
Cc: p.zabel@pengutronix.de, mchehab@kernel.org, nicolas@ndufresne.ca,
hverkuil-cisco@xs4all.nl, gregkh@linuxfoundation.org,
wens@csie.org, samuel@sholland.org, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-staging@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev
Subject: Re: [RFC PATCH 5/8] media: hantro: postproc: Fix legacy regs configuration
Date: Sun, 3 Apr 2022 21:24:53 -0300 [thread overview]
Message-ID: <Yko61YA2DpHi7/4B@eze-laptop> (raw)
In-Reply-To: <20220227144926.3006585-6-jernej.skrabec@gmail.com>
On Sun, Feb 27, 2022 at 03:49:23PM +0100, Jernej Skrabec wrote:
> Some postproc legacy registers were set in VP9 code. Move them to
> postproc and fix their value.
>
> Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Reviewed-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
> ---
> drivers/staging/media/hantro/hantro_g2_vp9_dec.c | 8 --------
> drivers/staging/media/hantro/hantro_postproc.c | 10 ++++++++++
> 2 files changed, 10 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/staging/media/hantro/hantro_g2_vp9_dec.c b/drivers/staging/media/hantro/hantro_g2_vp9_dec.c
> index 91c21b634fab..c9cb11fd95af 100644
> --- a/drivers/staging/media/hantro/hantro_g2_vp9_dec.c
> +++ b/drivers/staging/media/hantro/hantro_g2_vp9_dec.c
> @@ -515,16 +515,8 @@ static void
> config_bit_depth(struct hantro_ctx *ctx, const struct v4l2_ctrl_vp9_frame *dec_params)
> {
> if (ctx->dev->variant->legacy_regs) {
> - u8 pp_shift = 0;
> -
> hantro_reg_write(ctx->dev, &g2_bit_depth_y, dec_params->bit_depth);
> hantro_reg_write(ctx->dev, &g2_bit_depth_c, dec_params->bit_depth);
> - hantro_reg_write(ctx->dev, &g2_rs_out_bit_depth, dec_params->bit_depth);
> -
> - if (dec_params->bit_depth > 8)
> - pp_shift = 16 - dec_params->bit_depth;
> -
> - hantro_reg_write(ctx->dev, &g2_pp_pix_shift, pp_shift);
> hantro_reg_write(ctx->dev, &g2_pix_shift, 0);
> } else {
> hantro_reg_write(ctx->dev, &g2_bit_depth_y_minus8, dec_params->bit_depth - 8);
> diff --git a/drivers/staging/media/hantro/hantro_postproc.c b/drivers/staging/media/hantro/hantro_postproc.c
> index 1a76628d5754..11ae663f11b7 100644
> --- a/drivers/staging/media/hantro/hantro_postproc.c
> +++ b/drivers/staging/media/hantro/hantro_postproc.c
> @@ -113,6 +113,16 @@ static void hantro_postproc_g2_enable(struct hantro_ctx *ctx)
>
> hantro_write_addr(vpu, G2_RS_OUT_LUMA_ADDR, dst_dma);
> hantro_write_addr(vpu, G2_RS_OUT_CHROMA_ADDR, dst_dma + chroma_offset);
> + if (ctx->dev->variant->legacy_regs) {
> + int out_depth = hantro_get_formath_depth(ctx->dst_fmt.pixelformat);
> + u8 pp_shift = 0;
> +
> + if (out_depth > 8)
> + pp_shift = 16 - out_depth;
> +
> + hantro_reg_write(ctx->dev, &g2_rs_out_bit_depth, out_depth);
> + hantro_reg_write(ctx->dev, &g2_pp_pix_shift, pp_shift);
> + }
> hantro_reg_write(vpu, &g2_out_rs_e, 1);
> }
>
> --
> 2.35.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-04-04 0:26 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-27 14:49 [RFC PATCH 0/8] media: hantro: Add 10-bit support Jernej Skrabec
2022-02-27 14:49 ` [RFC PATCH 1/8] media: Add P010 tiled format Jernej Skrabec
2022-02-27 14:49 ` [RFC PATCH 2/8] media: Add P010 format Jernej Skrabec
2022-02-28 12:48 ` Nicolas Dufresne
2022-02-28 16:32 ` Jernej Škrabec
2022-02-28 17:02 ` Nicolas Dufresne
2022-04-04 0:04 ` Ezequiel Garcia
2022-04-04 9:02 ` Benjamin Gaignard
2022-02-27 14:49 ` [RFC PATCH 3/8] media: hantro: Support format filtering by depth Jernej Skrabec
2022-04-05 16:09 ` Benjamin Gaignard
2022-04-05 18:41 ` Jernej Škrabec
2022-02-27 14:49 ` [RFC PATCH 4/8] media: hantro: postproc: Fix buffer size calculation Jernej Skrabec
2022-04-04 0:16 ` Ezequiel Garcia
2022-02-27 14:49 ` [RFC PATCH 5/8] media: hantro: postproc: Fix legacy regs configuration Jernej Skrabec
2022-04-04 0:24 ` Ezequiel Garcia [this message]
2022-02-27 14:49 ` [RFC PATCH 6/8] media: hantro: Store VP9 bit depth in context Jernej Skrabec
2022-02-27 14:49 ` [RFC PATCH 7/8] media: hantro: sunxi: Enable 10-bit decoding Jernej Skrabec
2022-02-27 14:49 ` [RFC PATCH 8/8] media: hantro: sunxi: Increase frequency Jernej Skrabec
2022-02-27 17:03 ` [RFC PATCH 0/8] media: hantro: Add 10-bit support Jernej Škrabec
2022-04-05 16:07 ` Benjamin Gaignard
2022-04-05 18:40 ` Jernej Škrabec
2022-04-06 6:54 ` Benjamin Gaignard
2022-04-06 17:21 ` Jernej Škrabec
2022-04-06 17:50 ` Nicolas Dufresne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yko61YA2DpHi7/4B@eze-laptop \
--to=ezequiel@vanguardiasur.com.ar \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jernej.skrabec@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux-sunxi@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=nicolas@ndufresne.ca \
--cc=p.zabel@pengutronix.de \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).