From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F2B8DC433F5 for ; Mon, 4 Apr 2022 11:39:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kh4RILhKL9fQ/6V+cqLVURSmTMP3ghU6rI3sjvXpuZo=; b=b1L1EZGDLjKGwN PRC741C91eCOBHWKlT4U289me971jGPpbtQo/pWz2Blrtfo+7RAHc/01AiFEFcYkylMvjkUltL7lt VlufxhRzMppqNknuIGxuyy5O5l0BYfPkD+W0SskkHfUUeu2yRcIz9zT2aMzPc0pCvESb9rI4LS/TZ RSXRSn1SQJDttQ1sVOiMr8VC+xu49PSI2xT43Iw+6UWLS8NaxSXxDwU6J9d4xJa9DWJ7LmGDp1SeH xcb357FGydJXiIavAG7jcm3rEU17vJi4c+dDywJQk9qPtu+JLVpSuj3UI1ynyEtFeVFDc7n7qQD3q zJOAvAEeJQpYCO2mVRow==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nbL2c-00Ejo1-H0; Mon, 04 Apr 2022 11:38:38 +0000 Received: from [2001:8b0:1628:5005::111] (helo=metanate.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nbL2Z-00Ejml-C9; Mon, 04 Apr 2022 11:38:36 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=metanate.com; s=stronger; h=In-Reply-To:Content-Type:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description; bh=Zc6VIIFKcy+op7oiVyHdf8N32KwbpWfsc0NuQgZSdH0=; b=A09kS 4qQJvDZkpFSIawTG5uMZmetjLA+RGO9CsRi4k2sbBzNeWaLiXery34BExS5su42r7muhdvrdM8WIQ x9KwpGUfSE2NDatySu4737MPqwRwtNiOED/1x+lPjJHTiOZC/BkXa91DXlY+JYYy5zhu8ZFYtQZ5K CuKq69Gq6O6Eg0yCb9motDhMhrLI9LGSQ/yF2UpHd6yHfs/wPEMzplvi2JxUHtACYQEq/XmM5dwv2 nw+6XDizcBR3gaE7Cilb9BabPVde3A0uq81yV2W12N7qgOBzuxhZn0zo2IkZGnBKwXNCZeZV4OEtp +NTMpxJjbuRIvHKTmSLwHnN7KGtqw==; Received: from [81.174.171.191] (helo=donbot) by email.metanate.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1nbL2S-000544-C8; Mon, 04 Apr 2022 12:38:28 +0100 Date: Mon, 4 Apr 2022 12:38:27 +0100 From: John Keeping To: Corentin Labbe Cc: heiko@sntech.de, herbert@gondor.apana.org.au, krzk+dt@kernel.org, robh+dt@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH v4 17/33] crypto: rockchip: use read_poll_timeout Message-ID: References: <20220401201804.2867154-1-clabbe@baylibre.com> <20220401201804.2867154-18-clabbe@baylibre.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220401201804.2867154-18-clabbe@baylibre.com> X-Authenticated: YES X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220404_043835_445559_52468C1A X-CRM114-Status: GOOD ( 15.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Apr 01, 2022 at 08:17:48PM +0000, Corentin Labbe wrote: > Use read_poll_timeout instead of open coding it > > Signed-off-by: Corentin Labbe > --- > drivers/crypto/rockchip/rk3288_crypto_ahash.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/crypto/rockchip/rk3288_crypto_ahash.c b/drivers/crypto/rockchip/rk3288_crypto_ahash.c > index 137013bd4410..21c9a0327ddf 100644 > --- a/drivers/crypto/rockchip/rk3288_crypto_ahash.c > +++ b/drivers/crypto/rockchip/rk3288_crypto_ahash.c > @@ -10,6 +10,7 @@ > */ > #include > #include > +#include > #include "rk3288_crypto.h" > > /* > @@ -305,8 +306,8 @@ static int rk_hash_run(struct crypto_engine *engine, void *breq) > * efficiency, and make it response quickly when dma > * complete. > */ > - while (!CRYPTO_READ(tctx->dev, RK_CRYPTO_HASH_STS)) > - udelay(10); > + read_poll_timeout(readl, v, v == 0, 10, 1000, false, > + tctx->dev->dev + RK_CRYPTO_HASH_STS); This can be simplified to: readl_poll_timeout(tctx->dev->dev + RK_CRYPTO_HASH_STS, v, v == 0, 10, 1000); But shouldn't this be tctx->dev->reg ?! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel