From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A7D03C433F5 for ; Mon, 4 Apr 2022 16:07:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9iFhYVu36oxaplZU9w9F+TL+XV5FKtSaN+32VMSJALM=; b=LyJf9lCV9g0Sql O0Zu3YGebFgNxijocK8I1GCVvPyVmK388sUaeJDwTmF+QM9W6SsoZj6uA4aejM3SteyRKNGY6Rg1i myDQu6BJxP2wMWjGnL20N78/v4kzRCyteG8pPgajcElzePbD6g+6amqMzRvqSsdb9Dc0ca2TPp/ud HjZjQTbZT/Pwxord1WeUvkBosXsoGr4ZcE0tJJ2iR895gckn4t4qI+7Uh+wOYKnly3HROa8dvxkuD ncbCSkW92r3H46HZW98cBznBUQs9Y2cPg949zs3gri4Vr+lbKScn73X3XCwq9xkmce4tyOU91vXEQ nWuyD4XR0reXwUzpKEUg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nbPDF-00Fi7g-7Q; Mon, 04 Apr 2022 16:05:53 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nbPAa-00Fgl0-1M; Mon, 04 Apr 2022 16:03:10 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3CFA21474; Mon, 4 Apr 2022 09:03:07 -0700 (PDT) Received: from localhost (ionvoi01-desktop.cambridge.arm.com [10.1.196.65]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D6ED33F73B; Mon, 4 Apr 2022 09:03:06 -0700 (PDT) Date: Mon, 4 Apr 2022 17:03:05 +0100 From: Ionela Voinescu To: Lukasz Luba Cc: linux-kernel@vger.kernel.org, dietmar.eggemann@arm.com, Pierre.Gondois@arm.com, viresh.kumar@linaro.org, rafael@kernel.org, daniel.lezcano@linaro.org, linux-pm@vger.kernel.org, mka@chromium.org, nm@ti.com, sboyd@kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, cristian.marussi@arm.com, sudeep.holla@arm.com, matthias.bgg@gmail.com Subject: Re: [RESEND][PATCH 8/8] powercap: DTPM: Check for Energy Model type Message-ID: References: <20220321095729.20655-1-lukasz.luba@arm.com> <20220321095729.20655-9-lukasz.luba@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220321095729.20655-9-lukasz.luba@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220404_090308_201045_5AF3AB9F X-CRM114-Status: GOOD ( 13.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Monday 21 Mar 2022 at 09:57:29 (+0000), Lukasz Luba wrote: > The Energy Model power values might be artificial. In such case > it's safe to bail out during the registration, since the PowerCap > framework supports only micro-Watts. > > Signed-off-by: Lukasz Luba > --- > drivers/powercap/dtpm_cpu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/powercap/dtpm_cpu.c b/drivers/powercap/dtpm_cpu.c > index bca2f912d349..f5eced0842b3 100644 > --- a/drivers/powercap/dtpm_cpu.c > +++ b/drivers/powercap/dtpm_cpu.c > @@ -211,7 +211,7 @@ static int __dtpm_cpu_setup(int cpu, struct dtpm *parent) > return 0; > > pd = em_cpu_get(cpu); > - if (!pd) > + if (!pd || em_is_artificial(pd)) > return -EINVAL; > > dtpm_cpu = kzalloc(sizeof(*dtpm_cpu), GFP_KERNEL); Reviewed-by: Ionela Voinescu > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel