From: Vinod Koul <vkoul@kernel.org>
To: "Martin Povišer" <povik+lin@cutebit.org>
Cc: Hector Martin <marcan@marcan.st>, Sven Peter <sven@svenpeter.dev>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Alyssa Rosenzweig <alyssa@rosenzweig.io>,
linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Mark Kettenis <kettenis@openbsd.org>
Subject: Re: [PATCH v2 2/2] dmaengine: apple-admac: Add Apple ADMAC driver
Date: Wed, 20 Apr 2022 18:10:16 +0530 [thread overview]
Message-ID: <Yl//MF1MeUFE6N4y@matsya> (raw)
In-Reply-To: <20220411222204.96860-3-povik+lin@cutebit.org>
On 12-04-22, 00:22, Martin Povišer wrote:
> +struct admac_chan {
> + int no;
Unsigned int perhaps?
> +static int admac_desc_free(struct dma_async_tx_descriptor *tx)
> +{
> + struct admac_tx *adtx = to_admac_tx(tx);
> +
> + devm_kfree(to_admac_chan(tx->chan)->host->dev, adtx);
Why use devm for descriptor memory?
> +static int admac_device_config(struct dma_chan *chan,
> + struct dma_slave_config *config)
> +{
> + struct admac_chan *adchan = to_admac_chan(chan);
> + struct admac_data *ad = adchan->host;
> + bool is_tx = admac_chan_direction(adchan->no) == DMA_MEM_TO_DEV;
so are the channel directions hard wired in hardware?
--
~Vinod
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-04-20 12:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-11 22:22 [PATCH v2 0/2] Apple ADMAC driver Martin Povišer
2022-04-11 22:22 ` [PATCH v2 1/2] dt-bindings: dma: Add Apple ADMAC Martin Povišer
2022-04-14 15:43 ` Rob Herring
2022-04-14 17:23 ` Martin Povišer
2022-04-14 17:52 ` Martin Povišer
2022-04-11 22:22 ` [PATCH v2 2/2] dmaengine: apple-admac: Add Apple ADMAC driver Martin Povišer
2022-04-20 12:40 ` Vinod Koul [this message]
2022-04-20 13:41 ` Martin Povišer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yl//MF1MeUFE6N4y@matsya \
--to=vkoul@kernel.org \
--cc=alyssa@rosenzweig.io \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=kettenis@openbsd.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=povik+lin@cutebit.org \
--cc=robh+dt@kernel.org \
--cc=sven@svenpeter.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).