From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5718DC433F5 for ; Mon, 18 Apr 2022 19:04:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pJsKgmo7cISc+2sIiTwuNh9eOnabcSHsKLzFMeKr66Y=; b=JoOnE5IYItMBZp SfCt3yeAsGE9kaG/r31H20ZUW2DbL49Gf0Jxr7PQp37FcLRUOFwmHq9ZknHqj/UyoIsiOYqK7uNko qBPh0lnFM+BsvpVo2fso/hMOMm3A4w7zMG1dCryc8xB+ngcJOv9juVVDh7utLUw6NaS/0WEzzU/l7 uehVaFfcwUCTfq9N9YXkCn5Z+tOyiRo9l/Wvd9Qq5O2D9bxjPLSck+J0C76U0fi3DLb9V7dIZmQIn wEmo7KwOA5IAgHQXA4lZW0mn81yTcPdLnbKwOL1DBlEaK8mEjrPOa3jxJ0Le3NJyuNr38scsG2VR6 qHVAFUV560+94rRj0wiQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngWf8-000OEM-OL; Mon, 18 Apr 2022 19:03:50 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngWf6-000ODf-74 for linux-arm-kernel@lists.infradead.org; Mon, 18 Apr 2022 19:03:49 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5DEB260B80; Mon, 18 Apr 2022 19:03:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7D08EC385A7; Mon, 18 Apr 2022 19:03:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650308626; bh=7weyYpdH1PMpEntkBRnFKu6bXPlkXQpX66FX/bTmMKk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KoerriXFohbSDWB/qmzOO1UTY6l8K2cSwlS9jBBlpltmNYJ3KmQp4GGeIhYcrULIf 5QoDxO82tjGt42hjfjaHE4UOYp2kPZHAkeL1aPSH/A/Db5ZWWQ0Y9QU5lw64tK9eLO v0YrBYHVz/w5VGZL16Jghg0bPan539jVFS31g0tyJe9TB8dLxdbpfJLVV7EovXeaox oaEp1VYrnC1PiaSg0QC31DxghPvdDb6IzK6iPTn/f652STmXt6+WzF/hQ9Cqyrwc27 XODoR5QVv4Z+uyuHaHMhmETpsl8K81JcC2vW8lbAuZBLLpy9V4U5Jzq/B+i0mnKlps EJpDXUnqo5TzA== Date: Mon, 18 Apr 2022 12:03:41 -0700 From: Eric Biggers To: Nathan Huckleberry Cc: linux-crypto@vger.kernel.org, Herbert Xu , "David S. Miller" , linux-arm-kernel@lists.infradead.org, Paul Crowley , Sami Tolvanen , Ard Biesheuvel Subject: Re: [PATCH v4 1/8] crypto: xctr - Add XCTR support Message-ID: References: <20220412172816.917723-1-nhuck@google.com> <20220412172816.917723-2-nhuck@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220412172816.917723-2-nhuck@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220418_120348_335442_38A9A03E X-CRM114-Status: GOOD ( 11.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 12, 2022 at 05:28:09PM +0000, Nathan Huckleberry wrote: > +// Limited to 16-byte blocks for simplicity > +#define XCTR_BLOCKSIZE 16 Make it clear that this is talking about the current implementation, not XCTR itself. E.g.: /* For now this implementation is limited to 16-byte blocks for simplicity. */ #define XCTR_BLOCKSIZE 16 > +static int crypto_xctr_crypt_segment(struct skcipher_walk *walk, > + struct crypto_cipher *tfm, u32 byte_ctr) > +{ > + void (*fn)(struct crypto_tfm *, u8 *, const u8 *) = > + crypto_cipher_alg(tfm)->cia_encrypt; > + u8 *src = walk->src.virt.addr; > + u8 *dst = walk->dst.virt.addr; 'src' can be const. - Eric _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel