From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6C599C433F5 for ; Mon, 18 Apr 2022 18:06:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=D3OjLcV8AdmxFIbPu6pbnjOTISCVxczS3em3Xk3lftE=; b=1zZ93u9Z91Il2C 1fJ9BQkxDgAdVG9GU8YKBMY7NXSvtezHyueSKVTC0tTL6kCWC0vvhEnSjKJgg45OjeG3xmeXXxuDL RnhB1EYt/lMAxCeehvgvFpunWD7Z/2dMt5BTE5jSo2fvc/+aFiv1tcKxxyjHifQUliTJb7s2hPn5u 8k+gNDQ8U77RNJMe+uzs8vtufAnzwObWfbLa1jrQofek4gOLOqdtKVst/ht31Oi/LSJu+PzFApV1A owsRgSZ7j6GtwZYNQvaYrh9AJcsOlpPYiIxNLlol9OHzN2gEPgCyeNh1OgeTSoNXztUSTecj65LjE G3ewJxfAatLVpJQDbdsQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngVkX-000J8o-HH; Mon, 18 Apr 2022 18:05:21 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngVkU-000J8R-20 for linux-arm-kernel@lists.infradead.org; Mon, 18 Apr 2022 18:05:19 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 75A42B8104C; Mon, 18 Apr 2022 18:05:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F0DA2C385A1; Mon, 18 Apr 2022 18:05:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650305114; bh=iTh2BkOqbHJTxvKBcPXRBs8xRFkDQ76lvXa466UhJLw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aSU3BpucxT9Zzk/p5V77sXpgvetmRV+ga2HeRdb0/UF/ImvjiUK+HEFk6EU1aqXR/ NnVVC4ShHFVeLvDbdVDSN4Ln1qxnUKQsLL4z3BA2tFrPOq8WMLh6/w0jLJzA/NcX2S cVQPGgpJpAb86p/ogH85UdotB+kTfDehGBqGcQD8IgoGFds+1ZwXaugI4Aeqdj1VXg Kf9da3B6cz5U6+qLwTS2XrDZXDFAMjPIsn0aem0N7GLq0MdqcvIWQ5OBojkAswvIy8 anaXmVT7kSXXaTfSbGiVzTWOmxpKVzU+qTWQOjkTN4Bc+EPnMlt+O0/l1IoOonM0gH 2qICaLnnHsTag== Date: Mon, 18 Apr 2022 18:05:12 +0000 From: Eric Biggers To: Nathan Huckleberry Cc: linux-crypto@vger.kernel.org, Herbert Xu , "David S. Miller" , linux-arm-kernel@lists.infradead.org, Paul Crowley , Sami Tolvanen , Ard Biesheuvel Subject: Re: [PATCH v4 8/8] fscrypt: Add HCTR2 support for filename encryption Message-ID: References: <20220412172816.917723-1-nhuck@google.com> <20220412172816.917723-9-nhuck@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220412172816.917723-9-nhuck@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220418_110518_288633_97D3752C X-CRM114-Status: GOOD ( 12.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 12, 2022 at 05:28:16PM +0000, Nathan Huckleberry wrote: > diff --git a/fs/crypto/keysetup.c b/fs/crypto/keysetup.c > index eede186b04ce..ae24b581d3d7 100644 > --- a/fs/crypto/keysetup.c > +++ b/fs/crypto/keysetup.c > @@ -53,6 +53,13 @@ struct fscrypt_mode fscrypt_modes[] = { > .ivsize = 32, > .blk_crypto_mode = BLK_ENCRYPTION_MODE_ADIANTUM, > }, > + [FSCRYPT_MODE_AES_256_HCTR2] = { > + .friendly_name = "HCTR2", Can you use "AES-256-HCTR2" here instead of just "HCTR2"? This would be similar to how FSCRYPT_MODE_AES_256_XTS uses .friendly_name = "AES-256-XTS". - Eric _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel