From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A52BBC433EF for ; Fri, 8 Apr 2022 14:45:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LaBiDZaEpe29SiD9KbmjcBCVAwCBkNIpbluFSDqdRfE=; b=HT827svv4XNUpV 5fSGPR6rhsaihsZtU7TkNKH/XXrOzRW9n1enKEYDorAP2/fzRs/1L5nosSmTmbJLmv1LT88DT4RD/ t5VAeot1RCGSYWVJxdCaAqzzzGNau9WNCiiRA92qPO5rKMB3Nr3gjeFCUHdtSt4GBkjM67sJOGNxm aRdQtrWhMQLME5kBfYimioqU5ayzwpwERFwqBvMFjJ93/55eVwJ+oOEEXH/oL/NKSodWK9qQo3oH0 SrAmbGO3oFrB27qYRlE/qolV0soC17JOhh7ZvoTLofj3S0TpYg8lsZ6ZHNeBqCqzmLGhkR4Ma2k07 Z4mzlsM/5QhWRAitOPTg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ncpr0-0002vO-4z; Fri, 08 Apr 2022 14:44:50 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ncpqw-0002tc-Vs for linux-arm-kernel@lists.infradead.org; Fri, 08 Apr 2022 14:44:48 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E05B0113E; Fri, 8 Apr 2022 07:44:41 -0700 (PDT) Received: from lakrids (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5C0C63F73B; Fri, 8 Apr 2022 07:44:40 -0700 (PDT) Date: Fri, 8 Apr 2022 15:44:34 +0100 From: Mark Rutland To: "Madhavan T. Venkataraman" Cc: broonie@kernel.org, jpoimboe@redhat.com, ardb@kernel.org, nobuta.keiya@fujitsu.com, sjitindarsingh@gmail.com, catalin.marinas@arm.com, will@kernel.org, jmorris@namei.org, linux-arm-kernel@lists.infradead.org, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v13 06/11] arm64: Use stack_trace_consume_fn and rename args to unwind() Message-ID: References: <95691cae4f4504f33d0fc9075541b1e7deefe96f> <20220117145608.6781-1-madvenka@linux.microsoft.com> <20220117145608.6781-7-madvenka@linux.microsoft.com> <845e4589-97d9-5371-3a0e-f6e05919f32d@linux.microsoft.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <845e4589-97d9-5371-3a0e-f6e05919f32d@linux.microsoft.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220408_074447_106876_E1CDA564 X-CRM114-Status: GOOD ( 25.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Mar 07, 2022 at 10:51:38AM -0600, Madhavan T. Venkataraman wrote: > Hey Mark Rutland, Mark Brown, > > Could you please review the rest of the patches in the series when you can? Sorry, I was expecting a new version with some of my comments addressed, in case that had effects on subsequent patches. > Also, many of the patches have received a Reviewed-By from you both. > So, after I send the next version out, can we upstream those ones? I would very much like to upstream the ones I have given a Reviewed-by. Given those were conditional on some adjustments (e.g. actually filling out comments), do you mind if I pick those into a series now? Then, once that's picked, you can rebase the rest atop, and we can review that. Thanks, Mark. > On 2/15/22 07:39, Mark Rutland wrote: > > On Mon, Jan 17, 2022 at 08:56:03AM -0600, madvenka@linux.microsoft.com wrote: > >> From: "Madhavan T. Venkataraman" > >> > >> Rename the arguments to unwind() for better consistency. Also, use the > >> typedef stack_trace_consume_fn for the consume_entry function as it is > >> already defined in linux/stacktrace.h. > >> > >> Signed-off-by: Madhavan T. Venkataraman > > > > How about: > > > > | arm64: align with common stracktrace naming > > | > > | For historical reasons, the naming of parameters and their types in the arm64 > > | stacktrace code differs from that used in generic code and other > > | architectures, even though the types are equivalent. > > | > > | For consistency and clarity, use the generic names. > > > > Either way: > > > > Reviewed-by: Mark Rutland > > > > Mark. > > > >> --- > >> arch/arm64/kernel/stacktrace.c | 4 ++-- > >> 1 file changed, 2 insertions(+), 2 deletions(-) > >> > >> diff --git a/arch/arm64/kernel/stacktrace.c b/arch/arm64/kernel/stacktrace.c > >> index 1b32e55735aa..f772dac78b11 100644 > >> --- a/arch/arm64/kernel/stacktrace.c > >> +++ b/arch/arm64/kernel/stacktrace.c > >> @@ -181,12 +181,12 @@ static int notrace unwind_next(struct unwind_state *state) > >> NOKPROBE_SYMBOL(unwind_next); > >> > >> static void notrace unwind(struct unwind_state *state, > >> - bool (*fn)(void *, unsigned long), void *data) > >> + stack_trace_consume_fn consume_entry, void *cookie) > >> { > >> while (1) { > >> int ret; > >> > >> - if (!fn(data, state->pc)) > >> + if (!consume_entry(cookie, state->pc)) > >> break; > >> ret = unwind_next(state); > >> if (ret < 0) > >> -- > >> 2.25.1 > >> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel