From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (unknown [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1F57AC433F5 for ; Sat, 9 Apr 2022 15:46:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0KiOPPaOguKSh+vQYkWofEN4PgYLvJxBxUp+kuJXfm8=; b=qCEr24KMRFXbGj Ahj1ALjr57NJfElmhDR4g2XiUchV4Yl4fbxnl9s72yyYcyP3dwxpFbty38lgkQkFEK6rvj8dSi+QJ r/EFx2C45fLjXQyky95ttKTE+MqlDwSNqFfG4VIudFhrlNV4HyDU/r0J4R0RuxovrGTKY171G3S0m 5MwZ83+kRcvxTIHAQvp9UEFvG0mc5o5yroZAKGQdRPQJ/9FmnRVJwCX9G4TykazOiTuh1a9NsN7xu UvoMe4mXr5HdIrstQoQme+vT4+lDlY+qVqv2euo9o4m/j0sN1PdEJx6MXiC83bpn3EqA2PWMeVm11 NrSABTZ1rCxO6Nsa5/ig==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ndDGq-003RAV-Lm; Sat, 09 Apr 2022 15:45:04 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ndDGo-003RA1-1Q for linux-arm-kernel@bombadil.infradead.org; Sat, 09 Apr 2022 15:45:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=X9+0bB9SBVgYP95sgdpZfG+hpIv/Q9wbM8qPblQNhDo=; b=C2XtZ2fl2+kJmZqox+Eoh50SrK pdu7CQf1DuqVMl57KEWgRc/PFCP0/xHjsmlyn/J0750eNmuwSyxf7vuEJuG2r+Sc47K4O9qkacF/w bOiP07D64zj807BifL4FIpsg8PbSCQdNBSX3mTq1obCzLdTWDb8hphsWCyjMNWv2lLJlZDKUSTNsz mMfxZwcuN9pOCVOpyBh2Hu8eho0oI2kp4eeJdenKJ4w1yc3S1BGIfTUnj7RT+t1qSXpq6auy+hncr 6qIfB0aqLPaswZr+dIe2rPGZy3bS/HeWH/wA2/VG/YtTLqK3DfdAbtRUXGMv4snDXSM6UZeiEu6Tj aZwcualg==; Received: from [187.19.239.165] (helo=quaco.ghostprotocols.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1ndDGm-00AnHh-68; Sat, 09 Apr 2022 15:45:00 +0000 Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id C88AE40407; Sat, 9 Apr 2022 12:44:56 -0300 (-03) Date: Sat, 9 Apr 2022 12:44:56 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: John Garry , Will Deacon , Mathieu Poirier , Leo Yan , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , James Clark , Alexandre Truong , German Gomez , Dave Marchevsky , Song Liu , Ravi Bangoria , Li Huafei , Martin =?utf-8?B?TGnFoWth?= , William Cohen , Riccardo Mancini , Masami Hiramatsu , Thomas Richter , Lexi Shao , Remi Bernon , Michael Petlan , Denis Nikitin , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Stephane Eranian Subject: Re: [PATCH 1/5] perf annotate: Drop objdump stderr Message-ID: References: <20220407230503.1265036-1-irogers@google.com> <20220407230503.1265036-2-irogers@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220407230503.1265036-2-irogers@google.com> X-Url: http://acmel.wordpress.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Em Thu, Apr 07, 2022 at 04:04:59PM -0700, Ian Rogers escreveu: > If objdump writes to stderr it can block waiting for it to be read. As > perf doesn't read stderr then progress stops with perf waiting for > stdout output. Thanks, applied. - Arnaldo > Signed-off-by: Ian Rogers > --- > tools/perf/util/annotate.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c > index e4c641b240df..82cc396ef516 100644 > --- a/tools/perf/util/annotate.c > +++ b/tools/perf/util/annotate.c > @@ -2047,6 +2047,7 @@ static int symbol__disassemble(struct symbol *sym, struct annotate_args *args) > objdump_process.argv = objdump_argv; > objdump_process.out = -1; > objdump_process.err = -1; > + objdump_process.no_stderr = 1; > if (start_command(&objdump_process)) { > pr_err("Failure starting to run %s\n", command); > err = -1; > -- > 2.35.1.1178.g4f1659d476-goog -- - Arnaldo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel