From: Sasha Levin <sashal@kernel.org>
To: James Morse <james.morse@arm.com>
Cc: linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org,
Will Deacon <will@kernel.org>
Subject: Re: [stable:PATCH v5.4.188] KVM: arm64: Check arm64_get_bp_hardening_data() didn't return NULL
Date: Sat, 9 Apr 2022 12:10:50 -0400 [thread overview]
Message-ID: <YlGwCmQS6ud3Ezzx@sashalap> (raw)
In-Reply-To: <20220408172219.4152131-1-james.morse@arm.com>
On Fri, Apr 08, 2022 at 06:22:19PM +0100, James Morse wrote:
>Will reports that with CONFIG_EXPERT=y and CONFIG_HARDEN_BRANCH_PREDICTOR=n,
>the kernel dereferences a NULL pointer during boot:
>
>[ 2.384444] Internal error: Oops: 96000004 [#1] PREEMPT SMP
>[ 2.384461] pstate: 20400085 (nzCv daIf +PAN -UAO)
>[ 2.384472] pc : cpu_hyp_reinit+0x114/0x30c
>[ 2.384476] lr : cpu_hyp_reinit+0x80/0x30c
>
>[ 2.384529] Call trace:
>[ 2.384533] cpu_hyp_reinit+0x114/0x30c
>[ 2.384537] _kvm_arch_hardware_enable+0x30/0x54
>[ 2.384541] flush_smp_call_function_queue+0xe4/0x154
>[ 2.384544] generic_smp_call_function_single_interrupt+0x10/0x18
>[ 2.384549] ipi_handler+0x170/0x2b0
>[ 2.384555] handle_percpu_devid_fasteoi_ipi+0x120/0x1cc
>[ 2.384560] __handle_domain_irq+0x9c/0xf4
>[ 2.384563] gic_handle_irq+0x6c/0xe4
>[ 2.384566] el1_irq+0xf0/0x1c0
>[ 2.384570] arch_cpu_idle+0x28/0x44
>[ 2.384574] do_idle+0x100/0x2a8
>[ 2.384577] cpu_startup_entry+0x20/0x24
>[ 2.384581] secondary_start_kernel+0x1b0/0x1cc
>[ 2.384589] Code: b9469d08 7100011f 540003ad 52800208 (f9400108)
>[ 2.384600] ---[ end trace 266d08dbf96ff143 ]---
>[ 2.385171] Kernel panic - not syncing: Fatal exception in interrupt
>
>In this configuration arm64_get_bp_hardening_data() returns NULL.
>Add a check in kvm_get_hyp_vector().
>
>Cc: Will Deacon <will@kernel.org>
>Link: https://lore.kernel.org/linux-arm-kernel/20220408120041.GB27685@willie-the-truck/
>Fixes: 26129ea2953b ("KVM: arm64: Add templates for BHB mitigation sequences")
>Cc: stable@vger.kernel.org # 5.4.x
>Signed-off-by: James Morse <james.morse@arm.com>
Queued up this and the 4.19 one, thanks!
--
Thanks,
Sasha
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-04-09 16:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-08 17:22 [stable:PATCH v5.4.188] KVM: arm64: Check arm64_get_bp_hardening_data() didn't return NULL James Morse
2022-04-09 16:10 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YlGwCmQS6ud3Ezzx@sashalap \
--to=sashal@kernel.org \
--cc=james.morse@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=stable@vger.kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox