From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (unknown [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D59C5C433F5 for ; Sat, 9 Apr 2022 20:40:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rGgqNZWYz7eA4pjuxMHhPsDREcZNixFLhK+F1yCisK8=; b=QOjHSrnskWjawR 0gaH5UzBE8s9gW7tHMBZtAROSfEsrMgY6zOSq2Jzcvteqi3arjyGXYV2/LEoEeNkI4llWoa4UtDQ9 BqqgCwpTHQmusBYhMG6g4n1I3/wLiFay5xZVu4FZqrTBiea6RzuaiEtO4st0BItg90Ttfr4N2VkxY hR8FyBPvCVcs8ERyHUpnDz2PWwKPvayBxrC7CQk1aYo3K2jErye/qebKob+jiC4WwHBtE2/XB5aNs k2ZGDEC+z+bZDklPqV/wkx/kqTUDKGXhdLuG9muwaRXn/pDJrsst4PFEkKviO8/ZJtspozcAeGEoD s8BtLxYm2uORigiayGww==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ndHok-003lwR-BY; Sat, 09 Apr 2022 20:36:22 +0000 Received: from mail-pf1-x431.google.com ([2607:f8b0:4864:20::431]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ndHof-003lw1-9Y for linux-arm-kernel@lists.infradead.org; Sat, 09 Apr 2022 20:36:20 +0000 Received: by mail-pf1-x431.google.com with SMTP id a42so4776525pfx.7 for ; Sat, 09 Apr 2022 13:36:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ToaemIh0N/ictNMTY6+8rwYpqhr7q8UZjVORvPQt/1Y=; b=VrFx9bSfQ+cfWs6cBGHXR9DrCWbguRAu9pGUcToAoFl0OMrWqmJrS4UZ8HJrm1XmlA ON6bJiMXpSqwUItF6z5n1hBhNbWDRowvH/6ptVky3daXm/LYeOUiLh9B/kmy52D/tDaQ mNlpDgQNKap2oxboEiwlJZW+uUqOQl13LxJclL2yUwQ/Q4dbHeUn7crvm8cNtb0pCJgN RLO7nskSGcQIbgp9QjWq7akVn3HeobMjuCoG9VJkZ7UBfmLj4VnQ1kCoZ6Ec4FI7NPxc JIYY8AF+i9HLJkdXfbfYR0bSwEEmW9Cz7Ca7opz7Q/mYdsMbL+/C6JNXYStCUjBzGZ9d A65w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ToaemIh0N/ictNMTY6+8rwYpqhr7q8UZjVORvPQt/1Y=; b=bF1SVX56UDgNtfINP1n96uoj4oGy9FW7skZNYG3sIFwyW5kmCjo8zvyZu2o0gK+dsC zeR+e32NbukAFU4xrSf7jM5VyCvI/wqbpfgj12lGGMusVPj4XE+IBYsaSG9wp1m0/m2n br45UN4r18TEprOb4LjqBtHQ3MiN9GdI+xMgiY/OHQVmIpWRWds+/ikbkg+VtleCn7FC 9y+5/hjjDOuWIKj0k59l+EanRX/SXUJR2oQ5BaXN1qbkm7g+0WVLCAVYNcJdr0axX6M9 Fi+9OEXuTvgLMIdLySbyi54d4VOoEdOaN5hkcLK/EzKiucdXSgNGbJZJWIc0mnSgwWjl EcMg== X-Gm-Message-State: AOAM531Gsvp2xUSxSjgHeJBct7SZr9ahQz17ocRJYlfkyCUp5oznvZZ0 iQkS7NwN3yQ5B3Fex8qzG9HgbA== X-Google-Smtp-Source: ABdhPJw/rmDw7bqHCMDpzikztX0oH3Td8uC+JRWeVwaLpimkoupGZubMwy2iGBHTimSdAcvPSSyFzQ== X-Received: by 2002:a62:6dc3:0:b0:505:895a:d38b with SMTP id i186-20020a626dc3000000b00505895ad38bmr9336064pfc.7.1649536575239; Sat, 09 Apr 2022 13:36:15 -0700 (PDT) Received: from x1 ([2601:1c2:1001:7090:925c:1a60:e433:31b7]) by smtp.gmail.com with ESMTPSA id x17-20020a17090ab01100b001ca8458964esm15629780pjq.18.2022.04.09.13.36.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 Apr 2022 13:36:14 -0700 (PDT) Date: Sat, 9 Apr 2022 13:37:01 -0700 From: Drew Fustini To: Krzysztof Kozlowski Cc: Rob Herring , Krzysztof Kozlowski , Nishanth Menon , Santosh Shilimkar , Dave Gerlach , Tony Lindgren , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] dt-bindings: wkup-m3-ipc: Add vtt toggle bindings Message-ID: References: <20220409045145.2434096-1-dfustini@baylibre.com> <20220409045145.2434096-2-dfustini@baylibre.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220409_133617_560796_FE29AC04 X-CRM114-Status: GOOD ( 16.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Apr 09, 2022 at 06:25:24PM +0200, Krzysztof Kozlowski wrote: > On 09/04/2022 06:51, Drew Fustini wrote: > > Document the Wakeup M3 IPC properties that can be used to toggle the VTT > > regulator during low power mode transitions. > > > > (...) > > > @@ -51,6 +61,15 @@ properties: > > mbox_wkupm3 child node. > > maxItems: 1 > > > > + ti,needs-vtt-toggle: > > + type: boolean > > + description: boards requires VTT toggling during suspend/resume > > + > > + ti,vtt-gpio-pin: > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + description: pin on the GPIO0 module used for VTT toggle > > + maxItems: 1 > > No need for maxItems, it's a single uint32. You could add "maximum" if > you know the constraints for the value. Thank you for letting me know. > Do you actually need two properties (bool + pin)? A case of > "ti,vtt-gpio-pin" without the "ti,needs-vtt-toggle" is valid? You raise a good point. In fact, the driver does nothing useful in the case of "ti,needs-vtt-toggle" without "ti,vtt-gpio-pin". Therefore, I will remove the "ti,needs-vtt-toggle" property. > > The other way looks wrong, so you need to add a dependency (see > example-schema). > > > Best regards, > Krzysztof Thank you, Drew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel