From: Vinod Koul <vkoul@kernel.org>
To: Kevin Groeneveld <kgroeneveld@lenbrook.com>,
"Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Lucas Stach <l.stach@pengutronix.de>,
Robin Gong <yibin.gong@nxp.com>,
dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dmaengine: imx-sdma: fix regression with uart scripts
Date: Mon, 11 Apr 2022 11:29:23 +0530 [thread overview]
Message-ID: <YlPDu3lu0rHJztNQ@matsya> (raw)
In-Reply-To: <3b26a4e2-93a8-8b3f-20c3-c1593ea0d48b@lenbrook.com>
Hi Kevin,
On 10-04-22, 18:28, Kevin Groeneveld wrote:
> On 2022-04-08 13:39, Vinod Koul wrote:
> > 1. Patch title should reflect the change introduced, so the title is not
> > apt, pls revise
>
> In hindsight the title was not very descriptive. I will update and send a
> v2. Maybe something like:
>
> dmaengine: imx-sdma: fix init of uart scripts
>
> > 2. Is this in response to rmk's report, if so, please add reported-by
>
> No. I am not even aware of any report on this issue. I discovered the issue
> on my own and found the problem commit by doing a bisect.
Okay I am adding Russell here to see if this fixes his issue as well..
> > 3. Lastly, I would like to see some tested by for this patch..
>
> I have tested on imx5, imx6 and imx8 systems. I will add some brief details
> of this to the commit message in the v2 patch. I am not sure if I as the
> author should include a Tested-by tag.
>
> > > Fixes: b98ce2f4e32b ("dmaengine: imx-sdma: add uart rom script")
> >
> > cc: stable ?
>
> That sounds reasonable. I am relatively new to submitting kernel patches and
> that thought never crossed by mind.
No worries, fixes should be backport to stable kernels, refer Documentation/process/stable-kernel-rules.rst
Thanks
--
~Vinod
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-04-11 6:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-06 22:48 [PATCH] dmaengine: imx-sdma: fix regression with uart scripts Kevin Groeneveld
2022-04-07 10:18 ` Lucas Stach
2022-04-08 1:23 ` Fabio Estevam
2022-04-08 17:39 ` Vinod Koul
2022-04-10 22:28 ` Kevin Groeneveld
2022-04-11 5:59 ` Vinod Koul [this message]
2022-04-11 7:16 ` Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YlPDu3lu0rHJztNQ@matsya \
--to=vkoul@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kgroeneveld@lenbrook.com \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=yibin.gong@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).