From: Vinod Koul <vkoul@kernel.org>
To: cgel.zte@gmail.com
Cc: sean.wang@mediatek.com, matthias.bgg@gmail.com,
dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
Minghao Chi <chi.minghao@zte.com.cn>,
Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH] drivers: dma: using pm_runtime_resume_and_get instead of pm_runtime_get_sync
Date: Mon, 11 Apr 2022 16:20:37 +0530 [thread overview]
Message-ID: <YlQH/WjgLgD5uVsP@matsya> (raw)
In-Reply-To: <20220411013504.2517012-1-chi.minghao@zte.com.cn>
On 11-04-22, 01:35, cgel.zte@gmail.com wrote:
> From: Minghao Chi <chi.minghao@zte.com.cn>
subsystem tag is wrong, pls see gitlog to find the appropriate one
>
> Using pm_runtime_resume_and_get is more appropriate
> for simplifing code
Can you explain why it is appropriate?
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
> ---
> drivers/dma/mediatek/mtk-uart-apdma.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/dma/mediatek/mtk-uart-apdma.c b/drivers/dma/mediatek/mtk-uart-apdma.c
> index 375e7e647df6..64bad5681447 100644
> --- a/drivers/dma/mediatek/mtk-uart-apdma.c
> +++ b/drivers/dma/mediatek/mtk-uart-apdma.c
> @@ -274,11 +274,9 @@ static int mtk_uart_apdma_alloc_chan_resources(struct dma_chan *chan)
> unsigned int status;
> int ret;
>
> - ret = pm_runtime_get_sync(mtkd->ddev.dev);
> - if (ret < 0) {
> - pm_runtime_put_noidle(chan->device->dev);
> + ret = pm_runtime_resume_and_get(mtkd->ddev.dev);
> + if (ret < 0)
> return ret;
> - }
>
> mtk_uart_apdma_write(c, VFF_ADDR, 0);
> mtk_uart_apdma_write(c, VFF_THRE, 0);
> --
> 2.25.1
--
~Vinod
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-04-11 10:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-11 1:35 [PATCH] drivers: dma: using pm_runtime_resume_and_get instead of pm_runtime_get_sync cgel.zte
2022-04-11 10:50 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YlQH/WjgLgD5uVsP@matsya \
--to=vkoul@kernel.org \
--cc=cgel.zte@gmail.com \
--cc=chi.minghao@zte.com.cn \
--cc=dmaengine@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=sean.wang@mediatek.com \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox