From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 40196C433EF for ; Tue, 12 Apr 2022 10:15:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=q5uApbLlzvCg87DxCMFp0+YNQ+gTeK/AhE3PVLZ5WS8=; b=KxTQ9cJmTJJLN6 rsuww3Py0TltVCGWr8xmCRLe2UtYjKD6Inx28JDVsIFlCG+jSxzczBJCscUV7fGXH0Bm5IAitZQgT K6F8nCtDBRNw20KNw856MewRZRUk5LbnHrUu47ksVz3YFcw7NOlBbOkPeCuPKExrr1NuhAwQHYYb9 8m3Am57Bo88KC/agnI5mUAP0as/9EcGFjKORPqvB73+n2FI5Gs7TfcxShpZ7P23IKSw463gUsBSir fsDTexW8FkIs9xBd6jpk0r1znePuMPy4+YEpWIW5ibLBCPWqGI1WoyI/DhvmaiHbS3UGNC4Xo66jO ksYmVI4pJu/EDWKpKuVA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1neDXg-00DD6g-1D; Tue, 12 Apr 2022 10:14:36 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1neDXc-00DD4r-5I for linux-arm-kernel@lists.infradead.org; Tue, 12 Apr 2022 10:14:33 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 914441570; Tue, 12 Apr 2022 03:14:28 -0700 (PDT) Received: from FVFF77S0Q05N (unknown [10.57.73.254]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 73E983F5A1; Tue, 12 Apr 2022 03:14:27 -0700 (PDT) Date: Tue, 12 Apr 2022 11:14:19 +0100 From: Mark Rutland To: Rob Herring , Will Deacon Cc: Al Grant , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm_pmu: Validate single/group leader events Message-ID: References: <20220408203330.4014015-1-robh@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220412_031432_284074_74C9A8D2 X-CRM114-Status: GOOD ( 18.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Apr 11, 2022 at 09:14:03AM -0500, Rob Herring wrote: > On Mon, Apr 11, 2022 at 11:04:26AM +0100, Mark Rutland wrote: > > Hi Rob, > > > > On Fri, Apr 08, 2022 at 03:33:30PM -0500, Rob Herring wrote: > > > In the case where there is only a cycle counter available (i.e. > > > PMCR_EL0.N is 0) and an event other than CPU cycles is opened, the open > > > should fail as the event can never possibly be scheduled. However, the > > > event validation when an event is opened is skipped when the group > > > leader is opened. Fix this by always validating the group leader events. > > > > > > Reported-by: Al Grant > > > Cc: Will Deacon > > > Cc: Mark Rutland > > > Signed-off-by: Rob Herring > > > > This looks obviously correct to me, so FWIW: > > > > Acked-by: Mark Rutland > > Thanks. > > > Just to check, have you tested this (e.g. by running on a platform with > > PMCR_EL0.N == 0, or hacking the PMU probing to report just the cycle counter) > > Yes, tested on FVP with 0 counters running the libperf evsel userspace > access tests as that tries both the cycle counter and instruction > counts. Perfect, thanks! Will, I assume that you'll pick this up. Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel