From: Rob Herring <robh@kernel.org>
To: Samuel Holland <samuel@sholland.org>
Cc: Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Maxime Ripard <mripard@kernel.org>,
Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH v2 02/14] dt-bindings: display: Add D1 display engine compatibles
Date: Tue, 12 Apr 2022 16:08:59 -0500 [thread overview]
Message-ID: <YlXqa5YH7ckHCf1m@robh.at.kernel.org> (raw)
In-Reply-To: <20220412042807.47519-3-samuel@sholland.org>
On Mon, Apr 11, 2022 at 11:27:54PM -0500, Samuel Holland wrote:
> Allwinner D1 contains a display engine 2.0. It features two mixers, a
> TCON TOP (with DSI and HDMI), one TCON LCD, and one TCON TV.
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Samuel Holland <samuel@sholland.org>
> ---
>
> (no changes since v1)
>
> .../allwinner,sun4i-a10-display-engine.yaml | 1 +
> .../display/allwinner,sun4i-a10-tcon.yaml | 2 ++
> .../allwinner,sun8i-a83t-de2-mixer.yaml | 2 ++
> .../display/allwinner,sun8i-r40-tcon-top.yaml | 34 +++++++++++++++++++
> 4 files changed, 39 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-display-engine.yaml b/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-display-engine.yaml
> index d4412aea7b73..c388ae5da1e4 100644
> --- a/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-display-engine.yaml
> +++ b/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-display-engine.yaml
> @@ -62,6 +62,7 @@ properties:
> - allwinner,sun8i-r40-display-engine
> - allwinner,sun8i-v3s-display-engine
> - allwinner,sun9i-a80-display-engine
> + - allwinner,sun20i-d1-display-engine
> - allwinner,sun50i-a64-display-engine
> - allwinner,sun50i-h6-display-engine
>
> diff --git a/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tcon.yaml b/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tcon.yaml
> index 3a7d5d731712..4a92a4c7dcd7 100644
> --- a/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tcon.yaml
> +++ b/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tcon.yaml
> @@ -33,6 +33,8 @@ properties:
> - const: allwinner,sun8i-v3s-tcon
> - const: allwinner,sun9i-a80-tcon-lcd
> - const: allwinner,sun9i-a80-tcon-tv
> + - const: allwinner,sun20i-d1-tcon-lcd
> + - const: allwinner,sun20i-d1-tcon-tv
>
> - items:
> - enum:
> diff --git a/Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-de2-mixer.yaml b/Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-de2-mixer.yaml
> index 4f91eec26de9..cb243bc58ef7 100644
> --- a/Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-de2-mixer.yaml
> +++ b/Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-de2-mixer.yaml
> @@ -19,6 +19,8 @@ properties:
> - allwinner,sun8i-r40-de2-mixer-0
> - allwinner,sun8i-r40-de2-mixer-1
> - allwinner,sun8i-v3s-de2-mixer
> + - allwinner,sun20i-d1-de2-mixer-0
> + - allwinner,sun20i-d1-de2-mixer-1
> - allwinner,sun50i-a64-de2-mixer-0
> - allwinner,sun50i-a64-de2-mixer-1
> - allwinner,sun50i-h6-de3-mixer-0
> diff --git a/Documentation/devicetree/bindings/display/allwinner,sun8i-r40-tcon-top.yaml b/Documentation/devicetree/bindings/display/allwinner,sun8i-r40-tcon-top.yaml
> index 784b267635fb..cc32e2faed91 100644
> --- a/Documentation/devicetree/bindings/display/allwinner,sun8i-r40-tcon-top.yaml
> +++ b/Documentation/devicetree/bindings/display/allwinner,sun8i-r40-tcon-top.yaml
> @@ -41,6 +41,7 @@ properties:
> compatible:
> enum:
> - allwinner,sun8i-r40-tcon-top
> + - allwinner,sun20i-d1-tcon-top
> - allwinner,sun50i-h6-tcon-top
>
> reg:
> @@ -154,6 +155,39 @@ allOf:
> - port@2
> - port@3
>
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: allwinner,sun20i-d1-tcon-top
> +
> + then:
> + properties:
> + clocks:
> + minItems: 4
> + maxItems: 4
You shouldn't need minItems and maxItems here and the next 2 cases.
> + items:
> + - description: The TCON TOP interface clock
> + - description: The TCON TOP TV0 clock
> + - description: The TCON TOP TVE0 clock
> + - description: The TCON TOP MIPI DSI clock
> +
> + clock-names:
> + minItems: 4
> + maxItems: 4
> + items:
> + - const: bus
> + - const: tcon-tv0
> + - const: tve0
> + - const: dsi
> +
> + clock-output-names:
> + minItems: 2
> + maxItems: 2
> + items:
> + - description: TCON TV0 output clock name
> + - description: DSI output clock name
> +
> - if:
> properties:
> compatible:
> --
> 2.35.1
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-04-12 21:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-12 4:27 [PATCH v2 00/14] drm/sun4i: Allwinner D1 Display Engine 2.0 Support Samuel Holland
2022-04-12 4:27 ` [PATCH v2 01/14] dt-bindings: display: Separate clock item lists by compatible Samuel Holland
2022-04-12 4:27 ` [PATCH v2 02/14] dt-bindings: display: Add D1 display engine compatibles Samuel Holland
2022-04-12 21:08 ` Rob Herring [this message]
2022-04-12 4:27 ` [PATCH v2 03/14] drm/sun4i: Remove obsolete references to PHYS_OFFSET Samuel Holland
2022-04-12 4:27 ` [PATCH v2 04/14] drm/sun4i: hdmi: Use more portable I/O helpers Samuel Holland
2022-04-12 4:27 ` [PATCH v2 05/14] drm/sun4i: Allow building the driver on RISC-V Samuel Holland
2022-04-12 4:27 ` [PATCH v2 06/14] sun4i/drm: engine: Add mode_set callback Samuel Holland
2022-04-12 4:27 ` [PATCH v2 07/14] sun4i/drm: backend: use mode_set engine callback Samuel Holland
2022-04-12 4:28 ` [PATCH v2 08/14] sun4i/drm: sun8i: " Samuel Holland
2022-04-12 4:28 ` [PATCH v2 09/14] drm/sun4i: Allow VI layers to be primary planes Samuel Holland
2022-04-12 4:28 ` [PATCH v2 10/14] drm/sun4i: csc: Add support for the new MMIO layout Samuel Holland
2022-04-12 4:28 ` [PATCH v2 11/14] drm/sun4i: Add support for D1 mixers Samuel Holland
2022-04-12 4:28 ` [PATCH v2 12/14] drm/sun4i: Add support for D1 TCON TOP Samuel Holland
2022-04-12 4:28 ` [PATCH v2 13/14] drm/sun4i: Add support for D1 TCONs Samuel Holland
2022-04-12 4:28 ` [PATCH v2 14/14] drm/sun4i: Add compatible for D1 display engine Samuel Holland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YlXqa5YH7ckHCf1m@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=mripard@kernel.org \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).