From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EC5FAC433F5 for ; Wed, 13 Apr 2022 16:13:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=w0Fq5K3H+hlxQAkmBpY0IlqjLMWQsZJXeeWymAtalRY=; b=Kkh/6RvcmEce5K xXXJJcOs6yKmiRq7eHBVILtFGaGCrZL1lj/CazrZliIeTgaQHLr5/7T9Qn2YXSV8WA0FJChb1r7+c KKJgx2c8B2O4QPlzRnx8AuT3k+jtqqCFLYka47tYvaEYENJSxHYKuF4sumAAS0f5ey5J+SNY3OrFg HLpPwJ+mRYCLbvAX3y6efJpnD0PoxDs+/MFHc1kmRBYEAipj5KbHkDBNGQutAPpvdh2Q19KXSZMDy lg/+jBCOvk4r26RlTwhdSdg8QN6t7bIpF6S9chdE9EcbZ77q0q9ouBauiNyQmDzbVZFbqk+TrzyWR WokXZJzYs8AmcOqZ9OfA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nefbJ-001igr-6s; Wed, 13 Apr 2022 16:12:13 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nefbF-001ifw-Hx for linux-arm-kernel@lists.infradead.org; Wed, 13 Apr 2022 16:12:11 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E3C6C1576; Wed, 13 Apr 2022 09:11:58 -0700 (PDT) Received: from FVFF77S0Q05N (unknown [10.57.75.153]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CDAC93F5A1; Wed, 13 Apr 2022 09:11:57 -0700 (PDT) Date: Wed, 13 Apr 2022 17:11:47 +0100 From: Mark Rutland To: Mark Brown Cc: linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, kaleshsingh@google.com, madvenka@linux.microsoft.com, will@kernel.org Subject: Re: [PATCH 2/6] arm64: stacktrace: delete PCS comment Message-ID: References: <20220413145910.3060139-1-mark.rutland@arm.com> <20220413145910.3060139-3-mark.rutland@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220413_091209_674656_30F59047 X-CRM114-Status: GOOD ( 15.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Apr 13, 2022 at 04:59:14PM +0100, Mark Brown wrote: > On Wed, Apr 13, 2022 at 03:59:06PM +0100, Mark Rutland wrote: > > The comment at the top of stacktrace.c isn't all that helpful, as it's > > not associated with the code which inspects the frame record, and the > > code example isn't representative of common code generation today. > > Reviewed-by: Mark Brown > > though I do wonder if it might be better to rather than remove it expand > it to be a bit of an essay on what actually happens these days, that > could be better placed in Documentation/ though. FWIW, I want to add a Documentation/arm64/unwinding.{whatever} to give links to the relevant documentation (e.g. the AAPCS64 docs) and to explain the arm64-specific unwinding concerns, but I haven't had the chance to write that yet. Either way I'd like to remove this comment since it's both misplaced and misleading, so thanks for the Reviewed-by tag! Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel