public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: Nathan Chancellor <nathan@kernel.org>
To: Will Deacon <will@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com,
	keescook@chromium.org, ardb@kernel.org
Subject: Re: allmodconfig builds failing to link on arm64
Date: Wed, 13 Apr 2022 08:04:46 -0700	[thread overview]
Message-ID: <YlbmjjJl4fuSAJDW@dev-arch.thelio-3990X> (raw)
In-Reply-To: <20220413092614.GD745@willie-the-truck>

On Wed, Apr 13, 2022 at 10:26:14AM +0100, Will Deacon wrote:
> Hi Nathan,
> 
> On Fri, Apr 08, 2022 at 11:37:24AM -0700, Nathan Chancellor wrote:
> > On Fri, Apr 08, 2022 at 10:17:21AM -0700, Nathan Chancellor wrote:
> > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> > index 57c4c995965f..1fd16faa7f31 100644
> > --- a/arch/arm64/Kconfig
> > +++ b/arch/arm64/Kconfig
> > @@ -175,8 +175,6 @@ config ARM64
> >  	select HAVE_DEBUG_KMEMLEAK
> >  	select HAVE_DMA_CONTIGUOUS
> >  	select HAVE_DYNAMIC_FTRACE
> > -	select HAVE_DYNAMIC_FTRACE_WITH_REGS \
> > -		if $(cc-option,-fpatchable-function-entry=2)
> >  	select FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY \
> >  		if DYNAMIC_FTRACE_WITH_REGS
> >  	select HAVE_EFFICIENT_UNALIGNED_ACCESS
> > @@ -228,6 +226,17 @@ config ARM64
> >  	help
> >  	  ARM 64-bit (AArch64) Linux support.
> >  
> > +config CLANG_SUPPORTS_DYNAMIC_FTRACE_WITH_REGS
> > +	def_bool CC_IS_CLANG
> > +	# https://github.com/ClangBuiltLinux/linux/issues/1507
> > +	depends on AS_IS_GNU || (AS_IS_LLVM && (LD_IS_LLD || LD_VERSION >= 23600))
> > +	select HAVE_DYNAMIC_FTRACE_WITH_REGS
> > +
> > +config GCC_SUPPORTS_DYNAMIC_FTRACE_WITH_REGS
> > +	def_bool CC_IS_GCC
> > +	depends on $(cc-option,-fpatchable-function-entry=2)
> > +	select HAVE_DYNAMIC_FTRACE_WITH_REGS
> > +
> >  config 64BIT
> >  	def_bool y
> 
> FWIW, I can confirm that this fixes the problem for me:
> 
> Tested-by: Will Deacon <will@kernel.org.
> 
> Do you plan to post as a separate patch?

Yes, I will go ahead and type up a proper commit message and ship it
along shortly, thanks for the feedback!

Cheers,
Nathan

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

      reply	other threads:[~2022-04-13 15:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-08 11:54 allmodconfig builds failing to link on arm64 Will Deacon
2022-04-08 14:45 ` Mark Rutland
2022-04-08 15:04   ` Nathan Chancellor
2022-04-08 15:06   ` Mark Rutland
2022-04-08 16:13     ` Will Deacon
2022-04-08 17:17       ` Nathan Chancellor
2022-04-08 18:37         ` Nathan Chancellor
2022-04-13  9:26           ` Will Deacon
2022-04-13 15:04             ` Nathan Chancellor [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YlbmjjJl4fuSAJDW@dev-arch.thelio-3990X \
    --to=nathan@kernel.org \
    --cc=ardb@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=keescook@chromium.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox