From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3D4AAC433F5 for ; Thu, 14 Apr 2022 07:13:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5ooArwGY8cOmofMx7XQIXvtcwGbmP2hlWkals9+11Po=; b=WXJZwwQzFcGWc/ 1uQtKNKC4SUUTkA+vO2Yyw/HE6l370ZR236wiXoztP4Jg7Vd4PV8ii/9ZF/nuVBOQIFgJZ4Z5nVyM ISVHoeoDCu37tSyRPbb0Oy3hTSDvkJIfenAtWcQqUaVh32aFyF/FNcZcom+t3NO7sMEV2+7SwSlzU IUVJ7NY7Y7/AIyFJSX23UtPBAAQ0TCukH4sUt70xTbJCmSP7IjVDdp+n97SBdcz26j9fNRWDEWk/H 75NdYaUTYskri4B74FkLfaNVwckEKgu2Bwvz/a/X70vY1jmTcHtLQX+k6OekXd8+M6zqB+3BDS3Q2 ed3PkrsSVpnW72rj2W9w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1netek-004HZO-Su; Thu, 14 Apr 2022 07:12:43 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1neteh-004HXp-1h for linux-arm-kernel@lists.infradead.org; Thu, 14 Apr 2022 07:12:40 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8DE1661F09; Thu, 14 Apr 2022 07:12:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BA511C385A1; Thu, 14 Apr 2022 07:12:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1649920358; bh=mHsm/KVIiiqXAvfxFBibENJBp14StG55eEmV6KtUU7o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VOZnuUFhKPSG33bI3VShr4M7GGUXjhPtFcKaX6fdpUM0+pbESSV0nv79FmYd9II0+ LxxOvtdEbvd5azyjv+nlzHf/H09ZyHWKloKyWfhUt9ZSW3bkHYdI0/vJH6zSBT5CXO CHyMP0BMz/pnE8mnb08mGRnkn4eMURGFCmGn8+WU9VBCsQp5BzLfyMcu3bl5K+1Wdq QFABvBtrL1nBgS/bfJ+Jto2HclppSzw3FAXVqcw+vOOj1bgcZ0dXTwd1cjRGRfQG3K +88O9MJjcB0NNxBcY87iTY0ZD093f2hub2jCycHl+y+vECZ8ECyrflr3nCNuDCxcyN K4Lm0+EaTUBGg== Date: Thu, 14 Apr 2022 00:12:35 -0700 From: Eric Biggers To: Ard Biesheuvel Cc: Nathan Huckleberry , Linux Crypto Mailing List , Herbert Xu , "David S. Miller" , Linux ARM , Paul Crowley , Sami Tolvanen Subject: Re: [PATCH v4 8/8] fscrypt: Add HCTR2 support for filename encryption Message-ID: References: <20220412172816.917723-1-nhuck@google.com> <20220412172816.917723-9-nhuck@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220414_001239_233834_1A974373 X-CRM114-Status: GOOD ( 18.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Apr 13, 2022 at 08:16:25AM +0200, Ard Biesheuvel wrote: > > > diff --git a/tools/include/uapi/linux/fscrypt.h b/tools/include/uapi/linux/fscrypt.h > > > index 9f4428be3e36..a756b29afcc2 100644 > > > --- a/tools/include/uapi/linux/fscrypt.h > > > +++ b/tools/include/uapi/linux/fscrypt.h > > > @@ -27,7 +27,8 @@ > > > #define FSCRYPT_MODE_AES_128_CBC 5 > > > #define FSCRYPT_MODE_AES_128_CTS 6 > > > #define FSCRYPT_MODE_ADIANTUM 9 > > > -/* If adding a mode number > 9, update FSCRYPT_MODE_MAX in fscrypt_private.h */ > > > +#define FSCRYPT_MODE_AES_256_HCTR2 10 > > > +/* If adding a mode number > 10, update FSCRYPT_MODE_MAX in fscrypt_private.h */ > > > > > > > As far as I know, you don't actually need to update the copy of UAPI headers in > > tools/. The people who maintain those files handle that. It doesn't make sense > > to have copies of files in the source tree anyway. > > > > Doesn't the x86 build emit a warning if these go out of sync? The warning is emitted when building tools/perf/, not the kernel itself. According to https://lore.kernel.org/r/20191001185741.GD13904@kernel.org, the perf maintainers actually prefer that their files are *not* updated for them. And I'd like to push back against having duplicate source files in the tree anyway, for obvious reasons. So I think we shouldn't update this file. - Eric _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel