From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B8423C433EF for ; Sun, 17 Apr 2022 16:31:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7o5PG7bGSY5Ckq6M+Y7aAXWSdvbwKm4tHYJfpfnMlLI=; b=3iMs1DR4AX7S/u aPg0QRL7BbAOPLWn7KbNjSsjzD4mojcI7oRqPS++VNXP1y7NIIkaEyHb9EC5sPNijVXSdnn/9VC9P 6C9i/s7VGRAZD8km/ulraabZEhD0dLOsZycCTLek1VwxipYzY4gB+KaH7eWcNQnT9xcAVNgLhbXeF Nxx0o3OuqYMQsWnE9CuQ3e4TEVgf7u8RwYH0tr9Y/cD74sZMCaoZUFqcmuX5MREGgkrgriU1Z2NAV sF3XnoGe7n3Z/yBHdJLOp1j74lDdwJL2+gMqOOps+Be/5O5eaQ1MvMBrAMk/jsKf75hVBRJxZn0aF SA+XM6L9MbSY+Wr/FkZQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ng7nQ-00Eail-SA; Sun, 17 Apr 2022 16:30:44 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ng7nG-00Eafr-KY for linux-arm-kernel@lists.infradead.org; Sun, 17 Apr 2022 16:30:37 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6943061236; Sun, 17 Apr 2022 16:30:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B171CC385A4; Sun, 17 Apr 2022 16:30:30 +0000 (UTC) Date: Sun, 17 Apr 2022 17:30:27 +0100 From: Catalin Marinas To: Herbert Xu Cc: Ard Biesheuvel , Will Deacon , Marc Zyngier , Arnd Bergmann , Greg Kroah-Hartman , Andrew Morton , Linus Torvalds , Linux Memory Management List , Linux ARM , Linux Kernel Mailing List , "David S. Miller" Subject: Re: [PATCH 07/10] crypto: Use ARCH_DMA_MINALIGN instead of ARCH_KMALLOC_MINALIGN Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220417_093034_868577_ADC24649 X-CRM114-Status: GOOD ( 20.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Apr 17, 2022 at 04:58:29PM +0800, Herbert Xu wrote: > On Sun, Apr 17, 2022 at 09:50:50AM +0100, Catalin Marinas wrote: > > > > Right, if that's what you prefer. Something like: > > > > diff --git a/include/linux/crypto.h b/include/linux/crypto.h > > index 2324ab6f1846..bb645b2f2718 100644 > > --- a/include/linux/crypto.h > > +++ b/include/linux/crypto.h > > @@ -645,7 +645,7 @@ struct crypto_tfm { > > > > struct crypto_alg *__crt_alg; > > > > - void *__crt_ctx[] CRYPTO_MINALIGN_ATTR; > > + void *__crt_ctx[] __aligned(ARCH_DMA_MINALIGN); > > }; > > > > But once we do that, are there any other CRYPTO_MINALIGN left around? > > This is still implying the whole structure is aligned to the given > value, which it is not. > > Please just add the padding as needed. Do you mean as per Ard's proposal here: https://lore.kernel.org/r/CAMj1kXH0x5Va7Wgs+mU1ONDwwsazOBuN4z4ihVzO2uG-n41Kbg@mail.gmail.com struct crypto_request { union { struct { ... fields ... }; u8 __padding[ARCH_DMA_MINALIGN]; }; void __ctx[] __aligned(CRYPTO_MINALIGN); }; If CRYPTO_MINALIGN is lowered to, say, 8 (to be the same as lowest ARCH_KMALLOC_MINALIGN), the __alignof__(req->__ctx) would be 8. Functions like crypto_tfm_ctx_alignment() will return 8 when what you need is 128. We can change those functions to return ARCH_DMA_MINALIGN instead or always bump cra_alignmask to ARCH_DMA_MINALIGN-1. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel