From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0F86DC433EF for ; Wed, 20 Apr 2022 16:49:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6Sq3l3oPSCIQ6F5uDEuh9szYn8s5EUATf//V461uACg=; b=IDOmmClrwgisbp +Bygm9trm7yLi4oCW6DP6uy4I1HSgtHa9k60KPtvd3kp2Ir1zSjzQ63Cqno5njG1HqBMSszsiAUoD 4CSwCjn49ZDd20ThOp5KJ1zjNz93+i0MmwCtq07JcpMK6z9z3DU4SoQouHdCzYoEXk1F4t6ERE0s8 ljTPG7AVc5ESkcQt3igpsvIQW3w4xU7EXzYFyEaesS1hPE75uzNmgudmkjqHbgi9lU1gCeDnYe+8W oyJtySMaQEoobYT6ccL8J/Mm21DC7BgalRAJHHZquFv1oT4OV59pFhLk21cikdCEIMjlnJ1UfjYNb BR32j2wkl1y1n5DizG2w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nhDUg-009jKn-Mu; Wed, 20 Apr 2022 16:47:54 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nhDUe-009jKa-Q8 for linux-arm-kernel@bombadil.infradead.org; Wed, 20 Apr 2022 16:47:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=bKS1oMWpdnRHK0A8vD5DG4LK4fTxO0LhiZj+ab2wGRI=; b=ZNPSY3wzMxVAp7qqIubhSgrokY wwATMKSnGlOBBihBhFZz6DlYE1KqfLprH3nYxsi1TgbDR2l3A4fOzD3lErNNk8UKfH9Qa4zzSJZjT hpkBwm4sJlTJMMpZPxQEHM82SAcHRbNWnSSI4fwiqVpbesWfdDytIQ+02Mf17zbkVp2cvaDUDZRNw VIAxBBG4ZK98UBkWauk3k3fdg+QLISATUk3cupYOCzFFBN33xw3dpZsE4M/IcQOC6ia1K0BEJiLgR v2S4UjW+5BnMqQZFoARUbcFtAlqpi8gObOLSq3YtDDr4TlPgZrJQebgUjCtWojH0kxPkOHjBMksP0 B6vuwb3g==; Received: from [187.19.239.165] (helo=quaco.ghostprotocols.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nhDUc-007AJm-6n; Wed, 20 Apr 2022 16:47:50 +0000 Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 31D9F400B1; Wed, 20 Apr 2022 13:47:46 -0300 (-03) Date: Wed, 20 Apr 2022 13:47:46 -0300 From: Arnaldo Carvalho de Melo To: Leo Yan Cc: German Gomez , Ali Saidi , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org, benh@kernel.crashing.org, Nick.Forrington@arm.com, alexander.shishkin@linux.intel.com, andrew.kilroy@arm.com, james.clark@arm.com, john.garry@huawei.com, jolsa@kernel.org, kjain@linux.ibm.com, lihuafei1@huawei.com, mark.rutland@arm.com, mathieu.poirier@linaro.org, mingo@redhat.com, namhyung@kernel.org, peterz@infradead.org, will@kernel.org Subject: Re: [PATCH v5 5/5] perf mem: Support mem_lvl_num in c2c command Message-ID: References: <20220408195344.32764-1-alisaidi@amazon.com> <20220408195344.32764-6-alisaidi@amazon.com> <3ad0128a-1b3d-37a7-81f6-fd597b565b18@arm.com> <20220420084823.GE843168@leoy-ThinkPad-X240s> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220420084823.GE843168@leoy-ThinkPad-X240s> X-Url: http://acmel.wordpress.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Em Wed, Apr 20, 2022 at 04:48:23PM +0800, Leo Yan escreveu: > On Mon, Apr 11, 2022 at 11:04:28AM +0100, German Gomez wrote: > > > > On 08/04/2022 20:53, Ali Saidi wrote: > > > In addition to summarizing data encoded in mem_lvl also support data > > > encoded in mem_lvl_num. > > > > > > Since other architectures don't seem to populate the mem_lvl_num field > > > here there shouldn't be a change in functionality. > > > > > > Signed-off-by: Ali Saidi > > > --- > > > tools/perf/util/mem-events.c | 11 +++++++---- > > > 1 file changed, 7 insertions(+), 4 deletions(-) > > > > > > diff --git a/tools/perf/util/mem-events.c b/tools/perf/util/mem-events.c > > > index ed0ab838bcc5..e5e405185498 100644 > > > --- a/tools/perf/util/mem-events.c > > > +++ b/tools/perf/util/mem-events.c > > > @@ -485,6 +485,7 @@ int c2c_decode_stats(struct c2c_stats *stats, struct mem_info *mi) > > > u64 daddr = mi->daddr.addr; > > > u64 op = data_src->mem_op; > > > u64 lvl = data_src->mem_lvl; > > > + u64 lnum = data_src->mem_lvl_num; > > > u64 snoop = data_src->mem_snoop; > > > u64 lock = data_src->mem_lock; > > > u64 blk = data_src->mem_blk; > > > @@ -527,16 +528,18 @@ do { \ > > > if (lvl & P(LVL, UNC)) stats->ld_uncache++; > > > if (lvl & P(LVL, IO)) stats->ld_io++; > > > if (lvl & P(LVL, LFB)) stats->ld_fbhit++; > > > > Just for completion, can we also handle LFB as it seems to be being set > > in "/arch/x86/events/intel/ds.c"? (Sorry I missed this in the v4) > > With fixing LFB issue pointed by German, the change looks good to me: Waiting for a v6 then, please collect Leo's reviewed-by tag when submitting it. - Arnaldo > Reviewed-by: Leo Yan > > It would be appreciate if x86 or PowerPC maintainers could take a look > for this patch. Thanks! > Leo > > > > - if (lvl & P(LVL, L1 )) stats->ld_l1hit++; > > > - if (lvl & P(LVL, L2 )) stats->ld_l2hit++; > > > - if (lvl & P(LVL, L3 )) { > > > + if (lvl & P(LVL, L1) || lnum == P(LVLNUM, L1)) > > > + stats->ld_l1hit++; > > > + if (lvl & P(LVL, L2) || lnum == P(LVLNUM, L2)) > > > + stats->ld_l2hit++; > > > + if (lvl & P(LVL, L3) || lnum == P(LVLNUM, L3)) { > > > if (snoop & P(SNOOP, HITM)) > > > HITM_INC(lcl_hitm); > > > else > > > stats->ld_llchit++; > > > } > > > > > > - if (lvl & P(LVL, LOC_RAM)) { > > > + if (lvl & P(LVL, LOC_RAM) || lnum == P(LVLNUM, RAM)) { > > > stats->lcl_dram++; > > > if (snoop & P(SNOOP, HIT)) > > > stats->ld_shared++; -- - Arnaldo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel