From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3A4B2C433F5 for ; Thu, 21 Apr 2022 06:52:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fE1DO8yJ0UeCyhbvA4On9krpQtpO11FtfEgWwIemn2M=; b=2OlqedlH4S/gGZ 5ca+LUXwiNi+ALBQbO5l9IE31acpOA/EKvvuxkvlAXJgKzw2MTpH79gqJ+8urF/fngoF99RVyPlGJ ct20jH68nJXAx5+XWd+S5FB62ZJXuA5Or4Z85zOGdiF7+FtZVuGg3LCcCnulxRaeJwuv8l45FT8Fc HEYMlpBePGTwd7UJShPTt6hTNer6ApPFlwIz12V5lEH5EtXmIgeBwwdz9vrvKQ/SzDJgtPmcnkgJ6 n0vuSyG9eEnvDyDljDcHDqHGZOj1ZYwO9b0NfP/GiJ5GIcECFD20IAxmOJdMhrPJl9yEglXLCzr3D XYHWSE2uG98UT7iYeiJg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nhQf6-00BruU-4J; Thu, 21 Apr 2022 06:51:32 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nhQem-00BrnC-CY for linux-arm-kernel@lists.infradead.org; Thu, 21 Apr 2022 06:51:13 +0000 Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 704FC8106; Thu, 21 Apr 2022 06:48:20 +0000 (UTC) Date: Thu, 21 Apr 2022 09:51:10 +0300 From: Tony Lindgren To: Puranjay Mohan Cc: linux-kernel@vger.kernel.org, nm@ti.com, devicetree@vger.kernel.org, grygorii.strashko@ti.com, vigneshr@ti.com, mathieu.poirier@linaro.org, kishon@ti.com, linux-remoteproc@vger.kernel.org, bjorn.andersson@linaro.org, rogerq@kernel.org, krzysztof.kozlowski+dt@linaro.org, ssantosh@kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 5/6] soc: ti: pruss: Add helper function to enable OCP master ports Message-ID: References: <20220418123004.9332-1-p-mohan@ti.com> <20220418123004.9332-6-p-mohan@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220418123004.9332-6-p-mohan@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220420_235112_498740_B9487683 X-CRM114-Status: GOOD ( 15.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Puranjay Mohan [220418 12:35]: > From: Suman Anna > +/** > + * pruss_cfg_ocp_master_ports() - configure PRUSS OCP master ports > + * @pruss: the pruss instance handle > + * @enable: set to true for enabling or false for disabling the OCP master ports > + * > + * This function programs the PRUSS_SYSCFG.STANDBY_INIT bit either to enable or > + * disable the OCP master ports (applicable only on SoCs using OCP interconnect > + * like the OMAP family). Clearing the bit achieves dual functionalities - one > + * is to deassert the MStandby signal to the device PRCM, and the other is to > + * enable OCP master ports to allow accesses outside of the PRU-ICSS. The > + * function has to wait for the PRCM to acknowledge through the monitoring of > + * the PRUSS_SYSCFG.SUB_MWAIT bit when enabling master ports. Setting the bit > + * disables the master access, and also signals the PRCM that the PRUSS is ready > + * for Standby. Looks OK to me, some comments regarding runtime PM though for future patching though. Eventually we may want to handle this in drivers/bus/ti-sysc.c so it gets toggled based on runtime PM. The PRUSS sysc register seems to be just a new variant of sysc_regbits_omap4_simple with the standby and status bits added. If using runtime PM for the PRUSS instance is not suitable for managing the standby and status bits, then some comments should be added describing why finer grained control is needed for these bits beyond runtime PM. As far as I'm concerned, these can be done in separate changes, no need to update this patch. Regards, Tony _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel