From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 455C2C433EF for ; Thu, 21 Apr 2022 08:59:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=szmsGBrYCAzYGDyrLD9rUMar/1iq4yu3Pg0ePq+0VrI=; b=JHeChOK7iRmcqj k106DJO/sBgfRZu9trPAJTTi+EWJYO96mEUosKoJZwIcixl0wPY+ElG0ju9U/qWkmD50H1IQQMU2t ktgMQ15huz6yR2yat332Sp/mr1MtjU2i8T1rk/IrULCgGgvYXlhsVfCmcWOQDCsIJU7IKMEuG+Ugw wFAUOjD+eCjX4UMwVCjIC2NSvqBXW1GzhdSZ/mNkWaAD+8iYdzmZl1tGx1fF0JxCgpHiKxd1PYhJw Es6y0sS18i/F7n+jhEfT6fHUtS7EjVINSwqji812ZOQhGWhspcNpnkposTe+eFgyP8xPhG74xEAq1 qVo8Aj7dCi/ws7UuFcRw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nhSdu-00CYNe-0u; Thu, 21 Apr 2022 08:58:26 +0000 Received: from mail.skyhub.de ([5.9.137.197]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nhSdp-00CYKz-9R for linux-arm-kernel@lists.infradead.org; Thu, 21 Apr 2022 08:58:24 +0000 Received: from zn.tnic (p200300ea971b58ed329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:971b:58ed:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 7C0A81EC0494; Thu, 21 Apr 2022 10:58:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1650531493; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=K6LjJUiqWP9JmAH5pCtbEbi7a1uZ4YBTwFyxQHdf9Lg=; b=Tujmid+xug5U5uZ16FWxKvjXm88Ez25HZB78FyF8+JEjZPHMRmRVh85xENutF6BN6j4sD+ HZbhBY8cixey6jD/WnGze8qIsSHA1Ic3364igLmUaZeogZKdgBEXUGIRYS30cY+2g7+SOV jMNv1zGhX4M2PbqZiBbiT6FcB/U1Hgs= Date: Thu, 21 Apr 2022 10:58:08 +0200 From: Borislav Petkov To: Sherry Sun Cc: michal.simek@xilinx.com, Shubhrajyoti.datta@xilinx.com, mchehab@kernel.org, tony.luck@intel.com, james.morse@arm.com, rric@kernel.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com Subject: Re: [PATCH V2 1/2] EDAC: synopsys: Add disable_intr support for V3.X Synopsys EDAC DDR Message-ID: References: <20220421015313.5747-1-sherry.sun@nxp.com> <20220421015313.5747-2-sherry.sun@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220421015313.5747-2-sherry.sun@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220421_015822_620126_A8606EA3 X-CRM114-Status: GOOD ( 10.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > Subject: Re: [PATCH V2 1/2] EDAC: synopsys: Add disable_intr support for V3.X Synopsys EDAC DDR EDAC tree subject prefixes are of the format: EDAC/: Bla... where "Bla starts with a capital letter". What is "disable_intr support"? I can figure it out when looking at the code but you need to make this human-readable. For example "Disable the error interrupt on Synopsys EDAC v3.x hardware" Also, is it all caps V3.X or is it simply v3.x? On Thu, Apr 21, 2022 at 09:53:12AM +0800, Sherry Sun wrote: > V3.X Synopsys EDAC DDR doesn't have the QOS Interrupt register, need > to change to use the ECC Clear Register to disable the interrupts. Not "need to change" but "change". >From Documentation/process/submitting-patches.rst: "Describe your changes in imperative mood, e.g. "make xyzzy do frotz" instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy to do frotz", as if you are giving orders to the codebase to change its behaviour." Please have a look at that document. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel