From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BD8C9C433F5 for ; Fri, 22 Apr 2022 13:00:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=p6SGHUqfAvW2tr2znDcNg81doBxKRYY+bb61EohY4sE=; b=kMAuhICdSxSYbC AhlzlbtOXSUgx0Y4OZEXRsdeEnlvqEL3B7JtE9IEIsQbNwXOJMBSWTq08QpgSk8ZdbTBQpkXozJfk lbo1Y2XrvD857q27Xz3frcpEFDREIhZYvHCpKkEpbuBxULqzGiKHKj8j6zt/D/MAhAxu+E16fpru3 Cy/Aw2iHEF7PiiizaEwUPJDvtMBrqEK20B1WsOMbD0D+jndlKWoY+ayqmeuh+65c1Uitqj1JzoI+n b33ZPeJUNQgWmKC+wCxnXI5FBZFXWn34HZJCYGRfUDXWvHeF5WtsIzNMaJ/lWOow87hRY3hEFLc7U 50/0Wsul9rULEn0TVzsg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nhsss-000VmZ-KM; Fri, 22 Apr 2022 12:59:38 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nhssp-000VkZ-SK for linux-arm-kernel@lists.infradead.org; Fri, 22 Apr 2022 12:59:37 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 301E4B82D1F; Fri, 22 Apr 2022 12:59:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 37AEEC385A4; Fri, 22 Apr 2022 12:59:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1650632372; bh=2xBTNPyOFSDAnCTOxF45zEU4uV1O5Nj2T7kJtpwY7xg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Xi6xSvBE+MFqJSwDeEs374dorQ8uFq8KauulbuJc/jz3ADbihejxlUPopJ/7p5/TO rhm6T0Pi0yfjwx3gie42DxXaj+rhpd+fFttAo45O2dQP6rVNBgQSmtofl4aejr5+ie jR61iQ2B6j+l1KonueGR5vFZhHE+Am2A3GRqc5uQ= Date: Fri, 22 Apr 2022 14:59:29 +0200 From: Greg KH To: Xiaomeng Tong Cc: balbi@kernel.org, michal.simek@xilinx.com, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: gadget: udc-xilinx: remove unnecessary initialization of list iterator Message-ID: References: <20220316075153.3708-1-xiam0nd.tong@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220316075153.3708-1-xiam0nd.tong@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220422_055936_087857_A94DDA3C X-CRM114-Status: GOOD ( 18.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 16, 2022 at 03:51:53PM +0800, Xiaomeng Tong wrote: > 'req' will always be set by the subsequent list_for_each_entry() > before any uses. Thus, to avoid ambiguity it is better to remove > the unnecessary initialization of list iterator 'req'. > > Signed-off-by: Xiaomeng Tong > --- > drivers/usb/gadget/udc/udc-xilinx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/gadget/udc/udc-xilinx.c b/drivers/usb/gadget/udc/udc-xilinx.c > index 6ce886fb7..fa6cbfc63 100644 > --- a/drivers/usb/gadget/udc/udc-xilinx.c > +++ b/drivers/usb/gadget/udc/udc-xilinx.c > @@ -1136,7 +1136,7 @@ static int xudc_ep_queue(struct usb_ep *_ep, struct usb_request *_req, > static int xudc_ep_dequeue(struct usb_ep *_ep, struct usb_request *_req) > { > struct xusb_ep *ep = to_xusb_ep(_ep); > - struct xusb_req *req = to_xusb_req(_req); > + struct xusb_req *req; > struct xusb_udc *udc = ep->udc; > unsigned long flags; > > -- > 2.17.1 > Does not apply anymore :( _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel