From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 224ABC433F5 for ; Fri, 22 Apr 2022 18:04:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=F8AeaO8WnyaO4y8yFaKab8fZBit2j77vVgqwGuUSDZ8=; b=q4hrEwekDgqIaY QC3520ZIT+8/fsMF03IdG474gkfs3B5kCajALGrL9PjC36hTAPxCalcpHPGYkZpeNYSw+PQt7PjQB EP4R934JTC1nFh1/b89VucLmYa2IVO8toCU8GD3pKZovTEiH3qrBhxRzge/Rn2HuLhV3wvwECdgMB Uoy539GpOXa2AJD+hsLHFJmmTh7csUIUlMpUO2DiO6OhEWwHSIPbCp3QlDLrzhOCZYegvoO8RBUpL 3JcRfGu202DaJbBGINw9fTQnzsqUUqi2d2pF184OZzVHmjpUfGT7G/4ks34qNp76hZtnCL5sFplX6 ZAG8p5x4aRqXvfKd7EOA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nhxcd-001slw-RF; Fri, 22 Apr 2022 18:03:11 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nhxca-001slN-1C for linux-arm-kernel@lists.infradead.org; Fri, 22 Apr 2022 18:03:09 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 8413EB83215; Fri, 22 Apr 2022 18:03:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F166FC385A0; Fri, 22 Apr 2022 18:03:01 +0000 (UTC) Date: Fri, 22 Apr 2022 19:02:58 +0100 From: Catalin Marinas To: Peter Collingbourne Cc: Andrey Konovalov , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Andrew Morton , Linux ARM , Linux Memory Management List , Linux Kernel Mailing List , vbabka@suse.cz, penberg@kernel.org, roman.gushchin@linux.dev, iamjoonsoo.kim@lge.com, rientjes@google.com, Herbert Xu , Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , kasan-dev , Eric Biederman , Kees Cook Subject: Re: [PATCH v2] mm: make minimum slab alignment a runtime property Message-ID: References: <20220421211549.3884453-1-pcc@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220421211549.3884453-1-pcc@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220422_110308_260612_503B9A82 X-CRM114-Status: GOOD ( 15.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 21, 2022 at 02:15:48PM -0700, Peter Collingbourne wrote: > diff --git a/include/linux/slab.h b/include/linux/slab.h > index 373b3ef99f4e..80e517593372 100644 > --- a/include/linux/slab.h > +++ b/include/linux/slab.h > @@ -201,21 +201,33 @@ void kmem_dump_obj(void *object); > #endif > > /* > - * Setting ARCH_SLAB_MINALIGN in arch headers allows a different alignment. > + * Setting ARCH_SLAB_MIN_MINALIGN in arch headers allows a different alignment. > * Intended for arches that get misalignment faults even for 64 bit integer > * aligned buffers. > */ > -#ifndef ARCH_SLAB_MINALIGN > -#define ARCH_SLAB_MINALIGN __alignof__(unsigned long long) > +#ifndef ARCH_SLAB_MIN_MINALIGN > +#define ARCH_SLAB_MIN_MINALIGN __alignof__(unsigned long long) > +#endif Sorry, only a drive-by comment, I'll look at the arm64 parts next week. I've seen it mentioned in the first version, what's the point of MIN_MIN and not just MIN? -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel